Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 222959 - Review Request: smolt - Fedora Hardware Profiler
Summary: Review Request: smolt - Fedora Hardware Profiler
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jeffrey C. Ollie
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-01-17 03:33 UTC by Mike McGrath
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-01-19 19:37:02 UTC
Type: ---
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Mike McGrath 2007-01-17 03:33:57 UTC
Spec URL:

The Fedora hardware profiler is a server-client system that does a hardware
scan against a machine and sends the results to a server to a Fedora Project
turbogears server.  The sends are anonymous and should not contain any private
information other than the physical hardware information and basic OS info.

Comment 1 Mike McGrath 2007-01-18 15:57:15 UTC
Spec URL:

Upstream (me) released new version

Comment 2 Jeffrey C. Ollie 2007-01-18 19:41:54 UTC
* source files match upstream (but see below)

$ md5sum smolt-0.3.tar.gz\?format\=raw sources/smolt-0.3.tar.gz 
ec06dc7c2f680bb8b433153e9ce33a25  smolt-0.3.tar.gz?format=raw
ec06dc7c2f680bb8b433153e9ce33a25  sources/smolt-0.3.tar.gz

$ sha1sum smolt-0.3.tar.gz\?format\=raw sources/smolt-0.3.tar.gz 
b8c3162714ca5631bc5104635e86e8d7c7cebb62  smolt-0.3.tar.gz?format=raw
b8c3162714ca5631bc5104635e86e8d7c7cebb62  sources/smolt-0.3.tar.gz

* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (fc6 i386).
* package installs properly. 
* rpmlint says:

E: smolt no-cleaning-of-buildroot %install

%install needs to start with "rm -rf %{buildroot}"

W: smolt no-%build-section

Please add, even if it's empty.

E: smolt non-executable-script /usr/share/smolt/client/ 0644
E: smolt non-executable-script /usr/share/smolt/client/ 0644
E: smolt non-executable-script /usr/share/smolt/client/ 0644

This is because there's "#!/usr/bin/python" lines in the files.  They
can either be dealt with in the .spec file with something like this:

%{__sed} -i -e '/^#!/,1d'

or since you are the upstream it's probably better to make the change there
and release a new version.

E: smolt zero-length /etc/sysconfig/hw-uuid

It would probably be better to mark this as %ghost

W: smolt-server no-documentation

When you write some documentation you can add it ;).  Until then we
can ignore...

* %check is not present; There is no test code in the distribution.
* no shared libraries are present
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers
* no unversioned .so file
* no pkconfig file
* no libtool .la droppings.

Needs fixing:

* I'd recommend <> for
  the URL rather than a pointer to the main project page.

* The URL specified for the source doesn't work directly, instead this
  is the URL that gets you the actual package.  Unfortunately that
  won't work for the source line.

* smolt package needs to Require wget

* I would recommend a slight modification to the %post script:

if ! -s %{_sysconfdir}/sysconfig/hw-uuid
    /bin/cat /proc/sys/kernel/random/uuid > %{_sysconfdir}/sysconfig/hw-uuid
    /bin/chmod 0644 %{_sysconfdir}/sysconfig/hw-uuid
    /bin/chown root:root %{_sysconfdir}/sysconfig/hw-uuid

Comment 3 Mike McGrath 2007-01-18 20:22:06 UTC
Spec URL:

- New upstream version
- Altered post install section
- Added wget requires

Comment 4 Jeffrey C. Ollie 2007-01-18 21:25:17 UTC
OK, rpmlint says this:

W: smolt dangerous-command-in-%post chmod
W: smolt-server no-documentation

I think that both of those can be ignored.  The only remaining issue is the URL
of the tarball.  The URL in the source tag didn't change but I don't see the
tarball up on the smolt trac wiki.

Comment 5 Mike McGrath 2007-01-18 21:32:59 UTC
I've uploaded the URL to hosted.  Do I need to find raw-hosting space to get it
into extras or will this do?

Comment 6 Jeffrey C. Ollie 2007-01-18 22:06:40 UTC
Put some documentation in the .spec file about the problem until the Fedora
hosted project gets it's raw webspace figured out.  You can do that after/before
import.   Now that the tarball is available somewhere I'll mark this as APPROVED.

Comment 7 Mike McGrath 2007-01-19 19:37:02 UTC
Thanks for the quick response.  This is imported and build.  Should be on the
mirrors soon.

Comment 8 Jeffrey C. Ollie 2007-03-13 15:45:23 UTC
Please add jeff as co-owner.

Note You need to log in before you can comment on or make changes to this bug.