Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2233235 - No custom Qt theming for Fedora Workstation
Summary: No custom Qt theming for Fedora Workstation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Changes Tracking
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Grulich
QA Contact:
URL:
Whiteboard:
: 2226797 2231898 2231902 (view as bug list)
Depends On: 2235246
Blocks: F39Changes
TreeView+ depends on / blocked
 
Reported: 2023-08-21 18:47 UTC by Adam Williamson
Modified: 2023-11-14 18:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-14 18:57:27 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Adam Williamson 2023-08-21 18:47:40 UTC 
This is a tracking bug for Change: No custom Qt theming for Fedora Workstation
For more details, see: https://fedoraproject.org/wiki/Changes/NoCustomQtThemingForWorkstation

Fedora Workstation has been using QGnomePlatform and Adwaita-qt projects to apply GNOME-like configuration and styling to Qt applications to match the environment. These projects are now in a state where they are outdated and semi-occasionally broken for some applications and it would be better to default to what Qt upstream has to offer.

If you encounter a bug related to this Change, please do not comment here. Instead create a new bug and set it to block this bug.
Comment 1 Adam Williamson 2023-08-22 21:38:53 UTC 
*** Bug 2226797 has been marked as a duplicate of this bug. ***
Comment 2 Adam Williamson 2023-08-22 21:43:12 UTC 
So, this seems to be in progress, but not sure if it's complete. 0d3474d729400fa2bbb4dab87855aae4d31ac113 in fedora-comps dropped the packages from the Workstation group. There seems to have been an attempt to backport some improvements from qt6 to qt5:

https://src.fedoraproject.org/rpms/qt5-qtbase/c/6ad7f138fefb734bfdc66272d1e1ed75fcc253f3?branch=rawhide

but this was reverted as it caused problems:

https://src.fedoraproject.org/rpms/qt5-qtbase/c/d2061e22753c8900b29da9dfda4e7f16a48a0fdc?branch=rawhide

so, my best guess of the status here is MODIFIED (testable but not 100% complete yet).
Comment 3 Jan Grulich 2023-08-23 05:28:11 UTC 
This change is complete and all changes have been pushed to dist-git and built, however, due to an issue I found a day before, I didn't manage to submit updates in time (I missed it by an hour) and that makes following updates blocked by F39 freeze:
qt5-qtbase and qt5-qtwayland: https://bodhi.fedoraproject.org/updates/FEDORA-2023-889efda25b
qgnomeplatform: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4ca137cacd
Comment 4 Jan Grulich 2023-08-23 05:29:28 UTC 
(In reply to Adam Williamson from comment #2)
> 
> but this was reverted as it caused problems:
> 
> https://src.fedoraproject.org/rpms/qt5-qtbase/c/
> d2061e22753c8900b29da9dfda4e7f16a48a0fdc?branch=rawhide

This was an unnecessary backport that I reverted, but it doesn't have any implications on this change.
Comment 5 Jan Grulich 2023-08-23 05:43:30 UTC 
*** Bug 2231898 has been marked as a duplicate of this bug. ***
Comment 6 Adam Williamson 2023-08-23 05:46:21 UTC 
*** Bug 2231902 has been marked as a duplicate of this bug. ***
Comment 7 Fedora Blocker Bugs Application 2023-08-23 15:57:03 UTC 
Proposed as a Freeze Exception for 39-beta by Fedora user jgrulich using the blocker tracking app because:

 Following updates:
- https://bodhi.fedoraproject.org/updates/FEDORA-2023-889efda25b
- https://bodhi.fedoraproject.org/updates/FEDORA-2023-4ca137cacd

are implementing the F39 change mentioned in the bug 2233235. I started with builds on Monday, but I found an issue which I solved on Tuesday and sadly missed the deadline by an hour so the updates got stuck in testing instead of going to stable as F39 is now freezed. The feature is now half-implemented as Qt6 packages are in, but Qt5 are not.
Comment 8 Adam Williamson 2023-08-27 16:24:05 UTC 
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1184 , marking accepted. Bit unfortunate this will now land some time after freeze, but that's mostly on us for taking a while to vote.
Comment 9 Jan Grulich 2023-08-28 06:26:31 UTC 
Hi Adam, I can see QGnomePlatform update heading to stable, but not the update with qtbase and qtwayland (https://bodhi.fedoraproject.org/updates/FEDORA-2023-889efda25b). Was this update missed?
Comment 10 Adam Williamson 2023-08-28 06:31:03 UTC 
I didn't do any pushing yet. You're just seeing statuses resulting from gating or karma or something.
Comment 11 Adam Williamson 2023-08-28 06:31:56 UTC 
However, if that update should be pushed to resolve this FE, it should be marked as fixing this bug. I can't find all the update associations on my own. I need maintainers to do that for me.
Comment 12 Adam Williamson 2023-08-28 06:33:07 UTC 
Of course, that's why Change tracker bugs should not be directly proposed as blockers or FEs; it makes things awkward because Change tracker bugs should *not* be closed, but blocker/FE bugs *must* be closed. A separate bug should have been filed, proposed as an FE, and marked as blocking *this* bug. I can do that later.
Comment 13 Adam Williamson 2023-08-28 06:50:22 UTC 
Filed https://bugzilla.redhat.com/show_bug.cgi?id=2235246 and transferred the FE status there.
Comment 14 Adam Williamson 2023-08-28 15:44:36 UTC 
Jan: so because one is critical path but the other is not, they have different automatic stable push settings. qgnomeplatform is not critical path, so it has "stable by time" set to 3 days, and 3 days passed, so it was auto-submitted for stable. The other update, being critical path, has it set to 14 days, and that is the minimum wait time by policy, so it cannot be submitted for stable yet. It will have to wait 14 days unless it gets +2 karma, so we need folks to test and karma it.
Comment 15 Jan Grulich 2023-08-29 06:36:38 UTC 
(In reply to Adam Williamson from comment #14)
> Jan: so because one is critical path but the other is not, they have
> different automatic stable push settings. qgnomeplatform is not critical
> path, so it has "stable by time" set to 3 days, and 3 days passed, so it was
> auto-submitted for stable. The other update, being critical path, has it set
> to 14 days, and that is the minimum wait time by policy, so it cannot be
> submitted for stable yet. It will have to wait 14 days unless it gets +2
> karma, so we need folks to test and karma it.

It is now submitted to stable thanks to karma.
Comment 16 Adam Williamson 2023-09-21 19:09:02 UTC 
The two updates are now stable, and jgrulich confirms this should be considered 100% implemented now. Setting ON_QA.
Comment 17 Aoife Moloney 2023-11-14 18:57:27 UTC 
F39 was released on November 7th, so I am closing this tracker. If this Change was not completed, please notify me ASAP.
Note You need to log in before you can comment on or make changes to this bug.