Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2241761 - cancelling partition editing by Esc doesn't cancel, but CONFIRMS the dialog
Summary: cancelling partition editing by Esc doesn't cancel, but CONFIRMS the dialog
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: blivet-gui
Version: 39
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vojtech Trefny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F39FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2023-10-02 14:10 UTC by Kamil Páral
Modified: 2023-10-09 22:26 UTC (History)
7 users (show)

Fixed In Version: blivet-gui-2.4.2-4.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-09 22:26:05 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
screencast demonstration of the bug (deleted)
2023-10-02 14:10 UTC, Kamil Páral 		no flags Details
View All

Description Kamil Páral 2023-10-02 14:10:03 UTC 
Description of problem:
If if invoke a dialog on a partition in blivet-gui and then hit Esc for cancelling it, it doesn't cancel the action, it CONFIRMS it. This happens at least for Format partition, Resize partition (if you change the slider) and Set label actions, but possibly for other actions as well.

This is of course completely wrong, at causes a high risk that users lose their data by accident. For example, if you invoke Format partition dialog on a wrong partition, realize it, hit Esc, and then select the right partition and ask to format that one, *both* your partitions will get formatted, and you'll probably lose data.

You can see that the action is incorrectly added to the "pending actions" list, so it's possible that some users will spot this error. But if you already have multiple actions pending, it's very hard to see that one additional action was added by accident.

Version-Release number of selected component (if applicable):
blivet-gui-runtime-2.4.2-2.fc39.noarch
Fedora-Workstation-Live-x86_64-39-20231002.n.0.iso

How reproducible:
always

Steps to Reproduce:
1. select a partition in blivet-gui
2. invoke e.g. the Format dialog
3. hit Esc
4. look into Pending actions, the partition is going to be reformatted
Comment 1 Kamil Páral 2023-10-02 14:10:28 UTC 
Created attachment 1991620 [details]
screencast demonstration of the bug
Comment 2 Kamil Páral 2023-10-02 14:11:04 UTC 
I don't think we want to release F39 like this. Proposing for a blocker discussion.
Comment 3 Aoife Moloney 2023-10-02 17:06:30 UTC 
Discussed during the 2023-10-02 blocker review meeting: [1]

The decision to classify this bug as a FreezeException (Final) was made:

"While we see this a bad issue, it's presence in F38 tempers our ability to make an outright decision at the moment. We do grant it FE status"


[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2023-10-02/f39-blocker-review.2023-10-02-16.01.log.txt
Comment 4 Vojtech Trefny 2023-10-05 11:31:20 UTC 
upstream PR: https://github.com/storaged-project/blivet-gui/pull/414
Comment 5 Kamil Páral 2023-10-06 07:49:12 UTC 
Hey Vojtech, I see that this is now merged. Can you please create a blivet-gui update asap? Thanks!
Comment 6 Fedora Update System 2023-10-06 19:28:58 UTC 
FEDORA-2023-e9198d932d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e9198d932d
Comment 7 Fedora Update System 2023-10-07 02:33:14 UTC 
FEDORA-2023-e9198d932d has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e9198d932d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e9198d932d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Kamil Páral 2023-10-09 09:51:16 UTC 
Vojtěch, the fix looks good for all actions that I've tried. But for "Set mountpoint" action, I see "DEBUG:blivet-gui-utils:Setting mountpoint for device 'vda2'" printed in the journal, even when I hit Esc. But the actual mountpoint doesn't seem to be set, so hopefully this is just a stray debug message and it correctly cancels the action?
Comment 9 Vojtech Trefny 2023-10-09 12:21:32 UTC 
Yes, it's just logging of the action being wrong. I have a fix for that: https://github.com/storaged-project/blivet-gui/pull/415 but I think it's not a big issue so we don't need a new build just to fix that.
Comment 10 Lukas Ruzicka 2023-10-09 12:25:17 UTC 
This works for me, and also for Kamil. Vojta confirmed that the debug line has no effect on the functionality of this fix, therefore I think we can consider this as verified.
Comment 11 Adam Williamson 2023-10-09 15:27:04 UTC 
+6 / -2 in https://pagure.io/fedora-qa/blocker-review/issue/1358 , marking accepted blocker.
Comment 12 Fedora Update System 2023-10-09 22:26:05 UTC 
FEDORA-2023-e9198d932d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.