Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2242454 - DBusActivatable is not implemented correctly
Summary: DBusActivatable is not implemented correctly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: firefox
Version: 38
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Martin Stransky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
: 2242473 2242480 2242495 (view as bug list)
Depends On:
Blocks: F39FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2023-10-06 09:24 UTC by Tobias Neitzel
Modified: 2023-10-10 01:33 UTC (History)
17 users (show)

Fixed In Version: firefox-118.0.1-7.fc40 firefox-118.0.1-7.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-09 22:26:50 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Tobias Neitzel 2023-10-06 09:24:57 UTC 
A recent change within the firefox packaging (https://src.fedoraproject.org/rpms/firefox/c/85de885472621621af497b204a2f45f7122e8a23?branch=86e26c4189a0192cd1185839e03a9ffcb4fbde75) set DBusActivatable=true within the .desktop file of Firefox. However, the other package contents do not follow the specification (https://wiki.gnome.org/HowDoI/DBusApplicationLaunching). I have no prior experience in this topic, but if I understand it correctly, the problems are:

1. The GApplication application ID used by firefox (which is just "firefox") is invalid. A valid ID would be something like org.mozilla.firefox.
2. There is no D-Bus service file for firefox itself, but only for it's search provider.

When launching firefox in the current configuration with a launcher that is DBusActivatable-Aware, the application launch fails. The error message is something like this:

Invalid bus name 'firefox': must contain '.'

Reproducible: Always

Steps to Reproduce:
I noticed the issue while using Qubes OS, which makes reproducing it maybe a little bit difficult. However, here are the stepts to reproduce:

1. Install Qubes OS
2. Install fedora-38 template
3. Attempt to launch firefox via the application launcher
Actual Results:  
Nothing happens. The following error message can be found within the journal:

Traceback (most recent call last):
  File "/etc/qubes-rpc/qubes.StartApp", line 39, in <module>
    main(sys.argv)
  File "/etc/qubes-rpc/qubes.StartApp", line 33, in main
    launch(os.path.join(raw_volume, f))
  File "/usr/lib/python3.11/site-packages/qubesagent/xdg.py", line 106, in launch
    proxy = bus.get_object(service_id, object_path)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/site-packages/dbus/bus.py", line 237, in get_object
    return self.ProxyObjectClass(self, bus_name, object_path,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/site-packages/dbus/proxies.py", line 241, in __init__
    _dbus_bindings.validate_bus_name(bus_name)
ValueError: Invalid bus name 'firefox': must contain '.'


Expected Results:  
Firefox should start without any issues.

We also created a pull request in Qubes to prevent this behvaior: https://github.com/QubesOS/qubes-core-agent-linux/pull/463

However, we believe that the actual bug is the incorrect packaging of firefox.
Comment 1 Martin Stransky 2023-10-06 09:34:09 UTC 
Yes, you're right. firefox.desktop instead of org.mozilla.firefox.desktop is used as desktop file name change breaks recent Fedora release / Gnome shell default applications. We may not rename application desktop file for live release. I'd like to switch firefox desktop name for future Fedoras.
Comment 2 Nicolas Fella 2023-10-06 12:42:35 UTC 
There's a workaround in Plasma: https://invent.kde.org/frameworks/kio/-/merge_requests/1440

However the root cause is in the packaging as described.

That said I find it rather questionable that upstream Firefox does not ship a desktop file itself and Fedora has to patch one in
Comment 3 Fedora Blocker Bugs Application 2023-10-06 13:02:42 UTC 
Proposed as a Blocker for 39-final by Fedora user aleasto using the blocker tracking app because:

 It's not possible to start Firefox from the application menu in the KDE spin
Comment 4 Nicolas Fella 2023-10-06 13:05:01 UTC 
Given that this makes Plasma crash when launching Firefox on Fedora 38 I'd suggest to revert the DBusActivatable=true change ASAP
Comment 5 Nicolas Fella 2023-10-06 13:31:36 UTC 
Does Firefox even implement the org.freedesktop.Application interface required for DBus activation? I don't think so, and that would be another way this is broken
Comment 6 Martin Stransky 2023-10-06 15:05:53 UTC 
*** Bug 2242495 has been marked as a duplicate of this bug. ***
Comment 7 Martin Stransky 2023-10-06 15:06:36 UTC 
*** Bug 2242480 has been marked as a duplicate of this bug. ***
Comment 8 Martin Stransky 2023-10-06 15:06:38 UTC 
*** Bug 2242473 has been marked as a duplicate of this bug. ***
Comment 9 Martin Stransky 2023-10-06 15:13:04 UTC 
DBusActivatable is removed from desktop file in firefox-118.0.1-6 builds.
Comment 10 Adam Williamson 2023-10-06 15:36:57 UTC 
Martin, when you create updates for this, can you mark *only* the F39 update as 'close bugs on stable'? As it's proposed as an F39 blocker (and will likely be accepted) we don't want the F38 update push (which will likely happen very quickly) to close it. Thanks!
Comment 11 Fedora Update System 2023-10-06 16:45:01 UTC 
FEDORA-2023-045b111fad has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-045b111fad
Comment 12 Alessandro Astone 2023-10-06 17:02:24 UTC 
Please include this in the update https://src.fedoraproject.org/rpms/firefox/pull-request/62
Comment 13 Adam Williamson 2023-10-07 00:03:25 UTC 
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1389 , marking accepted.
Comment 14 Fedora Update System 2023-10-07 02:33:05 UTC 
FEDORA-2023-045b111fad has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-045b111fad`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-045b111fad

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 15 Fedora Update System 2023-10-07 05:50:54 UTC 
FEDORA-2023-05eff15d4a has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-05eff15d4a
Comment 16 Fedora Update System 2023-10-07 06:46:10 UTC 
FEDORA-2023-05eff15d4a has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 17 Adam Williamson 2023-10-07 15:14:10 UTC 
Not fixed for F39 yet.
Comment 18 Fedora Update System 2023-10-08 00:23:26 UTC 
FEDORA-2023-6eb5ff1964 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6eb5ff1964
Comment 19 Fedora Update System 2023-10-08 00:23:27 UTC 
FEDORA-2023-09ec498a2a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-09ec498a2a
Comment 20 Fedora Update System 2023-10-08 00:23:27 UTC 
FEDORA-2023-72f64210a2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-72f64210a2
Comment 21 Fedora Update System 2023-10-09 01:55:37 UTC 
FEDORA-2023-72f64210a2 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 22 Fedora Update System 2023-10-09 02:08:45 UTC 
FEDORA-2023-09ec498a2a has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-09ec498a2a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-09ec498a2a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 23 Fedora Update System 2023-10-09 02:34:52 UTC 
FEDORA-2023-6eb5ff1964 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6eb5ff1964`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6eb5ff1964

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 24 Kamil Páral 2023-10-09 11:10:14 UTC 
Bodhi feedback is good, setting as verified.
Comment 25 Fedora Update System 2023-10-09 22:26:01 UTC 
FEDORA-2023-045b111fad has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 26 Fedora Update System 2023-10-09 22:26:50 UTC 
FEDORA-2023-6eb5ff1964 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 27 Fedora Update System 2023-10-10 01:33:25 UTC 
FEDORA-2023-09ec498a2a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.