Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2256960 - Review Request: rust-lz4 - Rust LZ4 bindings library
Summary: Review Request: rust-lz4 - Rust LZ4 bindings library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/lz4
Whiteboard:
Depends On:
Blocks: fedora-neuro, NeuroFedora 2246802 2257076
TreeView+ depends on / blocked
 
Reported: 2024-01-05 16:44 UTC by Ben Beasley
Modified: 2024-01-28 03:07 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-06 20:42:23 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+

Attachments (Terms of Use)

Description Ben Beasley 2024-01-05 16:44:32 UTC 
Spec URL: https://music.fedorapeople.org/rust-lz4.spec
SRPM URL: https://music.fedorapeople.org/rust-lz4-1.24.0-1.fc39.src.rpm

Description:

Rust LZ4 bindings library.

Fedora Account System Username: music

This is a dependency for python-cramjam, which is a dependency for current versions of python-fastavro. It will be a neuro-sig package (in addition to a rust-sig package).

Koji scratch build (F40/Rawhide):

https://koji.fedoraproject.org/koji/taskinfo?taskID=111340352

Since the dependency rust-lz4-sys is very new, it may not yet be included in a Rawhide compose. If fedora-review fails with a missing dependency on crate(lz4-sys), pass --mock-options=--enablerepo=local to fedora-review to use packages from the Koji buildroot.
Comment 1 Fedora Review Service 2024-01-05 16:47:43 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6866809
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256960-rust-lz4/fedora-rawhide-x86_64/06866809-rust-lz4/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Fabio Valentini 2024-01-06 19:58:32 UTC 
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (with one valid, documented exception)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- unwanted "lz4" executable is prevented from being built / shipped
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

PS: I don't think it's necessary to keep the whole docmatic error message.
But thank you for documenting your changes to the generated spec file so thoroughly!
Comment 3 Ben Beasley 2024-01-06 20:24:54 UTC 
Thank you for the review!
Comment 4 Fedora Admin user for bugzilla script actions 2024-01-06 20:25:13 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lz4
Comment 5 Ben Beasley 2024-01-06 20:28:56 UTC 
https://release-monitoring.org/project/370771/
Comment 6 Fedora Update System 2024-01-06 20:39:24 UTC 
FEDORA-2024-303607fa62 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-303607fa62
Comment 7 Fedora Update System 2024-01-06 20:42:23 UTC 
FEDORA-2024-303607fa62 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 8 Fedora Update System 2024-01-17 20:33:13 UTC 
FEDORA-2024-0407cd3e71 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407cd3e71
Comment 9 Fedora Update System 2024-01-17 20:43:46 UTC 
FEDORA-2024-080062b0df has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-080062b0df
Comment 10 Fedora Update System 2024-01-17 21:15:30 UTC 
FEDORA-EPEL-2024-5446a7b08a has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-5446a7b08a
Comment 11 Fedora Update System 2024-01-18 01:50:45 UTC 
FEDORA-EPEL-2024-5446a7b08a has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-5446a7b08a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Fedora Update System 2024-01-18 02:11:38 UTC 
FEDORA-2024-080062b0df has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-080062b0df \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-080062b0df

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 13 Fedora Update System 2024-01-19 01:40:10 UTC 
FEDORA-2024-0407cd3e71 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407cd3e71 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407cd3e71

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 14 Fedora Update System 2024-01-19 03:33:11 UTC 
FEDORA-2024-080062b0df has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-080062b0df \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-080062b0df

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 15 Fedora Update System 2024-01-20 03:24:32 UTC 
FEDORA-2024-0407cd3e71 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407cd3e71 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407cd3e71

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 16 Fedora Update System 2024-01-26 01:01:23 UTC 
FEDORA-EPEL-2024-5446a7b08a has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 17 Fedora Update System 2024-01-27 02:11:45 UTC 
FEDORA-2024-080062b0df has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 18 Fedora Update System 2024-01-28 03:07:18 UTC 
FEDORA-2024-0407cd3e71 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.