Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2264069 - Review Request: python-wsgidav - Generic and extendable WebDAV server based on WSGI
Summary: Review Request: python-wsgidav - Generic and extendable WebDAV server based o...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/mar10/wsgidav
Whiteboard:
Depends On:
Blocks: fedora-neuro, NeuroFedora
TreeView+ depends on / blocked
 
Reported: 2024-02-13 17:00 UTC by Ben Beasley
Modified: 2024-02-29 02:33 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-15 16:36:30 UTC
Type: Bug
Embargoed:
benson_muite: fedora-review+

Attachments (Terms of Use)

Description Ben Beasley 2024-02-13 17:00:32 UTC 
Spec URL: https://music.fedorapeople.org/python-wsgidav.spec
SRPM URL: https://music.fedorapeople.org/python-wsgidav-4.3.0-1.fc39.src.rpm

Description:

A generic and extendable WebDAV server written in Python and based on WSGI.

Main features:
  
  • WsgiDAV is a stand-alone WebDAV server with SSL support, that can be
    installed and run as Python command line script.
  • The python-pam library is needed as extra requirement if pam-login
    authentication is used on Linux or OSX.
  • WebDAV is a superset of HTTP, so WsgiDAV is also a performant,
    multi-threaded web server with SSL support.
  • WsgiDAV is also a Python library that implements the WSGI protocol and can
    be run behind any WSGI compliant web server.
  • WsgiDAV is implemented as a configurable stack of WSGI middleware
    applications. Its open architecture allows to extend the functionality and
    integrate WebDAV services into your project. Typical use cases are:
      • Expose data structures as virtual, editable file systems.
      • Allow online editing of MS Office documents.

Fedora Account System Username: music

This is a test dependency for https://pypi.org/project/webdav4/, which is required for https://pypi.org/project/snakemake-storage-plugin-webdav/; see https://pagure.io/neuro-sig/NeuroFedora/issue/569. This will be a neuro-sig package.
Comment 1 Fedora Review Service 2024-02-13 17:03:40 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7012146
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264069-python-wsgidav/fedora-rawhide-x86_64/07012146-python-wsgidav/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Benson Muite 2024-02-14 15:28:21 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "Apache License 2.0". 133 files have unknown license.
     Detailed output of licensecheck in /home/fedora/2264069-python-
     wsgidav/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.12/site-packages,
     /usr/lib/python3.12
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ ]: Macros in Summary, %description expandable at SRPM build time.
     Note: Macros in: python3-wsgidav (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 21844 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-wsgidav-4.3.0-1.fc40.noarch.rpm
          python-wsgidav-4.3.0-1.fc40.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmptt3i31vo')]
checks: 32, packages: 2

python-wsgidav.src: E: spelling-error ('pam', '%description -l en_US pam -> map, Pam, pan')
python-wsgidav.src: E: spelling-error ('superset', '%description -l en_US superset -> super set, super-set, supersede')
python-wsgidav.src: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance')
python3-wsgidav.noarch: E: spelling-error ('pam', '%description -l en_US pam -> map, Pam, pan')
python3-wsgidav.noarch: E: spelling-error ('superset', '%description -l en_US superset -> super set, super-set, supersede')
python3-wsgidav.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance')
python3-wsgidav.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/wsgidav/prop_man/__init__.py /usr/lib/python3.12/site-packages/wsgidav/lock_man/__init__.py
 2 packages and 0 specfiles checked; 6 errors, 1 warnings, 13 filtered, 6 badness; has taken 2.0 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-wsgidav.noarch: E: spelling-error ('pam', '%description -l en_US pam -> map, Pam, pan')
python3-wsgidav.noarch: E: spelling-error ('superset', '%description -l en_US superset -> super set, super-set, supersede')
python3-wsgidav.noarch: E: spelling-error ('performant', '%description -l en_US performant -> perform ant, perform-ant, performance')
python3-wsgidav.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/wsgidav/prop_man/__init__.py /usr/lib/python3.12/site-packages/wsgidav/lock_man/__init__.py
 1 packages and 0 specfiles checked; 3 errors, 1 warnings, 8 filtered, 3 badness; has taken 0.3 s 



Source checksums
----------------
https://github.com/mar10/wsgidav/archive/v4.3.0/wsgidav-4.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : ed8a6c77936bb43bab599d6a43619505427c35d269f1b2b3e1572d36a09753a2
  CHECKSUM(SHA256) upstream package : ed8a6c77936bb43bab599d6a43619505427c35d269f1b2b3e1572d36a09753a2


Requires
--------
python3-wsgidav (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.12dist(defusedxml)
    python3.12dist(jinja2)
    python3.12dist(json5)
    python3.12dist(pyyaml)



Provides
--------
python3-wsgidav:
    python-wsgidav
    python3-wsgidav
    python3.12-wsgidav
    python3.12dist(wsgidav)
    python3dist(wsgidav)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2264069
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: PHP, Java, R, C/C++, SugarActivity, Ocaml, fonts, Perl, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments:
a) Unclear why the folders /usr/lib/python3.12/site-packages
and /usr/lib/python3.12 are indicated as not owned.
b) Everything else seems ok.
Comment 3 Ben Beasley 2024-02-14 17:49:16 UTC 
Thank you for the review!

> a) Unclear why the folders /usr/lib/python3.12/site-packages
> and /usr/lib/python3.12 are indicated as not owned.

This appears to be a fedora-review bug, although I cannot explain exactly how it is failing. We can clearly see that the dependency is there:

Requires
--------
python3-wsgidav (rpmlib, GLIBC filtered):
    /usr/bin/python3

$ repoquery -q --repo=rawhide{,-source} --whatprovides '/usr/bin/python3'
python3-0:3.12.2-1.fc40.i686
python3-0:3.12.2-1.fc40.x86_64
$ repoquery -q --repo=rawhide{,-source} --requires python3-0:3.12.2-1.fc40.x86_64
libc.so.6(GLIBC_2.34)(64bit)
libpython3.12.so.1.0()(64bit)
python3-libs(x86-64) = 3.12.2-1.fc40
rtld(GNU_HASH)
$ repoquery -q --repo=rawhide{,-source} --whatprovides 'python3-libs(x86-64)'
python3-libs-0:3.12.2-1.fc40.x86_64
$ repoquery -q --repo=rawhide{,-source} -l python3-libs-0:3.12.2-1.fc40.x86_64 | grep -E 'python3\.12(/site-packages)?$'
/usr/include/python3.12
/usr/lib/python3.12
/usr/lib/python3.12/site-packages
/usr/lib64/python3.12
/usr/lib64/python3.12/site-packages

Please let me know if anything else is required for approval. Thanks!
Comment 4 Benson Muite 2024-02-15 06:08:34 UTC 
Thanks. Approved.

Created bug for fedora-review:
https://bugzilla.redhat.com/show_bug.cgi?id=2264345
Maybe additional people are needed to maintain fedora-review? There are a number of open issues and pull
requests that are not getting resolved.
Comment 5 Ben Beasley 2024-02-15 16:15:16 UTC 
Thank you for the review!
Comment 6 Ben Beasley 2024-02-15 16:15:47 UTC 
https://release-monitoring.org/project/220438/
Comment 7 Fedora Admin user for bugzilla script actions 2024-02-15 16:16:55 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-wsgidav
Comment 8 Fedora Update System 2024-02-15 16:33:35 UTC 
FEDORA-2024-d81ea3e623 (python-wsgidav-4.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d81ea3e623
Comment 9 Fedora Update System 2024-02-15 16:36:30 UTC 
FEDORA-2024-d81ea3e623 (python-wsgidav-4.3.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 10 Fedora Update System 2024-02-15 16:40:42 UTC 
FEDORA-2024-778917ee71 (python-wsgidav-4.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-778917ee71
Comment 11 Fedora Update System 2024-02-15 16:42:29 UTC 
FEDORA-2024-778917ee71 (python-wsgidav-4.3.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 12 Fedora Update System 2024-02-15 16:52:38 UTC 
FEDORA-2024-fd3e384f8c (python-wsgidav-4.3.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd3e384f8c
Comment 13 Fedora Update System 2024-02-15 16:58:23 UTC 
FEDORA-2024-4e77fed309 (python-wsgidav-4.3.0-1.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4e77fed309
Comment 14 Fedora Update System 2024-02-15 17:27:12 UTC 
FEDORA-EPEL-2024-d0a5025987 (python-wsgidav-4.3.0-2.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d0a5025987
Comment 15 Fedora Update System 2024-02-16 01:04:02 UTC 
FEDORA-2024-4e77fed309 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4e77fed309 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4e77fed309

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 16 Fedora Update System 2024-02-16 01:16:20 UTC 
FEDORA-2024-fd3e384f8c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fd3e384f8c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fd3e384f8c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 17 Fedora Update System 2024-02-16 01:32:55 UTC 
FEDORA-EPEL-2024-d0a5025987 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d0a5025987

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 18 Fedora Update System 2024-02-21 01:51:05 UTC 
FEDORA-EPEL-2024-35195ba1b2 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-35195ba1b2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 19 Fedora Update System 2024-02-21 02:02:47 UTC 
FEDORA-2024-75045420a9 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-75045420a9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-75045420a9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 20 Fedora Update System 2024-02-21 02:35:10 UTC 
FEDORA-2024-13cc85a040 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-13cc85a040`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-13cc85a040

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 21 Fedora Update System 2024-02-29 01:57:10 UTC 
FEDORA-2024-75045420a9 (python-wsgidav-4.3.0-2.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 22 Fedora Update System 2024-02-29 02:06:09 UTC 
FEDORA-2024-13cc85a040 (python-wsgidav-4.3.0-2.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 23 Fedora Update System 2024-02-29 02:33:59 UTC 
FEDORA-EPEL-2024-35195ba1b2 (python-wsgidav-4.3.0-3.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.