Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2268677 - Review Request: python-pytest-qt - pytest support for PyQt and PySide applications
Summary: Review Request: python-pytest-qt - pytest support for PyQt and PySide applica...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-neuro, NeuroFedora 2268682
TreeView+ depends on / blocked
 
Reported: 2024-03-09 12:25 UTC by Sandro
Modified: 2024-03-30 01:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-18 11:56:18 UTC
Type: ---
Embargoed:
jamatos: fedora-review+

Attachments (Terms of Use)

Description Sandro 2024-03-09 12:25:13 UTC 
Spec URL: https://gui1ty.fedorapeople.org/review/python-pytest-qt.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-pytest-qt-4.4.0-1.fc41.src.rpm

Description: 

pytest-qt is a pytest plugin that allows programmers to write tests for
PyQt5, PyQt6, PySide2 and PySide6 applications.

The main usage is to use the qtbot fixture, responsible for handling
qApp creation as needed and provides methods to simulate user
interaction, like key presses and mouse clicks. This allows you to test
and make sure your view layer is behaving the way you expect after each
code change.

Fedora Account System Username: gui1ty

Copr build: https://copr.fedorainfracloud.org/coprs/gui1ty/Spyder6/build/7127857/
Comment 1 Fedora Review Service 2024-03-09 16:07:23 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7129671
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268677-python-pytest-qt/fedora-rawhide-x86_64/07129671-python-pytest-qt/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 José Matos 2024-03-18 10:20:03 UTC 
This review follows in the same lines of #2268679 and #2268680.

This is a simple python package.

Notice that licensechecker correctly identifies a package that has a different license:
GNU General Public License, Version 2 and/or GNU Lesser General Public License, Version 3
-----------------------------------------------------------------------------------------
pytest-qt-4.4.0/src/pytestqt/modeltest.py

The licenses are correct, with the previous exception, and are all admissible on Fedora and the package follows the Fedora package guidelines for Python packages.

Please fix the above issue on import.
Comment 3 Sandro 2024-03-18 11:38:21 UTC 
Thanks for the review! License definition has been fixed.

You seem to be forgetting to actually take the bug. If left unassigned to a user, the repo cannot be requested.
Comment 4 Fedora Admin user for bugzilla script actions 2024-03-18 11:39:38 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-qt
Comment 5 Fedora Update System 2024-03-18 11:53:41 UTC 
FEDORA-2024-0e0b994446 (python-pytest-qt-4.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0e0b994446
Comment 6 Fedora Update System 2024-03-18 11:56:18 UTC 
FEDORA-2024-0e0b994446 (python-pytest-qt-4.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 7 Fedora Update System 2024-03-26 17:17:35 UTC 
FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd
Comment 8 Fedora Update System 2024-03-27 02:35:33 UTC 
FEDORA-2024-c552c1b9fd has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c552c1b9fd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 9 Fedora Update System 2024-03-30 01:56:18 UTC 
FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.