Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2268679 - Review Request: python-cmap - Scientific colormaps for python, without dependencies
Summary: Review Request: python-cmap - Scientific colormaps for python, without depend...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-neuro, NeuroFedora 2268682
TreeView+ depends on / blocked
 
Reported: 2024-03-09 12:32 UTC by Sandro
Modified: 2024-03-30 01:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-18 11:29:24 UTC
Type: ---
Embargoed:
jamatos: fedora-review+

Attachments (Terms of Use)
The .spec file difference from Copr build 7129672 to 7129688 (deleted)
2024-03-09 16:25 UTC, Fedora Review Service 		no flags Details | Diff
View All

Description Sandro 2024-03-09 12:32:42 UTC 
Spec URL: https://gui1ty.fedorapeople.org/review/python-cmap.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-cmap-0.2.0-1.fc41.src.rpm

Description: 

Scientific colormaps for python, with no dependencies beyond numpy.

With cmap, you can use any of the colormaps from matplotlib, cmocean,
colorbrewer, crameri, seaborn, and a host of other collections in your
python code, without having to install matplotlib or any other
dependencies beyond numpy.

Fedora Account System Username: gui1ty

Copr build: https://copr.fedorainfracloud.org/coprs/gui1ty/Spyder6/build/7127859/
Comment 1 Fedora Review Service 2024-03-09 16:04:55 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7129672
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268679-python-cmap/fedora-rawhide-x86_64/07129672-python-cmap/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Sandro 2024-03-09 16:21:30 UTC 
After some discussion with upstream we came up with a different patch for the tests.

Spec URL: https://gui1ty.fedorapeople.org/review/python-cmap.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-cmap-0.2.0-2.fc41.src.rpm
Comment 3 Fedora Review Service 2024-03-09 16:25:22 UTC 
Created attachment 2020825 [details]
The .spec file difference from Copr build 7129672 to 7129688
Comment 4 Fedora Review Service 2024-03-09 16:25:24 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7129688
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2268679-python-cmap/fedora-rawhide-x86_64/07129688-python-cmap/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 5 José Matos 2024-03-18 10:10:44 UTC 
Hi Sandro,
 is there a reason to be using the development version and not the stable release?

Is that due to the test issue that you identified above.

Because that is only reason where fedora-review rightly complains:
- Sources used to build the package match the upstream source, as provided
  in the spec URL.

The difference is related with changes introduced upstream, while your original package used a previous commit.
The patch is not applied because it is already applied upstream.

Other than that this is a simple python package. The licenses are correct and admissible on Fedora and the package follows the Fedora package guidelines for Python packages.

Please fix the source issue on import.
Comment 6 Sandro 2024-03-18 10:39:03 UTC 
(In reply to José Matos from comment #5)
> Hi Sandro,
>  is there a reason to be using the development version and not the stable
> release?

I anticipated version 0.2.0 is going to be released soon since the tag was present already. Upstream confirmed that [1] in the discussion regarding my PR (#39), which evolved into PR #40, which is the patch applied.

> Is that due to the test issue that you identified above.
> 
> Because that is only reason where fedora-review rightly complains:
> - Sources used to build the package match the upstream source, as provided
>   in the spec URL.

I'm not seeing any complaint. For rawhide and F40 there's no template generated. Looking at the F38 template [2] I see:

[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.

That's a pass.

I guess you ran fedora-review after review service.

> The difference is related with changes introduced upstream, while your
> original package used a previous commit.
> The patch is not applied because it is already applied upstream.

I guess upstream may have moved the tag. Very naughty, but permissible, I suppose, since it wasn't officially released. They mentioned releasing after PR #40 was merged.
 
> Other than that this is a simple python package. The licenses are correct
> and admissible on Fedora and the package follows the Fedora package
> guidelines for Python packages.
> 
> Please fix the source issue on import.

I'll do that.

Spec URL: https://gui1ty.fedorapeople.org/review/python-cmap.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-cmap-0.2.0-3.fc41.src.rpm


[1] https://github.com/tlambert03/cmap/pull/39#discussion_r1518611308
[2] https://download.copr.fedorainfracloud.org/results/%40fedora-review/fedora-review-2268679-python-cmap/fedora-38-x86_64/07129688-python-cmap/fedora-review/review.txt
Comment 7 Fedora Admin user for bugzilla script actions 2024-03-18 11:06:17 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cmap
Comment 8 Fedora Update System 2024-03-18 11:26:20 UTC 
FEDORA-2024-c93f42c148 (python-cmap-0.2.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c93f42c148
Comment 9 Fedora Update System 2024-03-18 11:29:24 UTC 
FEDORA-2024-c93f42c148 (python-cmap-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 10 Fedora Update System 2024-03-26 17:17:38 UTC 
FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd
Comment 11 Fedora Update System 2024-03-27 02:35:35 UTC 
FEDORA-2024-c552c1b9fd has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c552c1b9fd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c552c1b9fd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Fedora Update System 2024-03-30 01:56:20 UTC 
FEDORA-2024-c552c1b9fd (python-cmap-0.2.0-1.fc40, python-pyconify-0.1.6-1.fc40, and 5 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.