Copr build:
https://copr.fedorainfracloud.org/coprs/build/7202514
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271100-rust-appdirs/fedora-rawhide-x86_64/07202514-rust-appdirs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Please link to the actual "raw" spec file, not the HTML page on GitHub that shows the spec file.

(In reply to Fabio Valentini from comment #2)
> Please link to the actual "raw" spec file, not the HTML page on GitHub that
> shows the spec file.

Done.

Spec URL: https://raw.githubusercontent.com/wojnilowicz/rust-appdirs/main/rust-appdirs.spec
SRPM URL: https://github.com/wojnilowicz/rust-appdirs/releases/download/0.2.0/rust-appdirs-0.2.0-1.fc39.src.rpm
Description: Rust crate for determining platform-specific directories
Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and appdirs is its requirement.

@decathorpe is there anything more that I should do to get this rolling?

Is there a reason why you opted out of rpmautospec for this package?

It is the default for Rust packages for years, and the preferred option for all new Fedora package since Fedora 38.
see also https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default

rpmautospec is especially useful for Rust packages, since the way they work currently requires re-generating the spec file with rust2rpm for every new upstream version - with rpmautospec this is easy, without it, it requires restoring the changelog manually.

Other than that, the package looks good to me.

(In reply to Fabio Valentini from comment #5)
> Is there a reason why you opted out of rpmautospec for this package?
> 
> It is the default for Rust packages for years, and the preferred option for
> all new Fedora package since Fedora 38.
> see also https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default
> 
> rpmautospec is especially useful for Rust packages, since the way they work
> currently requires re-generating the spec file with rust2rpm for every new
> upstream version - with rpmautospec this is easy, without it, it requires
> restoring the changelog manually.
> 
> Other than that, the package looks good to me.

No reason. I've just updated the spec file to use rpmautospec. Could you approve the package then?

Looks good to me, thank you!

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Thanks. I cannot log in to release-monitoring.org with my Fedora Account because of the 401 error. It says that I'm unauthorized. Maybe because I still haven't found my sponsor at https://pagure.io/packager-sponsors/issue/640

Could you sponsor me as well?

> I cannot log in to release-monitoring.org with my Fedora Account because of the 401 error. It says that I'm unauthorized.

I think that was due to infrastructure issues with the authentication / identity provider.

> Could you sponsor me as well?

I theoretically can, but I don't have the bandwidth for it now.

Please follow the process for becoming a packager:
https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/

(In reply to Fabio Valentini from comment #10)
> > I cannot log in to release-monitoring.org with my Fedora Account because of the 401 error. It says that I'm unauthorized.
> 
> I think that was due to infrastructure issues with the authentication /
> identity provider.

Indeed. I've set up a package there.

> > Could you sponsor me as well?
> 
> I theoretically can, but I don't have the bandwidth for it now.
> 
> Please follow the process for becoming a packager:
> https://docs.fedoraproject.org/en-US/package-maintainers/
> Joining_the_Package_Maintainers/

Understandable. I've posted an introduction to the devel mailing list. Not sure if I have more possibilities now.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-appdirs

FEDORA-2024-935a17fbb0 (rust-appdirs-0.2.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-935a17fbb0

FEDORA-2024-935a17fbb0 (rust-appdirs-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.