Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
[!]: Package does not generate any conflict.

=> Package conflicts with python3-nose.
python3-nose is already deprecated so this is probably fine.
Is this package meant to be a drop-in replacement?
I can't find the guideline for replacing a package.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/

[?]: Package provides python3dist(nose)

=> The spec file mentions this package provides nose. Does it make sense
to actually provide the python3dist provides?

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package requires other packages for directories it uses.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 17890 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-pynose-1.5.1-3.fc41.noarch.rpm
          python-pynose-1.5.1-3.fc41.src.rpm
=============================================== rpmlint session starts ===============================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpf1xl1e2q')]
checks: 32, packages: 2

python-pynose.src: W: summary-not-capitalized pynose fixes nose to extend unittest and make testing easier 🐍 👃
python3-pynose.noarch: W: summary-not-capitalized pynose fixes nose to extend unittest and make testing easier 🐍 👃
python-pynose.src: E: spelling-error ('unittest', 'Summary(en_US) unittest -> unit test, unit-test, unities')
python-pynose.src: E: spelling-error ('getargspec', '%description -l en_US getargspec -> spectacular')
python-pynose.src: E: spelling-error ('unittest', '%description -l en_US unittest -> unit test, unit-test, unities')
python-pynose.src: E: spelling-error ('addDuration', '%description -l en_US addDuration -> add Duration, add-duration, adjuration')
python-pynose.src: E: spelling-error ('importlib', '%description -l en_US importlib -> import lib, import-lib, importer')
python-pynose.src: E: spelling-error ('init', '%description -l en_US init -> unit, int, nit')
python-pynose.src: E: spelling-error ('basicConfig', '%description -l en_US basicConfig -> configuration')
python3-pynose.noarch: E: spelling-error ('unittest', 'Summary(en_US) unittest -> unit test, unit-test, unities')
python3-pynose.noarch: E: spelling-error ('getargspec', '%description -l en_US getargspec -> spectacular')
python3-pynose.noarch: E: spelling-error ('unittest', '%description -l en_US unittest -> unit test, unit-test, unities')
python3-pynose.noarch: E: spelling-error ('addDuration', '%description -l en_US addDuration -> add Duration, add-duration, adjuration')
python3-pynose.noarch: E: spelling-error ('importlib', '%description -l en_US importlib -> import lib, import-lib, importer')
python3-pynose.noarch: E: spelling-error ('init', '%description -l en_US init -> unit, int, nit')
python3-pynose.noarch: E: spelling-error ('basicConfig', '%description -l en_US basicConfig -> configuration')
python3-pynose.noarch: W: python-leftover-require python3-setuptools
python3-pynose.noarch: W: no-manual-page-for-binary nosetests-3.12
python3-pynose.noarch: W: files-duplicate /usr/bin/pynose /usr/bin/nosetests-3.12
========= 2 packages and 0 specfiles checked; 14 errors, 5 warnings, 7 filtered, 14 badness; has taken 0.8 s =========




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-pynose.noarch: W: summary-not-capitalized pynose fixes nose to extend unittest and make testing easier 🐍 👃
python3-pynose.noarch: E: spelling-error ('unittest', 'Summary(en_US) unittest -> unit test, unit-test, unities')
python3-pynose.noarch: E: spelling-error ('getargspec', '%description -l en_US getargspec -> spectacular')
python3-pynose.noarch: E: spelling-error ('unittest', '%description -l en_US unittest -> unit test, unit-test, unities')
python3-pynose.noarch: E: spelling-error ('addDuration', '%description -l en_US addDuration -> add Duration, add-duration, adjuration')
python3-pynose.noarch: E: spelling-error ('importlib', '%description -l en_US importlib -> import lib, import-lib, importer')
python3-pynose.noarch: E: spelling-error ('init', '%description -l en_US init -> unit, int, nit')
python3-pynose.noarch: E: spelling-error ('basicConfig', '%description -l en_US basicConfig -> configuration')
python3-pynose.noarch: W: python-leftover-require python3-setuptools
python3-pynose.noarch: W: no-manual-page-for-binary nosetests-3.12
python3-pynose.noarch: W: files-duplicate /usr/bin/pynose /usr/bin/nosetests-3.12
 1 packages and 0 specfiles checked; 7 errors, 4 warnings, 3 filtered, 7 badness; has taken 0.3 s 



Source checksums
----------------
https://github.com/mdmintz/pynose/archive/v1.5.1/pynose-1.5.1.tar.gz :
  CHECKSUM(SHA256) this package     : 7a54f4dc65c3fe99c0fe7641a92839f5d2e4f52924efd933be39b1d4f27df425
  CHECKSUM(SHA256) upstream package : 7a54f4dc65c3fe99c0fe7641a92839f5d2e4f52924efd933be39b1d4f27df425


Requires
--------
python3-pynose (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3-setuptools



Provides
--------
python3-pynose:
    python-pynose
    python3-pynose
    python3.12-pynose
    python3.12dist(pynose)
    python3dist(pynose)



Diff spec file in url and in SRPM
---------------------------------
--- /var/home/kanru/r/rpms/Review/2274514-python-pynose/srpm/python-pynose.spec	2024-04-24 23:53:33.077044028 +0900
+++ /var/home/kanru/r/rpms/Review/2274514-python-pynose/srpm-unpacked/python-pynose.spec	2024-04-11 09:00:00.000000000 +0900
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.6.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 3;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global pypi_name pynose
 %global forgeurl https://github.com/mdmintz/pynose
@@ -97,3 +107,12 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Thu Apr 11 2024 Sandro <devel> - 1.5.1-3
+- Add Conflicts: and Requires:
+
+* Tue Apr 09 2024 Sandro <devel> - 1.5.1-2
+- Add compatability binaries and man pages
+
+* Tue Apr 09 2024 Sandro <devel> - 1.5.1-1
+- Initial package
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2274514
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, PHP, C/C++, Perl, R, SugarActivity, fonts, Haskell, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

(In reply to Kan-Ru Chen from comment #1)
> Issues:
> =======
> [!]: Package does not generate any conflict.
> 
> => Package conflicts with python3-nose.
> python3-nose is already deprecated so this is probably fine.
> Is this package meant to be a drop-in replacement?
> I can't find the guideline for replacing a package.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/

Yes, pynose is essentially a drop-in replacement for deprecated nose. I believe it has been forked from nose. Hence, the spec file has 'Conflicts: python3-nose'.


> [?]: Package provides python3dist(nose)
> 
> => The spec file mentions this package provides nose. Does it make sense
> to actually provide the python3dist provides?

In my opinion it absolutely makes sense. I already tested with pynose properly providing nose in RPM as well as in Python metadata. I'm pondering submitting a change proposal to that effect. The Python SIG suggested submitting the package as is and leaving the changes with regards to properly replacing nose for later.

The discussion took place on the ML: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/VJYI34Y4GTPX4BMP3HOCENS525SUK7KM/

Thanks for the discussion link. I agree replacing nose completely can be handled later.
I think all the questions in the mail thread were also already addressed, therefore this package is good to go.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pynose

Forgot to mention this bug when importing.

https://bodhi.fedoraproject.org/updates/FEDORA-2024-dd9f2153a2