APPROVED

MD5SUMS:
98971ee00adfe5c0f2d1e730066ba9c0  perl-IO-Compress-Base-2.003-1.src.rpm

7927ee59cc3c16609397be1d7d32ba01  IO-Compress-Base-2.003.tar.gz
0f5fd8ee458daa4792f509d2dce2ea53  perl-IO-Compress-Base.spec

Sources:
* IO-Compress-Base-2.003.tar.gz: MD5 digest verified against CPAN tarball
(<cpan>/authors/id/P/PM/PMQS/IO-Compress-Base-2.003.tar.gz)

Good:
* Package name follows standard
* URL and Source0 urls are valid
* License verified (README file and main POD page)
* perl(:MODULE_COMPAT_xxx) present
* perl vendor libs present
* File permissions are sane
* No active tickets in
  http://rt.cpan.org/Public/Dist/Display.html?Name=IO-Compress-Base


Notes/Suggestions:

* %files section
  replace
    %{perl_vendorlib}/*
  by
    P%{perl_vendorlib}/File/
    %{perl_vendorlib}/IO/
  and (maybe)
    %{_mandir}/man3/*
  by
    %{_mandir}/man3/*.3pm*

* build requirements
  add the following comments
    #BuildRequires:  perl(Test::Pod)
    #BuildRequires:  perl(Test::NoWarnings)

  Both these modules are available in Extras, but I still
  don't know when the building system will be able to pull
  Extras packages.

* Warning: IO::Compress::Base will be a perl 5.10 core module.

Silly question, perhaps:  is there a reason this bug's "product" is core, not
extras?

(In reply to comment #2)
> Silly question, perhaps:  is there a reason this bug's "product" is core, not
> extras?

The update of the core package perl-Compress-Zlib from version 1.42 to version
2.00x will require several new modules (perl-IO-Compress-Base being one of them).

jpo

I'm going to need this for IO::Compress::Bzip2, which is required by the next 
version of cpanspec.

Unfortunately, the version I submitted as bug 232703 requires 
IO::Compress::Base >= 2.004.  Would you mind bumping the version of this?

Oh, and if the IO::Compress::Base package I submitted in bug 232678 is any 
help, please use it.  (Apparently I missed this when I was searching for 
duplicates because it is a Core review, not an Extras review.)

ok, I've bumped the version to 2.004, incorporated the changes from comment #1,
and stole some of Steven's %description text from bug #232678

See:

http://people.redhat.com/rnorwood/rpms/perl-IO-Compress-Base-2.004-1.src.rpm
and:
http://people.redhat.com/rnorwood/rpms/perl-IO-Compress-Base.spec

How's that?

Missing: BuildRequires: perl(ExtUtils::MakeMaker)

Finally revisiting this - Added the missing BuildRequires pointed out by Ralf:

http://people.redhat.com/rnorwood/rpms/perl-IO-Compress-Base-2.004-1.src.rpm
http://people.redhat.com/rnorwood/rpms/perl-IO-Compress-Base.spec

Putting the review flag back to '?' for jpo to re-approve with this change.

There are 5 compression-related packages needed for a new Compress::Zlib
(2.004), including this one.  Here are the bugzilla URLs for them:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228537 - perl-IO-Compress-Base
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243010 -
perl-Compress-Raw-Bzip2
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243012 - perl-Compress-Raw-Zlib
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243016 - perl-IO-Compress-Bzip2
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243019 - perl-IO-Compress-Zlib

Here are some that have uncommented the Test:: BuildRequires mentioned in
comment #1 :

http://people.redhat.com/rnorwood/rpms/Compression/perl-IO-Compress-Base-2.004-1.src.rpm
http://people.redhat.com/rnorwood/rpms/Compression/perl-IO-Compress-Base.spec

Hmm, this is holding up other packages.  Since jpo has already approved this,
I'll give it a quick once over.
...
Builds fine in rawhide.  The build dependencies seem OK to me; the tests are all
run save for just one which doesn't seem related to missing build dependencies:
  t/000prereq.....ok
  t/01misc........ok
        1/79 skipped: readonly + threads
  t/99pod.........ok
  t/globmapper....ok
  All tests successful, 1 subtest skipped.
  Files=4, Tests=155,  0 wallclock secs ( 0.26 cusr +  0.06 csys =  0.32 CPU)

So I think everything's fine here, and I'll go ahead and set fedora-review back
to '+'.

New Package CVS Request
=======================
Package Name: perl-IO-Compress-Base
Short Description: Base package for new perl-IO-Compress modules
Owners: rnorwood
Branches: devel
InitialCC: fedora-perl-devel-list

cvs done.

And built for devel/f8