Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 431335 - Review Request: decibel-audio-player - Music player for GNOME
Summary: Review Request: decibel-audio-player - Music player for GNOME
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2008-02-02 23:59 UTC by Debarshi Ray
Modified: 2008-05-25 18:59 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-05-25 18:59:32 UTC
Type: ---
jpmahowald: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Debarshi Ray 2008-02-02 23:59:32 UTC
Spec URL:


Decibel is an audio player that aims at being very straightforward to use by
means of a very clean and user friendly interface. It is especially targeted
at GNOME and will follow, as closely as possible, the GNOME HIG. It makes use
of the GStreamer library to read audio files.

Comment 1 John Mahowald 2008-02-13 20:36:02 UTC
Does build and play on development.

However, it must install to %{python_sitelib}  as per  
At the moment it's /usr/share/decibel-audio-player

Speaking of decibel-audio-player, why patch the .desktop to be Decibel Music
Player? Every other reference, from the package name to the about box is Decibel
Audio Player. I request it be Audio Player in the .desktop.

Why not use the default BuildRoot of 
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ?

Source matches
License of GPLv2+  matches source headers

Comment 2 Debarshi Ray 2008-02-19 17:38:06 UTC
(In reply to comment #1)

> However, it must install to %{python_sitelib}  as per
> At the moment it's /usr/share/decibel-audio-player
Those Python files are only meant to be used by Decibel, and not any other
program. Only system-wide files (or modules) should go in %{python_sitelib},
isn't it?

> Speaking of decibel-audio-player, why patch the .desktop to be Decibel Music
> Player?

To ensure consistency in the desktop menus. We have "Banshee Music Player",
"Exaile Music Player", etc.. So the trend seems to be "<name> Music Player" for
such applications.

What do you suggest?

> Why not use the default BuildRoot of 
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ?

That used to be the default BuildRoot. Not anymore. See:

Comment 3 Debarshi Ray 2008-04-25 02:09:11 UTC
This review is stalled. If there is no response from John Mahowald within a
week, I will remove the FE-REVIEW blocker and replace it with FE-NEW.

Comment 4 John Mahowald 2008-05-21 03:08:23 UTC
Good point regarding python files. They are arch independent so leave them in

I'll leave it to you to decide Music or Audio player, Music is fine. Both work
fine in English. The key word users will see is Decibel anyways.

Nice citation of the guidelines, that BuildRoot does meet the requirements.


+ Still builds in development
+ Works
+ rpmlint is clean
+ Includes byte compiled files
+ License matches, GPLv2+
+ Proper Requires and BuildRequires
+ Installed .desktop file, appears under "Sound and Video"
+ Proper use of macros


Comment 5 Debarshi Ray 2008-05-21 04:32:03 UTC
New Package CVS Request
Package Name: decibel-audio-player
Short Description: Music player for GNOME
Owners: rishi
Branches: F-7 F-8 F-9
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-05-21 18:29:21 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.