expect a review in few hrs

[x] Build
http://koji.fedoraproject.org/koji/taskinfo?taskID=765906
[x] rpmlint -- clean
[x] package naming
[x] packaging guidlines
[x] md5sum
     srpm source: 6fad0a69ac89440ad4f696dbbbf11497
     source: 6fad0a69ac89440ad4f696dbbbf11497
[!] license -- waiting for confirmation from upstream
[x] spec file in us-en and legible
[x] license text file
[x] Buildrequire
[x] permissions
[x] pkg owns directories created 
[x] %clean and %install contain rm -rf %{buildroot}
[x] translation file handled

Optional:
[!] why using debug option

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

Upstream confirmed it is just GPLv2. I have fixed the license tag and disabled the debugging option.

http://sundaram.fedorapeople.org/packages/ms-sys.spec
http://sundaram.fedorapeople.org/packages/ms-sys-2.1.3-2.fc10.src.rpm

[rpmbuild@rocky ~]$ rpmls  ms-sys-2.1.3-2.fc10.src.rpm 
-rwxr-xr-x  ms-sys-2.1.3.tgz
-rwxr-xr-x  ms-sys.spec

It should be 664

Rest things are okay.

Fixed

APPROVED

New Package CVS Request
=======================
Package Name:  ms-sys 
Short Description: Create DOS/MS-compatible boot records
Owners: sundaram
Branches: F-8 F-9 EL-4 EL-5
InitialCC: 
Cvsextras Commits: yes

cvs done.

ping when you importing this ?

ms-sys-2.1.3-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/ms-sys-2.1.3-2.fc9

ms-sys-2.1.3-2.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/ms-sys-2.1.3-2.fc8

Closing this as it is already imported.
If some problem persists will be reopened.

Thanks

ms-sys-2.1.3-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

ms-sys-2.1.3-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

This package contains verbatim copies of various MBRs and boot records stuffed into arrays in the supposedly GPLed source code. Is that legally acceptable?

Are there any progress in clarifying legal status of this package? May be need to ask at fedora-legal list?

I can't see anything that gives us permission to distribute or copy (or modify) these MBRs and boot records. This never should have been permitted into Fedora. I'm going to EOL it and block it from rawhide.

(In reply to comment #17)
> I can't see anything that gives us permission to distribute or copy (or modify)
> these MBRs and boot records. This never should have been permitted into Fedora.
> I'm going to EOL it and block it from rawhide.  

We can probably use a modified source tarball that would only contain free boot code (e.g. the MBR code from NetBSD or from FreeDOS). I have no idea how useful would the package be then though.

May I suggest ms-sys-free ...

"This is a fork of the ms-sys project by Henrik Carlqvist, removing proprietary boot code from the program, leaving only free ones. There is no need to use this version unless you are concerned about the copyright status of the embedded boot code."

http://sourceforge.net/projects/ms-sys-free/

This is useful such as to create a Windows install USB stick from an iso file. Works great.

That would be great, but it needs someone to package it and submit a new review request.

Actually, is ms-sys-free really Free (or even legally redistributable)? I'm not convinced, seeing how e.g.:
http://sourceforge.net/p/ms-sys-free/code/ci/master/tree/inc/br_fat32fd_0x52.h
says:
> /* br_fat32_0x52.h
> //
> // ANI
> // substring gmbh/tw 14.9.04 
> // modified bootstrap code 0x052 to support FreeDOS
so it looks like this doesn't actually come from the FreeDOS project, but is a derivative work of the proprietary hexdump.