Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 495362 - [PATCH] Improve error reporting a bit
Summary: [PATCH] Improve error reporting a bit
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: file-roller
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F11Target
TreeView+ depends on / blocked
 
Reported: 2009-04-12 10:41 UTC by Lubomir Rintel
Modified: 2009-04-13 00:26 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-13 00:26:28 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Don't show a null error message (deleted)
2009-04-12 10:41 UTC, Lubomir Rintel 		no flags Details
View All

Description Lubomir Rintel 2009-04-12 10:41:07 UTC 
Created attachment 339228 [details]
Don't show a null error message

Description of problem:

Got a following error message:

An error occurred while loading the archive.
(null)

Though it was rather clear from the command output that the archive is corrupted, a casual user would not appreciate seeing "(null)" in an error message.

Please apply the patch that instructs the user to inspect the command output to find out the cause of the fail.

Version-Release number of selected component (if applicable):

file-roller-2.26.0-1.fc11.i586
Comment 1 Matthias Clasen 2009-04-12 22:27:37 UTC 
Thats a fine patch to send upstream. 
But since it adds new translated strings, it will give a less than perfect experience - I'd say that it is only marginally better for a Chinese user to see some English sentence instead of "null". 

How about this instead ?

--- fr-window.c.error-msg	2009-04-12 18:25:09.421337520 -0400
+++ fr-window.c	2009-04-12 18:26:45.327336763 -0400
@@ -2961,7 +2961,7 @@
 						0,
 						output,
 						msg,
-						"%s", details);
+						details ? "%s" : NULL, details);
 		fr_window_show_error_dialog (window, dialog, dialog_parent);
 
 		return FALSE;
Comment 2 Lubomir Rintel 2009-04-12 23:05:01 UTC 
(In reply to comment #1)
> Thats a fine patch to send upstream. 
> But since it adds new translated strings, it will give a less than perfect
> experience - I'd say that it is only marginally better for a Chinese user to
> see some English sentence instead of "null". 

Well, it will propagate into .po files and probably get translated once. Sorry for not providing a Chinese translation ;)

> How about this instead ?
[...]

Thought about that. Doesn't look well in that dialog, there's an empty space there.
Comment 3 Matthias Clasen 2009-04-13 00:26:28 UTC 
Filed upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=578800
Note You need to log in before you can comment on or make changes to this bug.