498189 – Review Request: perl-JavaScript-Minifier-XS - XS based JavaScript minifier

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 498189 - Review Request: perl-JavaScript-Minifier-XS - XS based JavaScript minifier

Summary: Review Request: perl-JavaScript-Minifier-XS - XS based JavaScript minifier

Keywords:
Status:	CLOSED RAWHIDE
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	low
Severity:	medium
Target Milestone:	---
Assignee:	Chris Weyl
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:	498188
Blocks:	500959
TreeView+	depends on / blocked

Reported:	2009-04-29 11:55 UTC by Marcela Mašláňová
Modified:	2009-06-04 06:58 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2009-06-04 06:58:42 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	cweyl: fedora-review+ j: fedora-cvs+

Attachments	(Terms of Use)

Description Marcela Mašláňová 2009-04-29 11:55:31 UTC

Spec URL: http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier-XS.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier-XS-0.05-1.fc11.src.rpm
Description:
JavaScript::Minifier::XS is a JavaScript "minifier"; its designed to remove
un-necessary whitespace and comments from JavaScript files, which also not
breaking the JavaScript.

Comment 1 Chris Weyl 2009-05-03 18:30:13 UTC

Let me know when perl-JavaScript-Minifier is in rawhide :)

Comment 2 Chris Weyl 2009-05-04 15:15:15 UTC

Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1335368

Comment 3 Chris Weyl 2009-05-04 15:38:37 UTC

We need a br on Test::Pod; and the third word from the end of the second line
of %description should probably be "without", not "which" :)

The XS.so in the requires should be filtered, as it's a privat plugin library
for Perl that isn't in the system lib paths.  A construct like the following,
inserted before %description, will do the trick.  (see, e.g.
perl-CSS-Minifier-XS)

# don't "provide" private Perl libs
%global _use_internal_dependency_generator 0
%global __deploop() while read FILE; do /usr/lib/rpm/rpmdeps -%{1} ${FILE}; done | /bin/sort -u
%global __find_provides /bin/sh -c "%{__grep} -v '%{perl_vendorarch}/.*\\.so$' | %{__deploop P}"
%global __find_requires /bin/sh -c "%{__deploop R}"

Please add the BR and *.so filtering.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1335368

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz
2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz.srpm

Final provides / requires will be sane, once XS.so has been removed from the
provides:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm
perl(JavaScript::Minifier::XS) = 0.05
perl-JavaScript-Minifier-XS = 0.05-1.fc12
perl-JavaScript-Minifier-XS(ppc-32) = 0.05-1.fc12
XS.so  
====> requires for perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm
libc.so.6  
libc.so.6(GLIBC_2.0)  
libc.so.6(GLIBC_2.1.3)  
libc.so.6(GLIBC_2.3)  
perl >= 0:5.006
perl(DynaLoader)  
perl(Exporter)  
perl(:MODULE_COMPAT_5.10.0)  
perl(strict)  
perl(warnings)  
rtld(GNU_HASH)  

=====> perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm
====> requires for perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm
perl(JavaScript::Minifier)  
perl(Module::Build)  
perl(Test::More)  

=====> perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm <=====
====> rpmlint
perl-JavaScript-Minifier-XS-debuginfo.ppc: E: description-line-too-long This package provides debug information for package perl-JavaScript-Minifier-XS.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm
perl-JavaScript-Minifier-XS-debuginfo = 0.05-1.fc12
perl-JavaScript-Minifier-XS-debuginfo(ppc-32) = 0.05-1.fc12
====> requires for perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm

Comment 4 Marcela Mašláňová 2009-05-05 07:41:54 UTC

There's still rpmlint message 
perl-JavaScript-Minifier-XS.x86_64: W: unstripped-binary-or-object /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/JavaScript/Minifier/XS/XS.so
Could it be removed, or could I ignore it?

http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier-XS-0.05-2.fc11.src.rpm

Comment 5 Marcela Mašláňová 2009-05-28 10:34:09 UTC

ping?

Comment 6 Chris Weyl 2009-06-03 03:28:57 UTC

Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1390386

Comment 7 Chris Weyl 2009-06-03 03:36:08 UTC

Hmm, interesting.  I'm not seeing the "unstripped" warning you described; and
I'm not worried about the "description too long" in the debuginfo package...
not much we could do about that anyways. :)

With apologies for the extremely long delay.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1390386

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz
2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm
perl(JavaScript::Minifier::XS) = 0.05
perl-JavaScript-Minifier-XS = 0.05-2.fc12
perl-JavaScript-Minifier-XS(ppc-32) = 0.05-2.fc12
====> requires for perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm
libc.so.6  
libc.so.6(GLIBC_2.0)  
libc.so.6(GLIBC_2.1.3)  
libc.so.6(GLIBC_2.3)  
perl >= 0:5.006
perl(DynaLoader)  
perl(Exporter)  
perl(:MODULE_COMPAT_5.10.0)  
perl(strict)  
perl(warnings)  
rtld(GNU_HASH)  

=====> perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm
====> requires for perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm
perl(JavaScript::Minifier)  
perl(Module::Build)  
perl(Test::More)  
perl(Test::Pod)  

=====> perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm <=====
====> rpmlint
perl-JavaScript-Minifier-XS-debuginfo.ppc: E: description-line-too-long This package provides debug information for package perl-JavaScript-Minifier-XS.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm
perl-JavaScript-Minifier-XS-debuginfo = 0.05-2.fc12
perl-JavaScript-Minifier-XS-debuginfo(ppc-32) = 0.05-2.fc12
====> requires for perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm

APPROVED

Comment 8 Marcela Mašláňová 2009-06-03 10:32:47 UTC

New Package CVS Request
=======================
Package Name: perl-JavaScript-Minifier-XS
Short Description: XS based JavaScript minifier
Owners: mmaslano
Branches: F-11
InitialCC: perl-sig

Comment 9 Jason Tibbitts 2009-06-03 16:52:20 UTC

CVS done.

Note You need to log in before you can comment on or make changes to this bug.