Fedora review mingw32-libssh2-1.1-1.fc11.src.rpm 2009-05-22

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1370201

rpmlint output:
$ rpmlint mingw32-libssh2*
mingw32-libssh2-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libssh2.a
mingw32-libssh2-static.noarch: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 1 warnings.

As per Packaging/MinGW, these errors can be ignored.

+ OK
! needs attention


+ rpmlint output
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
  version seems to be slightly ahead of native (1.1 vs. 1.0) please try to
  stick to the native version
+ License meets guidelines and is acceptable to Fedora
  BSD
+ License matches the actual package license
  It is also the same as in the corresponding Fedora libssh2 package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
f8a3eb9bb814e0a5a2bb76a5423f5129  libssh2-1.1.tar.gz
f8a3eb9bb814e0a5a2bb76a5423f5129  x/libssh2-1.1.tar.gz

n/a Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
    Fedora MinGW guidelines allow headers in main package
+ Static libraries should be in -static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
    Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
! use %global instead of %define

(In reply to comment #1)
> + Package follows the Fedora MinGW packaging guidelines
>   version seems to be slightly ahead of native (1.1 vs. 1.0) please try to
>   stick to the native version

Yeah I know, but there was a message on the fedora-mingw mailing list recently that we were advised to upgrade to version 1.1 as it contains several win32 optimalisations: http://lists.fedoraproject.org/pipermail/fedora-mingw/2009-May/001355.html

> ! use %global instead of %define  

A lot of MinGW packages we have use these %define's. I think we should check every MinGW package which is in Fedora now and fix the packages if necessary.

For this package I've replaced the %define's with %global's:

Spec URL: http://www.ftd4linux.nl/contrib/mingw32-libssh2.spec
SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-libssh2-1.1-2.fc11.src.rpm

APPROVED by sailer

New Package CVS Request
=======================
Package Name: mingw32-libssh2
Short Description: MinGW Windows library implementation of the SSH2 protocol
Owners: epienbro rjones
Branches: F-10 F-11
InitialCC:

cvs done.

mingw32-libssh2-1.1-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/mingw32-libssh2-1.1-2.fc11

mingw32-libssh2-1.1-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-libssh2-1.1-2.fc10

mingw32-libssh2-1.1-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

mingw32-libssh2-1.1-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.