Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 502537 (vrrpd) - Review Request: vrrpd - Virtual Router Redundancy Protocol (Daemon only)
Summary: Review Request: vrrpd - Virtual Router Redundancy Protocol (Daemon only)
Keywords:
Status: CLOSED WONTFIX
Alias: vrrpd
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: http://www.imagestream.com/VRRP.html
Whiteboard:
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
 
Reported: 2009-05-25 23:33 UTC by Wilmer Jaramillo M.
Modified: 2010-02-07 14:18 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-07 14:18:32 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Wilmer Jaramillo M. 2009-05-25 23:33:39 UTC 
Spec URL: http://wilmer.fedorapeople.org/files/review/vrrpd/vrrpd.spec
SRPM URL: http://wilmer.fedorapeople.org/files/review/vrrpd/vrrpd-1.0-1.fc10.src.rpm

Description: VRRPd is an implementation of Virtual Router Redundancy Protocol as  specified  in rfc2338.  VRRPd  is  interoperable with  other RFC-based VRRP implementations, including Cisco and Juniper, and is included as a standard feature on ImageStream routers.
Comment 1 Itamar Reis Peixoto 2009-05-25 23:46:35 UTC 
please fix

1 - BuildRoot  

-> https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot

2- BuildRequires
-> every fedora linux have kernel installed by default, doesn't  need kernel in build requires, you need only kernel-devel.

3- install section

please simplify things using install -Dp -m so you reduce the size of your spec file.

:-)
Comment 2 Itamar Reis Peixoto 2009-05-25 23:49:25 UTC 
after you fix these things, please post here the new spec file and a koji scratch build, this will speed up the review process.
Comment 3 Wilmer Jaramillo M. 2009-05-26 01:07:03 UTC 
Excelent recomendations Itamar, new uploads:
Spec URL: http://wilmer.fedorapeople.org/files/review/vrrpd/vrrpd.spec
SRPM URL:
http://wilmer.fedorapeople.org/files/review/vrrpd/vrrpd-1.0-1.fc10.src.rpm
Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1376564
Comment 4 Fabian Deutsch 2009-07-28 15:22:00 UTC 
AFAIK Cisco is holding some patents on VRRP, so can this be part of Fedora anyway?
CARP is a patent free solution.
Comment 5 Jason Tibbitts 2009-08-01 19:21:41 UTC 
If you have legal questions you should make the ticket block FE-Legal so that the folks who understand such things can take a look.  I'll do that now.
Comment 6 Fabian Deutsch 2010-02-07 14:18:32 UTC 
Closing

More about thos patents: http://en.wikipedia.org/wiki/Virtual_Router_Redundancy_Protocol
Note You need to log in before you can comment on or make changes to this bug.