Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 521063 - Extra parameters required for GetDevices
Summary: Extra parameters required for GetDevices
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-printer
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F12Target
TreeView+ depends on / blocked
 
Reported: 2009-09-03 12:21 UTC by Tim Waugh
Modified: 2009-09-03 16:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-03 16:35:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Tim Waugh 2009-09-03 12:21:57 UTC
Description of problem:
Unfortunately while working on this issue:
  https://fedorahosted.org/system-config-printer/ticket/14

I have realised that we don't get to pass through some optional parameters when using PolicyKit.

The available optional parameters for CUPS-Get-Devices are:

1. limit, an integer, specifying the maximum number of devices to return
2. include-schemes, a list of strings specifying the inclusion list for returned device URI schemes
3. exclude-schemes, a list of strings specifying the exclusion list for returned device URI schemes

The include-schemes and exclude-schemes parameters are mutually exclusive.

There are currently no others.

Version-Release number of selected component (if applicable):
cups-pk-helper-0.0.4-7.fc12.x86_64

Additional info:
I don't think it's possible to have optional parameters with D-Bus so we need some way to signal whether the parameters should be used or not -- perhaps just '0' for no limit and empty list for the other two.  In other words, include-schemes would only be used if non-empty, otherwise exclude-schemes.

This is an API break so will need either a new interface name (can we do that?) or new policy mechanism method name.

Comment 1 Tim Waugh 2009-09-03 12:23:41 UTC
...and of course I'm wrong, the D-Bus API supports this already (yay!), just that system-config-printer's cupspk doesn't yet.

Comment 2 Tim Waugh 2009-09-03 16:35:43 UTC
Fixed upstream.


Note You need to log in before you can comment on or make changes to this bug.