Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 521979 - New Package for Dogtag PKI: tomcatjss
Summary: New Package for Dogtag PKI: tomcatjss
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 520719
Blocks: Dogtag-to-Fedora
TreeView+ depends on / blocked
 
Reported: 2009-09-08 22:43 UTC by Kevin Wright
Modified: 2015-07-13 04:56 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 520719
Environment:
Last Closed: 2010-02-04 04:57:58 UTC
Type: ---
Embargoed:
dennis: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Kevin Wright 2009-09-08 22:43:15 UTC 
+++ This bug was initially created as a clone of Bug #520719 +++

Created an attachment (id=359453)
tomcatjss.spec

First pass at tomcatjss package.

--- Additional comment from mharmsen on 2009-09-01 19:04:40 EDT ---

Created an attachment (id=359454)
tomcatjss SRPM

--- Additional comment from dennis on 2009-09-01 19:28:11 EDT ---

for future reference please dont post spec files and srpm as attachments to bugs.

--- Additional comment from dennis on 2009-09-01 19:50:38 EDT ---

rpm link gives some warnings

rpmlint /var/lib/mock/fedora-rawhide-x86_64/result
tomcatjss.src: W: strange-permission tomcatjss.spec 0600
tomcatjss.noarch: W: spurious-executable-perm /usr/share/doc/tomcatjss-1.2.0/README
tomcatjss.noarch: W: spurious-executable-perm /usr/share/doc/tomcatjss-1.2.0/LICENSE

we should make sure the docs are not executable
source is not available for download at the url in the spec

fedora 8 has not been supported for some time now 
# Override the default 'pki_jdk' and 'pki_jre' on Fedora 8 platforms
%{?fc8:%define pki_jdk    java-devel >= 1.7.0}
%{?fc8:%define pki_jre    java >= 1.7.0}
should be removed along with the pki_jdk and pki_jre macros 

/var/lib/tomcat5/server/lib/tomcatjss.jar in %files should be 
%{_sharedstatedir}/tomcat5/server/lib/tomcatjss.jar

mkdir -p %{buildroot}/var/lib/tomcat5/server/lib
cd %{buildroot}/var/lib/tomcat5/server/lib

should be 
mkdir -p %{buildroot}%{_sharedstatedir}/tomcat5/server/lib
cd %{buildroot}%{_sharedstatedir}/tomcat5/server/lib
Comment 1 Kevin Wright 2009-09-09 16:49:02 UTC 
The source tarball can be found here: http://pki.fedoraproject.org/pki/sources/tomcatjss/

The src.rpm can be found here:

http://people.redhat.com/kwright/tomcatjss/tomcatjss-1.2.0-1.fc11.src.rpm

The spec file:

http://people.redhat.com/kwright/tomcatjss/tomcatjss.spec
Comment 2 Kevin Wright 2009-09-11 22:17:04 UTC 
The spec file has been updated to fix the issues noted above. Both the spec file and src.rpm file have been updated and posted to the location above.
Comment 3 Kevin Wright 2009-09-11 23:19:21 UTC 
Added an entry to the changelog and posted the updated spec file and src rpm:

http://people.redhat.com/kwright/tomcatjss/tomcatjss.spec
http://people.redhat.com/kwright/tomcatjss/tomcatjss-1.2.0-2.fc11.src.rpm
Comment 4 Dennis Gilmore 2009-09-12 01:50:48 UTC 
sha256sum tomcatjss-1.2.0.tar.gz fedora/SOURCES/tomcatjss-1.2.0.tar.gz
c327f6efa2c2e36a8515d2420de7dc3307ce145574eaa28282ddfddc3ca2fd51  tomcatjss-1.2.0.tar.gz
c327f6efa2c2e36a8515d2420de7dc3307ce145574eaa28282ddfddc3ca2fd51  fedora/SOURCES/tomcatjss-1.2.0.tar.gz

source matches upstream

builds fine in mock and koji 
scratch builds
http://koji.fedoraproject.org/koji/taskinfo?taskID=1672226
http://koji.fedoraproject.org/koji/taskinfo?taskID=1672206

rpmlint is quiet

license is fine
spec is clear

approved
Comment 5 Kevin Wright 2009-09-14 18:50:28 UTC 
Also, this is my first package, and I am seeking a sponsor.
Comment 6 Kevin Wright 2009-09-14 23:42:50 UTC 
Please disregard comment #5
Comment 7 Kevin Wright 2009-09-14 23:43:18 UTC 
New Package CVS Request
=======================
Package Name: tomcatjss
Short Description:  A Java Secure Socket Extension (JSSE) implementation using
Java Security Services (JSS) for Tomcat 5.5.
Owners: kwright, mharmsen
Branches: F-10 F-11
InitialCC: dg
Comment 8 Kevin Wright 2009-09-15 00:57:28 UTC 
change owners to:
Owners: kwright
Comment 9 Dennis Gilmore 2009-09-15 01:23:25 UTC 
CVS done
Comment 10 Kevin Wright 2009-09-15 05:38:13 UTC 
koji build:

http://koji.fedoraproject.org/koji/buildinfo?buildID=132026
Comment 11 Kevin Wright 2010-01-07 19:40:41 UTC 
New Package CVS Request
=======================
Package Name: tomcatjss
Short Description:  A Java Secure Socket Extension (JSSE) implementation using
Java Security Services (JSS) for Tomcat 5.5.
Owners: kwright
Branches: F-10 F-11, EL-5
InitialCC: ausil
Comment 12 Fedora Update System 2010-01-08 19:56:05 UTC 
tomcatjss-1.2.0-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tomcatjss'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0321
Comment 13 Kevin Fenzi 2010-01-09 04:41:06 UTC 
(In reply to comment #11)
> New Package CVS Request
> =======================
> Package Name: tomcatjss
> Short Description:  A Java Secure Socket Extension (JSSE) implementation using
> Java Security Services (JSS) for Tomcat 5.5.
> Owners: kwright
> Branches: F-10 F-11, EL-5
> InitialCC: ausil    

Are you just wanting a EL-5 branch added here? 
We no longer do F-10 branches, and F-11 seems to already exist. 
Can you clarify?
Comment 14 Kevin Wright 2010-01-09 04:43:42 UTC 
Kevin, Sorry. I actually need F-12 and EL-5 branches created.

Branches: F-11 F-12, EL-5
Comment 15 Kevin Fenzi 2010-01-09 04:48:48 UTC 
There already is a F-12 branch (make sure you do 'cvs update -d'). 

Added a EL-5 branch.
Comment 16 Kevin Wright 2010-01-09 04:53:54 UTC 
right. will do, thanks!
Comment 17 Fedora Update System 2010-01-12 23:56:03 UTC 
tomcatjss-1.2.0-2.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tomcatjss'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0050
Note You need to log in before you can comment on or make changes to this bug.