Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 538296 - Review Request: openvas-libnasl - Support for NASL scripting language in OpenVAS Server
Summary: Review Request: openvas-libnasl - Support for NASL scripting language in Open...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 538035
Blocks: 538297 538298
TreeView+ depends on / blocked
 
Reported: 2009-11-18 07:26 UTC by Stjepan Gros
Modified: 2009-12-22 10:50 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-22 10:50:41 UTC
Type: ---
Embargoed:
panemade: fedora-review+
a.badger: fedora-cvs+

Attachments (Terms of Use)

Description Stjepan Gros 2009-11-18 07:26:11 UTC 
Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas/openvas-libnasl.spec
SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas/openvas-libnasl-2.0.2-1.fc11.src.rpm
Description:
Libraries module for the Open Vulnerability Assessment System
(OpenVAS) containing support for the NASL scripting languague.
Comment 1 Huzaifa S. Sidhpurwala 2009-12-03 08:01:43 UTC 
Hi,
I am going to the co-maintainer for the openvas stack

koji devel build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1845347

SPEC: http://huzaifas.fedorapeople.org/spec/openvas-libnasl.spec
SRPM: http://huzaifas.fedorapeople.org/srpms/openvas-libnasl-2.0.2-2.fc10.src.rpm
Comment 2 Parag AN(पराग) 2009-12-09 10:26:46 UTC 
I think sources are not matching.
e743a69c9a28abe374e9827eddd3370d5cfae055  openvas-libnasl-2.0.2.tar.gz
7a4342418de2a591353a4404455ca97a49d589d8  ../SOURCES/openvas-libnasl-2.0.2.tar.gz
Comment 3 Stjepan Gros 2009-12-10 15:04:39 UTC 
Please, double check it. I just downloaded source from the OpenVAS site and the checksum matches:

# sha1sum openvas-libnasl-2.0.2.tar.gz /usr/src/redhat/SOURCES/openvas-libnasl-2.0.2.tar.gz 
7a4342418de2a591353a4404455ca97a49d589d8  openvas-libnasl-2.0.2.tar.gz
7a4342418de2a591353a4404455ca97a49d589d8  /usr/src/redhat/SOURCES/openvas-libnasl-2.0.2.tar.gz
Comment 4 Huzaifa S. Sidhpurwala 2009-12-18 10:14:21 UTC 
[huzaifas@localhost temp]$ sha256sum openvas-lib*
4f295a3d1a414652c16037617544c5d1ea865b9790e83b76dbf1c71b7fd52e41  openvas-libnasl-2.0.2.tar.gz
4f295a3d1a414652c16037617544c5d1ea865b9790e83b76dbf1c71b7fd52e41  openvas-libraries-2.0.2.tar.gz


Should openvas-libraries be called  openvas-libnasl or vice versa?
Comment 5 Huzaifa S. Sidhpurwala 2009-12-18 10:21:44 UTC 
not really, fixing the srpm now :)
Comment 6 Huzaifa S. Sidhpurwala 2009-12-18 10:34:08 UTC 
New:
SPEC: http://huzaifas.fedorapeople.org/spec/openvas-libnasl.spec
SRPM: 
http://huzaifas.fedorapeople.org/srpms/openvas-libnasl-2.0.2-3.fc12.src.rpm

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1879210
Comment 7 Huzaifa S. Sidhpurwala 2009-12-18 10:35:30 UTC 
Xavier,
It seems you have some spec/srpms as well, would you like to co-maintain the stack as well?
Comment 8 Parag AN(पराग) 2009-12-18 11:14:53 UTC 
eview:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1879210
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
7a4342418de2a591353a4404455ca97a49d589d8  openvas-libnasl-2.0.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no .pc file present.
+ -devel subpackage present.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package openvas-libnasl-2.0.2-3.fc13.i686 =>
Provides: libopenvasnasl.so.2
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgcrypt.so.11 libgcrypt.so.11(GCRYPT_1.2) libglib-2.0.so.0 libgnutls.so.26 libgnutls.so.26(GNUTLS_1_4) libgpg-error.so.0 libgpgme.so.11 libgpgme.so.11(GPGME_1.0) libgpgme.so.11(GPGME_1.1) libnsl.so.1 libopenvas.so.2 libopenvas_hg.so.2 libopenvasnasl.so.2 libpcap.so.1 libresolv.so.2 libutil.so.1 rtld(GNU_HASH)
+ Package openvas-libnasl-devel-2.0.2-3.fc13.i686 =>
Requires: /bin/sh libopenvasnasl.so.2
+ Not a GUI application

Suggestions:
1) I see some documentation still there. See if you can add that to spec.

APPROVED.
Comment 9 Huzaifa S. Sidhpurwala 2009-12-18 11:24:48 UTC 
New Package CVS Request
=======================
Package Name: openvas-libnasl
Short Description: Support for NASL scripting language in OpenVAS Server
Owners: huzaifas, sgros
Branches:  rawhide
Comment 10 Toshio Ernie Kuratomi 2009-12-21 18:04:17 UTC 
cvs done.
Comment 11 Huzaifa S. Sidhpurwala 2009-12-22 10:50:41 UTC 
build for rawhide.
Closing this bug
Note You need to log in before you can comment on or make changes to this bug.