Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 553483 - Review Request: dogtag-pki-console-ui - The Dogtag PKI Console User Interface
Summary: Review Request: dogtag-pki-console-ui - The Dogtag PKI Console User Interface
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Dogtag-to-Fedora
TreeView+ depends on / blocked
 
Reported: 2010-01-08 00:37 UTC by Kevin Wright
Modified: 2015-07-13 04:56 UTC (History)
9 users (show)

Fixed In Version: 1.3.0-4.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-04 04:59:22 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)
Licensing diffs . . . (deleted)
2010-01-19 00:48 UTC, Matthew Harmsen 		no flags Details | Diff
Licensing diffs . . . (deleted)
2010-01-19 00:59 UTC, Matthew Harmsen 		no flags Details | Diff
Show Obsolete (1) View All

Description Kevin Wright 2010-01-08 00:37:00 UTC 
first pass at getting dogtag-pki-console-ui into fedora
Comment 1 Kevin Wright 2010-01-12 00:17:55 UTC 
Spec URL: http://people.redhat.com/kwright/dogtag-pki-console-ui/dogtag-pki-console-ui.spec
SRPM URL: http://people.redhat.com/kwright/dogtag-pki-console-ui/dogtag-pki-console-ui-1.3.0-3.fc11.src.rpm

Description: The Dogtag PKI Console User Interface
Comment 2 Matthew Harmsen 2010-01-13 21:47:22 UTC 
Parag Nemade wrote:
> Hi,
>      I am not sure but I think all these dogtag*-ui packages should require some basic pki framework providing package, otherwise if someone just installs say dogtag-pki-console-ui package then he will just get some files installed from that package only. I think pki-common-ui should be Requires in all these -ui packages. Am I right? if so you need to add them to SPEC then.

Actually -- the intent of the UI packages was merely to separate brand-specific "text/graphics" from their associated non-UI component (much like a branding 'skin'):

    * 'pki-common' REQUIRES 'pki-common-ui' which is PROVIDED by EITHER 'dogtag-pki-common-ui' OR 'redhat-pki-common-ui'
    * 'pki-ca' REQUIRES 'pki-ca-ui' which is PROVIDED by EITHER 'dogtag-pki-ca-ui' OR 'redhat-pki-ca-ui'
    * 'pki-kra' REQUIRES 'pki-kra-ui' which is PROVIDED by EITHER 'dogtag-pki-kra-ui' OR 'redhat-pki-kra-ui'
    * 'pki-ocsp' REQUIRES 'pki-ocsp-ui' which is PROVIDED by EITHER 'dogtag-pki-ocsp-ui' OR 'redhat-pki-ocsp-ui'
    * 'pki-tks' REQUIRES 'pki-tks-ui' which is PROVIDED by EITHER 'dogtag-pki-tks-ui' OR 'redhat-pki-tks-ui'
    * 'pki-ra' REQUIRES 'pki-ra-ui' which is PROVIDED by EITHER 'dogtag-pki-ra-ui' OR 'redhat-pki-ra-ui'
    * 'pki-tps' REQUIRES 'pki-tps-ui' which is PROVIDED by EITHER 'dogtag-pki-tps-ui' OR 'redhat-pki-tps-ui'
    * 'pki-console' REQUIRES 'pki-console-ui' which is PROVIDED by EITHER 'dogtag-pki-console-ui' OR 'redhat-pki-console-ui'

Additionally, the 'pki-common' component is ONLY REQUIRED by the Java/Tomcat packages 'pki-ca', 'pki-kra', 'pki-ocsp', 'pki-tks', and 'pki-console'; it is NOT REQUIRED by the Perl/Apache package 'pki-ra' NOR the C/C++/Apache package 'pki-tps'.

>      I tried to install all reviewed packages in Fedora but I see conflicts is not allowing me to install pki-common. May I know specific reason to have it conflicts with tomcat-native?I see both packages provides different files at different installation paths. As per https://fedoraproject.org/wiki/Packaging:Conflicts#Other_Uses_of_Conflicts: , we need to add some information in SPEC file. Sorry that I missed this in package review.

>      Can we have pki-common package updated with this conflict information in its spec file?

The Conflict problems associated with "tomcat-native" are detailed in https://bugzilla.redhat.com/show_bug.cgi?id=441974, and appeared to stem from attempting to run Tomcat using a different security model ( e. g. - openSSL (tomcat-native) conflicting with NSS (tomcatjss->JSS->NSS)).  Although I had originally suggested placing the "Conflicts:" keyword in the 'pki-common' package, I believe that it may be more appropriate to place it within the "tomcatjss" package?

Regardless of which package is chosen, are you suggesting that we need a clearer explanation regarding the reason for this conflict under the "%description" section?

>      Please remove "Requires: bash" as it looks unnecessary.

We used "Requires: bash" because I believe that rpmbuild always needs at least one "Requires:", and we chose "Requires: bash" as the lone "Requires" statement in many of the UI- packages.  Is something else more appropriate (as this is what we ended up using in the "dogtag-pki-ui-ca" package)?

>
>
> Regards,
> Parag

Thanks,
-- Matt
Comment 3 Parag AN(पराग) 2010-01-14 02:20:11 UTC 
(In reply to comment #2)
> Parag Nemade wrote:
> > Hi,
> >      I am not sure but I think all these dogtag*-ui packages should require some basic pki framework providing package, otherwise if someone just installs say dogtag-pki-console-ui package then he will just get some files installed from that package only. I think pki-common-ui should be Requires in all these -ui packages. Am I right? if so you need to add them to SPEC then.
> 
> Actually -- the intent of the UI packages was merely to separate brand-specific
> "text/graphics" from their associated non-UI component (much like a branding
> 'skin'):
> 
>     * 'pki-common' REQUIRES 'pki-common-ui' which is PROVIDED by EITHER
> 'dogtag-pki-common-ui' OR 'redhat-pki-common-ui'
>     * 'pki-ca' REQUIRES 'pki-ca-ui' which is PROVIDED by EITHER
> 'dogtag-pki-ca-ui' OR 'redhat-pki-ca-ui'
>     * 'pki-kra' REQUIRES 'pki-kra-ui' which is PROVIDED by EITHER
> 'dogtag-pki-kra-ui' OR 'redhat-pki-kra-ui'
>     * 'pki-ocsp' REQUIRES 'pki-ocsp-ui' which is PROVIDED by EITHER
> 'dogtag-pki-ocsp-ui' OR 'redhat-pki-ocsp-ui'
>     * 'pki-tks' REQUIRES 'pki-tks-ui' which is PROVIDED by EITHER
> 'dogtag-pki-tks-ui' OR 'redhat-pki-tks-ui'
>     * 'pki-ra' REQUIRES 'pki-ra-ui' which is PROVIDED by EITHER
> 'dogtag-pki-ra-ui' OR 'redhat-pki-ra-ui'
>     * 'pki-tps' REQUIRES 'pki-tps-ui' which is PROVIDED by EITHER
> 'dogtag-pki-tps-ui' OR 'redhat-pki-tps-ui'
>     * 'pki-console' REQUIRES 'pki-console-ui' which is PROVIDED by EITHER
> 'dogtag-pki-console-ui' OR 'redhat-pki-console-ui'
> 
> Additionally, the 'pki-common' component is ONLY REQUIRED by the Java/Tomcat
> packages 'pki-ca', 'pki-kra', 'pki-ocsp', 'pki-tks', and 'pki-console'; it is
> NOT REQUIRED by the Perl/Apache package 'pki-ra' NOR the C/C++/Apache package
> 'pki-tps'.

OK.


> 
> >      I tried to install all reviewed packages in Fedora but I see conflicts is not allowing me to install pki-common. May I know specific reason to have it conflicts with tomcat-native?I see both packages provides different files at different installation paths. As per https://fedoraproject.org/wiki/Packaging:Conflicts#Other_Uses_of_Conflicts: , we need to add some information in SPEC file. Sorry that I missed this in package review.
> 
> >      Can we have pki-common package updated with this conflict information in its spec file?
> 
> The Conflict problems associated with "tomcat-native" are detailed in
> https://bugzilla.redhat.com/show_bug.cgi?id=441974, and appeared to stem from
> attempting to run Tomcat using a different security model ( e. g. - openSSL
> (tomcat-native) conflicting with NSS (tomcatjss->JSS->NSS)).  Although I had
> originally suggested placing the "Conflicts:" keyword in the 'pki-common'
> package, I believe that it may be more appropriate to place it within the
> "tomcatjss" package?
> 
> Regardless of which package is chosen, are you suggesting that we need a
> clearer explanation regarding the reason for this conflict under the
> "%description" section?

Please document bug id and some information in pki-common SPEC file. And yes you can also add in description that "this package conflicts with tomcat-native"
Guidelines says "include the reasoning in a comment next to the Conflicts: entry, so that it will be abundantly clear why it needed to exist."
Also, not sure whether we need to ask FESCo for approval of this Conflicts usage though I see its correct reason to use it.

> 
> >      Please remove "Requires: bash" as it looks unnecessary.
> 
> We used "Requires: bash" because I believe that rpmbuild always needs at least
> one "Requires:", and we chose "Requires: bash" as the lone "Requires" statement
> in many of the UI- packages.  Is something else more appropriate (as this is
> what we ended up using in the "dogtag-pki-ui-ca" package)?
> 
 I suggested removing "Requires: bash" in pki-common review also. This is false assumption that rpmbuild needs at least one "Requires". Please remove this from all packages waiting for review.
Comment 4 Matthew Harmsen 2010-01-14 23:04:36 UTC 
> Please document bug id and some information in pki-common SPEC file. And yes
> you can also add in description that "this package conflicts with
> tomcat-native"
> Guidelines says "include the reasoning in a comment next to the Conflicts:
> entry, so that it will be abundantly clear why it needed to exist."
> Also, not sure whether we need to ask FESCo for approval of this Conflicts
> usage though I see its correct reason to use it.

We removed "Conflict: tomcat-native" from the 'pki-common' package (which will be re-spun), and added "Conflict: tomcat-native", preceded it by a descriptive comment which referenced Bugzilla Bug #441974, and augmented the "%description" section in the lower-level 'tomcatjss' package (which will also be re-spun).

> I suggested removing "Requires: bash" in pki-common review also. This is false
> assumption that rpmbuild needs at least one "Requires". Please remove this from
> all packages waiting for review.

Done.  (no UI components reference 'bash' - 7 of the 8 UI components will be re-spun -- dogtag-pki-console-ui did not previously contain this reference)
Comment 5 Parag AN(पराग) 2010-01-15 06:08:47 UTC 
(In reply to comment #4)
> > Please document bug id and some information in pki-common SPEC file. And yes
> > you can also add in description that "this package conflicts with
> > tomcat-native"
> > Guidelines says "include the reasoning in a comment next to the Conflicts:
> > entry, so that it will be abundantly clear why it needed to exist."
> > Also, not sure whether we need to ask FESCo for approval of this Conflicts
> > usage though I see its correct reason to use it.
> 
> We removed "Conflict: tomcat-native" from the 'pki-common' package (which will
> be re-spun), and added "Conflict: tomcat-native", preceded it by a descriptive
> comment which referenced Bugzilla Bug #441974, and augmented the "%description"
> section in the lower-level 'tomcatjss' package (which will also be re-spun).
> 
> > I suggested removing "Requires: bash" in pki-common review also. This is false
> > assumption that rpmbuild needs at least one "Requires". Please remove this from
> > all packages waiting for review.
> 
> Done.  (no UI components reference 'bash' - 7 of the 8 UI components will be
> re-spun -- dogtag-pki-console-ui did not previously contain this reference)    

But I can still see following spec files need bash
http://people.redhat.com/kwright/dogtag-pki-kra-ui/dogtag-pki-kra-ui.spec
http://people.redhat.com/kwright/dogtag-pki-tks-ui/dogtag-pki-tks-ui.spec
http://people.redhat.com/kwright/dogtag-pki-tps-ui/dogtag-pki-tps-ui.spec
http://people.redhat.com/kwright/dogtag-pki-ocsp-ui/dogtag-pki-ocsp-ui.spec
http://people.redhat.com/kwright/dogtag-pki-ra-ui/dogtag-pki-ra-ui.spec
Comment 6 Kevin Wright 2010-01-15 17:05:29 UTC 
Parag. I have the corrected spec files and will be updating these shortly.
Comment 7 Matthew Harmsen 2010-01-19 00:41:26 UTC 
Hi,
   I have looked into those -ui packages now and saw some strange source code licensing. I see dogtag-pki-ra-ui, dogtag-pki-tps-ui, dogtag-pki-console-ui tarballs and found same kind of file got licensed at one tarball as GPLv2 and in other tarball as LGPLv2.
e.g.
head dogtag-pki-ra-ui-1.3.0/shared/docroot/ra/admin/console/config/header.vm
===> gave me GPLv2
head dogtag-pki-tps-ui-1.3.0/shared/docroot/tps/admin/console/config/header.vm
===> gave me LGPLv2

Do you see some kind of consistency should be there in upstream tarballs for licensing of these files? I think I only got licensing issues and rest srpms look ok to be approved. I only need feedback like do you want to change upstream source licenses?  Otherwise with this suggested license tag, I will approve reviews provided changes will be done at time of initial import of these packages.

I also had discussion with nirik about licensing for these packages and got to know, we should use license tag as "GPLv2 and LGPLv2", reason "someone could take just one of the LGPLv2 files and use it in another project, with LPGL...". So, the packages that I see need to be corrected are dogtag-pki-ra-ui, dogtag-pki-tps-ui, dogtag-pki-console-ui, dogtag-pki-common-ui.

Thanks & Regards,
Parag
Comment 8 Matthew Harmsen 2010-01-19 00:48:03 UTC 
Created attachment 385287 [details]
Licensing diffs . . .
Comment 9 Matthew Harmsen 2010-01-19 00:59:18 UTC 
Created attachment 385288 [details]
Licensing diffs . . .
Comment 10 Matthew Harmsen 2010-01-19 01:14:07 UTC 
In 'attachment (id=385288)', I changed ALL references of LGPLv2 to GPLv2 in the following packages:

    * dogtag-pki-common-ui,
    * dogtag-pki-console-ui, and
    * dogtag-pki-ra-ui

and thus left the associated spec files with 'License:   GPLv2'.

Additionally, I changed MOST references of LGPLv2 to GPLv2 in the 'dogtag-pki-tps-ui' package.  However, since 'dogtag-pki-tps-ui' contained some files that were provided by a third-party which explicitly referenced LGPLv2, I left these headers intact, and changed the 'dogtag-pki-tps-ui' spec file as suggested above to 'License:   GPLv2 and LGPLv2'.

This attachment and these comments were added to:

    * Bugzilla Bug #553483 -  Review Request: dogtag-pki-console-ui - The Dogtag
      PKI Console User Interface,
    * Bugzilla Bug #522204 -  New Package for Dogtag PKI: dogtag-pki-common-ui,
    * Bugzilla Bug #553848 -  Review Request: dogtag-pki-ra-ui - The Dogtag
      Registration Authority User Interface, and
    * Bugzilla Bug #553851 -  Review Request: dogtag-pki-tps-ui - The Dogtag
      Token Processing System User Interface
Comment 11 Andrew Wnuk 2010-01-19 01:29:35 UTC 
attachment (id=385288)  +awnuk
Comment 12 Matthew Harmsen 2010-01-19 01:46:05 UTC 
# cd pki/dogtag

# svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^?
M       tps-ui/build_dogtag
M       tps-ui/shared/cgi-bin/so/Enroll.html
M       tps-ui/shared/cgi-bin/demo/Enroll.html
M       tps-ui/shared/cgi-bin/home/Enroll.html
M       tps-ui/shared/cgi-bin/sow/noaccess.html
M       tps-ui/shared/cgi-bin/sow/seturl.html
M       tps-ui/shared/cgi-bin/sow/enroll_temp.html
M       tps-ui/shared/cgi-bin/sow/read_temp.html
M       tps-ui/shared/cgi-bin/sow/main.html
M       tps-ui/shared/cgi-bin/sow/search.html
M       tps-ui/shared/cgi-bin/sow/cfg.pl
M       tps-ui/shared/cgi-bin/sow/format.html
M       tps-ui/shared/cgi-bin/sow/formatso.html
M       tps-ui/shared/cgi-bin/sow/search_temp.html
M       tps-ui/shared/cgi-bin/sow/enroll.html
M       tps-ui/shared/cgi-bin/sow/read.html
M       tps-ui/shared/cgi-bin/sow/welcome.html
M       tps-ui/shared/docroot/tokendb/search.template
M       tps-ui/shared/docroot/tokendb/editResults.template
M       tps-ui/shared/docroot/tokendb/searchCertificate.template
M       tps-ui/shared/docroot/tokendb/addResults.template
M       tps-ui/shared/docroot/tokendb/searchActivityAdminResults.template
M       tps-ui/shared/docroot/tokendb/show.template
M       tps-ui/shared/docroot/tokendb/indexAdmin.template
M       tps-ui/shared/docroot/tokendb/doTokenConfirm.template
M       tps-ui/shared/docroot/tokendb/searchActivity.template
M       tps-ui/shared/docroot/tokendb/deleteResults.template
M       tps-ui/shared/docroot/tokendb/editUser.template
M       tps-ui/shared/docroot/tokendb/edit.template
M       tps-ui/shared/docroot/tokendb/searchUserResults.template
M       tps-ui/shared/docroot/tokendb/newUser.template
M       tps-ui/shared/docroot/tokendb/new.template
M       tps-ui/shared/docroot/tokendb/showAdmin.template
M       tps-ui/shared/docroot/tokendb/searchCertificateResults.template
M       tps-ui/shared/docroot/tokendb/revoke.template
M       tps-ui/shared/docroot/tokendb/searchActivityAdmin.template
M       tps-ui/shared/docroot/tokendb/doToken.template
M       tps-ui/shared/docroot/tokendb/searchActivityResults.template
M       tps-ui/shared/docroot/tokendb/index.template
M       tps-ui/shared/docroot/tokendb/searchAdmin.template
M       tps-ui/shared/docroot/tokendb/auditAdmin.template
M       tps-ui/shared/docroot/tokendb/indexOperator.template
M       tps-ui/shared/docroot/tokendb/searchResults.template
M       tps-ui/shared/docroot/tokendb/error.template
M       tps-ui/shared/docroot/tokendb/showCert.template
M       tps-ui/shared/docroot/tokendb/searchAdminResults.template
M       tps-ui/shared/docroot/tokendb/userDelete.template
M       tps-ui/shared/docroot/tokendb/delete.template
M       tps-ui/shared/docroot/tokendb/searchUser.template
M       tps-ui/shared/docroot/tps/admin/console/config/hierarchypanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/footer.vm
M       tps-ui/shared/docroot/tps/admin/console/config/createsubsystempanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/modulepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/donepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/displaycertchainpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/login.vm
M       tps-ui/shared/docroot/tps/admin/console/config/adminpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/config_db.vm
M       tps-ui/shared/docroot/tps/admin/console/config/config_hsm.vm
M       tps-ui/shared/docroot/tps/admin/console/config/config_rootca.vm
M       tps-ui/shared/docroot/tps/admin/console/config/securitydomainpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/cainfopanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/certchainpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/config_join.vm
M       tps-ui/shared/docroot/tps/admin/console/config/config_addhsm.vm
M       tps-ui/shared/docroot/tps/admin/console/config/certrequestpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/topmenu.vm
M       tps-ui/shared/docroot/tps/admin/console/config/displaycertchain2panel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/header.vm
M       tps-ui/shared/docroot/tps/admin/console/config/tksinfopanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/wizard.vm
M       tps-ui/shared/docroot/tps/admin/console/config/namepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/certprettyprintpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/adminauthenticatepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/securitydomainloginpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/sidemenu.vm
M       tps-ui/shared/docroot/tps/admin/console/config/welcomepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/agentauthenticatepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/drminfopanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/importadmincertpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/databasepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/config_hsmloginpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/authdbpanel.vm
M       tps-ui/shared/docroot/tps/admin/console/config/sizepanel.vm
M       tps-ui/shared/docroot/tps/admin/console/js/misc.js
M       tps-ui/shared/docroot/css/pki-360.css
M       tps-ui/shared/docroot/css/pki-base.css
M       tps-ui/shared/docroot/css/pki.css
M       tps-ui/shared/docroot/esc/so/GenericAuth.html
M       tps-ui/shared/docroot/esc/so/EnrollSuccess.html
M       tps-ui/shared/docroot/esc/so/style.css
M       tps-ui/shared/docroot/esc/so/util.js
M       tps-ui/shared/docroot/esc/GenericAuth.html
M       tps-ui/shared/docroot/esc/EnrollPopup.html
M       tps-ui/shared/docroot/esc/demo/GenericAuth.html
M       tps-ui/shared/docroot/esc/demo/EnrollSuccess.html
M       tps-ui/shared/docroot/esc/demo/style.css
M       tps-ui/shared/docroot/esc/demo/util.js
M       tps-ui/shared/docroot/esc/AdminEsc.html
M       tps-ui/shared/docroot/esc/style.css
M       tps-ui/shared/docroot/esc/home/GenericAuth.html
M       tps-ui/shared/docroot/esc/home/EnrollSuccess.html
M       tps-ui/shared/docroot/esc/home/style.css
M       tps-ui/shared/docroot/esc/home/util.js
M       tps-ui/shared/docroot/esc/sow/GenericAuth.html
M       tps-ui/shared/docroot/esc/sow/EnrollSuccess.html
M       tps-ui/shared/docroot/esc/sow/style.css
M       tps-ui/shared/docroot/esc/sow/util.js
M       tps-ui/shared/docroot/esc/AdvancePopup.html
M       tps-ui/shared/docroot/esc/TokenPin.html
M       tps-ui/shared/docroot/esc/SettingsEsc.html
M       tps-ui/shared/docroot/esc/TokenManager.html
M       tps-ui/build.xml
M       tps-ui/dogtag-pki-tps-ui.spec
M       common-ui/dogtag-pki-common-ui.spec
M       common-ui/build_dogtag
M       common-ui/shared/admin/console/css/pki-360.css
M       common-ui/shared/admin/console/css/pki-base.css
M       common-ui/shared/admin/console/css/pki.css
M       common-ui/shared/admin/console/js/misc.js
M       console-ui/src/com/netscape/management/client/theme/theme.properties
M       console-ui/dogtag-pki-console-ui.spec
M       ra-ui/shared/docroot/css/pki-360.css
M       ra-ui/shared/docroot/css/pki-base.css
M       ra-ui/shared/docroot/css/pki.css
M       ra-ui/dogtag-pki-ra-ui.spec

# svn commit
Sending        dogtag/common-ui/build_dogtag
Sending        dogtag/common-ui/dogtag-pki-common-ui.spec
Sending        dogtag/common-ui/shared/admin/console/css/pki-360.css
Sending        dogtag/common-ui/shared/admin/console/css/pki-base.css
Sending        dogtag/common-ui/shared/admin/console/css/pki.css
Sending        dogtag/common-ui/shared/admin/console/js/misc.js
Sending        dogtag/console-ui/dogtag-pki-console-ui.spec
Sending        dogtag/console-ui/src/com/netscape/management/client/theme/theme.properties
Sending        dogtag/ra-ui/dogtag-pki-ra-ui.spec
Sending        dogtag/ra-ui/shared/docroot/css/pki-360.css
Sending        dogtag/ra-ui/shared/docroot/css/pki-base.css
Sending        dogtag/ra-ui/shared/docroot/css/pki.css
Sending        dogtag/tps-ui/build.xml
Sending        dogtag/tps-ui/build_dogtag
Sending        dogtag/tps-ui/dogtag-pki-tps-ui.spec
Sending        dogtag/tps-ui/shared/cgi-bin/demo/Enroll.html
Sending        dogtag/tps-ui/shared/cgi-bin/home/Enroll.html
Sending        dogtag/tps-ui/shared/cgi-bin/so/Enroll.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/cfg.pl
Sending        dogtag/tps-ui/shared/cgi-bin/sow/enroll.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/enroll_temp.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/format.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/formatso.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/main.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/noaccess.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/read.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/read_temp.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/search.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/search_temp.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/seturl.html
Sending        dogtag/tps-ui/shared/cgi-bin/sow/welcome.html
Sending        dogtag/tps-ui/shared/docroot/css/pki-360.css
Sending        dogtag/tps-ui/shared/docroot/css/pki-base.css
Sending        dogtag/tps-ui/shared/docroot/css/pki.css
Sending        dogtag/tps-ui/shared/docroot/esc/AdminEsc.html
Sending        dogtag/tps-ui/shared/docroot/esc/AdvancePopup.html
Sending        dogtag/tps-ui/shared/docroot/esc/EnrollPopup.html
Sending        dogtag/tps-ui/shared/docroot/esc/GenericAuth.html
Sending        dogtag/tps-ui/shared/docroot/esc/SettingsEsc.html
Sending        dogtag/tps-ui/shared/docroot/esc/TokenManager.html
Sending        dogtag/tps-ui/shared/docroot/esc/TokenPin.html
Sending        dogtag/tps-ui/shared/docroot/esc/demo/EnrollSuccess.html
Sending        dogtag/tps-ui/shared/docroot/esc/demo/GenericAuth.html
Sending        dogtag/tps-ui/shared/docroot/esc/demo/style.css
Sending        dogtag/tps-ui/shared/docroot/esc/demo/util.js
Sending        dogtag/tps-ui/shared/docroot/esc/home/EnrollSuccess.html
Sending        dogtag/tps-ui/shared/docroot/esc/home/GenericAuth.html
Sending        dogtag/tps-ui/shared/docroot/esc/home/style.css
Sending        dogtag/tps-ui/shared/docroot/esc/home/util.js
Sending        dogtag/tps-ui/shared/docroot/esc/so/EnrollSuccess.html
Sending        dogtag/tps-ui/shared/docroot/esc/so/GenericAuth.html
Sending        dogtag/tps-ui/shared/docroot/esc/so/style.css
Sending        dogtag/tps-ui/shared/docroot/esc/so/util.js
Sending        dogtag/tps-ui/shared/docroot/esc/sow/EnrollSuccess.html
Sending        dogtag/tps-ui/shared/docroot/esc/sow/GenericAuth.html
Sending        dogtag/tps-ui/shared/docroot/esc/sow/style.css
Sending        dogtag/tps-ui/shared/docroot/esc/sow/util.js
Sending        dogtag/tps-ui/shared/docroot/esc/style.css
Sending        dogtag/tps-ui/shared/docroot/tokendb/addResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/auditAdmin.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/delete.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/deleteResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/doToken.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/doTokenConfirm.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/edit.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/editResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/editUser.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/error.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/index.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/indexAdmin.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/indexOperator.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/new.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/newUser.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/revoke.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/search.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchActivity.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchActivityAdmin.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchActivityAdminResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchActivityResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchAdmin.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchAdminResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchCertificate.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchCertificateResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchUser.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/searchUserResults.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/show.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/showAdmin.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/showCert.template
Sending        dogtag/tps-ui/shared/docroot/tokendb/userDelete.template
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/adminauthenticatepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/adminpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/agentauthenticatepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/authdbpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/cainfopanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/certchainpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/certprettyprintpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/certrequestpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/config_addhsm.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/config_db.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/config_hsm.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/config_hsmloginpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/config_join.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/config_rootca.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/createsubsystempanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/databasepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/displaycertchain2panel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/displaycertchainpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/donepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/drminfopanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/footer.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/header.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/hierarchypanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/importadmincertpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/login.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/modulepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/namepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/securitydomainloginpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/securitydomainpanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/sidemenu.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/sizepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/tksinfopanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/topmenu.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/welcomepanel.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/config/wizard.vm
Sending        dogtag/tps-ui/shared/docroot/tps/admin/console/js/misc.js
Transmitting file data ..............................................................................................................................
Committed revision 930.
Comment 13 Kevin Wright 2010-01-19 02:34:00 UTC 
Updated spec file and src rpm:

Spec URL: http://people.redhat.com/kwright/dogtag-pki-console-ui/dogtag-pki-console-ui.spec
SRPM URL: http://people.redhat.com/kwright/dogtag-pki-console-ui/dogtag-pki-console-ui-1.3.0-4.fc11.src.rpm
Comment 14 Parag AN(पराग) 2010-01-19 04:10:31 UTC 
Matthew,
   We don't need each and every commit log in upstream to be commented here. So
please avoid commenting here upstream tarball changes.
Comment 15 Parag AN(पराग) 2010-01-19 04:19:58 UTC 
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1931051
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
78470239d748090ede466fc5f4423ca7fe4429b2  dogtag-pki-console-ui-1.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package dogtag-pki-console-ui-1.3.0-4.fc13.noarch  =>
Provides: pki-console-ui = 1.3.0-4.fc13
Obsoletes: pki-console-ui < 1.3.0-4.fc13

APPROVED.
Comment 16 Kevin Wright 2010-01-19 07:59:13 UTC 
New Package CVS Request
=======================
Package Name: dogtag-pki-console-ui
Short Description: The Dogtag  PKI Console User Interface
Owners: kwright
Branches: F-11, F-12, EL-5
InitialCC: ausil
Comment 17 Jason Tibbitts 2010-01-19 18:22:05 UTC 
CVS done (by process-cvs-requests.py).
Comment 18 Fedora Update System 2010-01-19 19:42:24 UTC 
dogtag-pki-console-ui-1.3.0-4.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/dogtag-pki-console-ui-1.3.0-4.fc11
Comment 19 Fedora Update System 2010-01-19 21:03:09 UTC 
dogtag-pki-console-ui-1.3.0-4.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/dogtag-pki-console-ui-1.3.0-4.fc12
Comment 20 Fedora Update System 2010-01-20 00:59:34 UTC 
dogtag-pki-console-ui-1.3.0-4.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/dogtag-pki-console-ui-1.3.0-4.el5
Comment 21 Fedora Update System 2010-01-20 22:39:48 UTC 
dogtag-pki-console-ui-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update dogtag-pki-console-ui'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0100
Comment 22 Fedora Update System 2010-01-21 00:03:29 UTC 
dogtag-pki-console-ui-1.3.0-4.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update dogtag-pki-console-ui'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0814
Comment 23 Fedora Update System 2010-01-21 00:05:47 UTC 
dogtag-pki-console-ui-1.3.0-4.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update dogtag-pki-console-ui'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0820
Comment 24 Fedora Update System 2010-02-05 23:51:55 UTC 
dogtag-pki-console-ui-1.3.0-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 25 Fedora Update System 2010-02-06 00:01:31 UTC 
dogtag-pki-console-ui-1.3.0-4.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 26 Fedora Update System 2010-02-09 03:56:39 UTC 
dogtag-pki-console-ui-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.