Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 557254 - Review Request: Medusa - Login Bruteforcer
Summary: Review Request: Medusa - Login Bruteforcer
Keywords:
Status: CLOSED DUPLICATE of bug 491084
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-20 20:29 UTC by Hiemanshu
Modified: 2010-01-20 21:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-20 21:42:39 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Hiemanshu 2010-01-20 20:29:25 UTC 
Spec URL: http://hiemanshu.fedorapeople.org/SPECS/medusa.spec
SRPM URL: http://hiemanshu.fedorapeople.org/SRPMS/medusa-1.5-1.fc12.src.rpm
Description: Medusa is intended to be a speedy, massively parallel, modular, login brute-forcer. The goal is to support as many services which allow remote authentication as possible.

rpmlint *.rpm
medusa.x86_64: W: no-version-in-last-changelog
medusa-debuginfo.x86_64: W: no-version-in-last-changelog
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Its a Warning about an upstream ChangeLog which can be ignored.
Comment 1 Xavier Bachelot 2010-01-20 20:52:31 UTC 
You cannot set the review flag yourself, the reviewer will do.

A couple comment on the spec while I'm at it :

The rpmlint warning is valid, you need to have the version-release in the specfile changelog, like :
* Thu Jan 21 2010 Hiemanshu Sharma <hiemanshu AT fedoraproject DOT org> 1.5-1

Replace %{_usr}/bin/medusa with %{_bindir}/medusa

The rpm doesn't properly own the directories it creates :
%{_libdir}/medusa and %{_libdir}/medusa/modules/ are not owned.
You can replace the whole block with : %{_libdir}/medusa, everything below it will be properly owned.

Replace %{_usr}/share/man/man1/medusa.1.gz with %{_mandir}/man1/medusa.1.gz
Comment 2 Hiemanshu 2010-01-20 21:07:28 UTC 
Sorry my bad about the flag.

Spec URL: http://hiemanshu.fedorapeople.org/SPECS/medusa.spec
SRPM URL: http://hiemanshu.fedorapeople.org/SRPMS/medusa-1.5-2.fc12.src.rpm
Koji Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1934796


rpmlint *.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

-Hiemanshu Sharma
Comment 3 Xavier Bachelot 2010-01-20 21:20:48 UTC 
Some more :
You need to call the %configure macro in the %build section, not in the %prep
section.

Summary: does not really describe the purpose of this software

rpmlint also complains about the indentation :
medusa.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5)

There are a few trailing spaces (License: and %doc lines)
Comment 4 Xavier Bachelot 2010-01-20 21:28:36 UTC 
3 modules are not enabled due to missing BuildRequires:

configure:     Medusa Module Build Summary
configure:
configure:     AFP             ** Disabled **
configure:     POSTGRES        ** Disabled **
configure:     SVN             ** Disabled **

Add :
BuildRequires: afpfs-ng-devel
BuildRequires: postgresql-devel
BuildRequires: apr-devel
Comment 5 Xavier Bachelot 2010-01-20 21:30:20 UTC 
btw, you did not upload the new specfile.
Comment 6 Jason Tibbitts 2010-01-20 21:34:21 UTC 
Sure looks to me like this package is already in the distribution.
Comment 7 Xavier Bachelot 2010-01-20 21:42:39 UTC 
You're right. Closing as duplicate.

*** This bug has been marked as a duplicate of bug 491084 ***
Note You need to log in before you can comment on or make changes to this bug.