Just updated to the latest, including the -24 kernel which will be in beta. Still no thaw.

Guys, this is clearly a regression. Am I the only one reporting it?

(In reply to comment #1)

> Guys, this is clearly a regression. Am I the only one reporting it?    

Looks like other people noticed the same:

http://www.thinkwiki.org/wiki/Installing_Fedora_13_on_a_ThinkPad_X40

Can we get some feedback on this?

I just changed priority/severity to high, because without this we cannot beat F-13 into shape regarding problems with hibernate/thaw and Intel graphics.

See: https://bugzilla.kernel.org/show_bug.cgi?id=13811
Also see: bug #537494.

Still doesn't work, with fully updated F-13 as of 2010-04-20. Kernel from koji: 2.6.33.2-56.fc13.i686.PAE.

Has anyone even looked at this bug?

Just dropped the Dell Inspiron 6400 from the title of this bug. My new Dell Studio 1588 notebook also cannot thaw.

I'll put this on the blocker for review, but I'm not all that optimistic that it would be a release blocker.  Nowhere within our release criteria https://fedoraproject.org/wiki/Fedora_13_Final_Release_Criteria do we have anything about suspend or hibernate.  But that's why we do review, to make a group decision.

Yeah, I went through the release criteria myself and hibernate/thaw wasn't there. Who knows, maybe it should be?

It's just that it's a regression, so I'm surprised nobody noticed it. Suspend/resume is nice, but not so much when your battery dies :-)

PS. I'll bet $5 that the fix will be less than 10 lines ;-)

Oh, and thanks!

Just a comment that hibernate/thaw works fine for me on two different machines, so it's surely not affecting everyone.

This bug was discussed at the 2010/04/30 blocker review meeting. 

We agreed it is not a release blocker. We generally do not consider suspend/hibernate bugs which are hardware-specific as blockers, as it's unrealistic to expect all possible suspend/hibernate scenarios to work (they never have for any release). We would consider an issue which caused all, or the vast majority, of systems to fail to suspend/hibernate properly as a blocker, but that would be all. This is why there is (intentionally) no criterion for suspend/hibernate functionality.

We would accept a fix for this for the final release if it's ready in time (Tuesday 2010/05/04), and is reasonably small / safe.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

(In reply to comment #9)
> Just a comment that hibernate/thaw works fine for me on two different machines,
> so it's surely not affecting everyone.    

Out of curiosity, what's you file system setup? Is it using LVM or straight partitions?

Found the culprit. Anaconda put these into my kernel line of /boot/grub/grub.conf:

kernel /vmlinuz-2.6.33.3-72.fc13.i686.PAE ro root=/dev/mapper/vg00-f13 rd_LVM_LV=vg00/f13 rd_NO_LUKS rd_NO_MD rd_NO_DM LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYTABLE=us

When I changed to:

kernel /vmlinuz-2.6.33.3-72.fc13.i686.PAE ro root=/dev/mapper/vg00-f13 LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYTABLE=us

Hibernate started working again.

So, something to do with Anaconda/dracut, I guess. Not sure exactly how rd_NO_LUKS rd_NO_MD rd_NO_DM affected the who thing, but they did.

So removing the rd_* options from the command line makes it work. These options are interpreted by the initramfs. Reassigning to dracut then.

Changing priority/severity to medium, because there is a known workaround.

(In reply to comment #12)
 
> So, something to do with Anaconda/dracut, I guess. Not sure exactly how
> rd_NO_LUKS rd_NO_MD rd_NO_DM affected the who thing, but they did.    

Ah, darn cut'n'paste... I also cut out rd_LVM_LV=vg00/f13, as can be seen above.

where are your swap partitions located?

anaconda should probably honor the swap partitions in the setup of the dracut arguments.

(In reply to comment #16)
> where are your swap partitions located?    

On LVM:

/dev/mapper/vg00-lv01 swap swap defaults 0 0

BTW, the workaround also makes Studio 1558 thaw just fine.

Have this in the kernel line there:

kernel /vmlinuz-2.6.33.3-72.fc13.x86_64 ro root=/dev/mapper/vg00-lv00 LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYTABLE=us

the correct fix would be for you to add "rd_LVM_LV=vg00/lv01" to the original kernel command line

OK, lemme try that.

(In reply to comment #19)
> the correct fix would be for you to add "rd_LVM_LV=vg00/lv01" to the original
> kernel command line    

Yeah, that works. Now I have:

kernel /vmlinuz-2.6.33.3-72.fc13.x86_64 ro root=/dev/mapper/vg00-lv00 rd_LVM_LV=vg00/lv00 rd_LVM_LV=vg00/lv01 rd_NO_LUKS rd_NO_MD rd_NO_DM LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYTABLE=us

Fixing this would require cherry picking the following patches to F-13 branch:
http://git.fedorahosted.org/git/?p=anaconda.git;a=commitdiff;h=cbd54442e4f3f839032135bde73c837a44bb4b75
http://git.fedorahosted.org/git?p=anaconda.git;a=commitdiff;h=fd25f5c189e26f66c1c4872956ee7b769b257cfa

The first one has seen quite a bit of testing in RHEL-6, the second one is new but pretty safe. So if someone can make a call if this is a F13Blocker or not I'll cherry pick them (or not).

Since this is a bug in anaconda, does it mean that it cannot be reasonably fixed in a post-release update?

(In reply to comment #23)
> Since this is a bug in anaconda, does it mean that it cannot be reasonably
> fixed in a post-release update?    

Correct.

In that case I say it really should be a blocker...

(In reply to comment #10)
> We agreed it is not a release blocker. We generally do not consider
> suspend/hibernate bugs which are hardware-specific as blockers,

Based on the findings here, it is not hw-specific.

> We would consider an issue which caused all, or
> the vast majority, of systems to fail to suspend/hibernate properly as a
> blocker, but that would be all.

This one will cause most systems to fail to resume from hibernation,
as the default installation uses swap on LVM.

And it cannot be solved by a post-release update.

Yeah, I agree this is a blocker given the better diagnosis we have of the problem. Please pull the fix into the next anaconda.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

This is fixed in anaconda-13.40-1, moving to modified.

Bojan, can you please test with this updates.img:

http://people.fedoraproject.org/~jwrdegoede/f13-updates.img

? it should fix the bug. Thanks!

(In reply to comment #28)
> Bojan, can you please test with this updates.img:
> 
> http://people.fedoraproject.org/~jwrdegoede/f13-updates.img
> 
> ? it should fix the bug. Thanks!    

OK. I guess I supply this image to F-13 Beta installer, correct?

yeah (or, well, even TC1: http://serverbeach1.fedoraproject.org/pub/alt/stage/13.TC1/ )

use updates=http://people.fedoraproject.org/~jwrdegoede/f13-updates.img as a kernel parameter.

OK, thanks. I'm guessing the image will be good for both i686 and x86_64, right? I have both here...

Anyhow, I'm busy doing my day job right now (bills have to be paid and all that), so I'll do this sometime tonight, Sydney time.

anaconda-13.40-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/anaconda-13.40-1.fc13

anaconda-13.40-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update anaconda'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/anaconda-13.40-1.fc13

(In reply to comment #31)
> OK, thanks. I'm guessing the image will be good for both i686 and x86_64,
> right? I have both here...

Tried on x86_64, got bug #589088.

(In reply to comment #34)
> (In reply to comment #31)
> > OK, thanks. I'm guessing the image will be good for both i686 and x86_64,
> > right? I have both here...
> 
> Tried on x86_64, got bug #589088.    

Bug 589088 is caused by using an updates.img meant to be used with TC1 with the beta. You must use the provided updates.img with TC1, it can be used with either i686 or x86_64.

Right, thanks. I'll download that tomorrow and try again. I tried with Beta, which I used previously to install this box.

(In reply to comment #36)
> Right, thanks. I'll download that tomorrow and try again. I tried with Beta,
> which I used previously to install this box.    

Great thanks for testing!

We should now be able to confirm that this bug is fixed using the images here:

http://alt.fedoraproject.org/pub/alt/stage/13.0505/Fedora/i386/os/images/

if we have not yet confirmed the fix, can anyone able to reproduce this bug please test with one of those images and check that the bug is fixed? Thanks.

Verified the right stuff shows up in the grub config, and pm-hibernate/thaw works as expected.

(In reply to comment #38)
> We should now be able to confirm that this bug is fixed using the images here:
> 
> http://alt.fedoraproject.org/pub/alt/stage/13.0505/Fedora/i386/os/images/
> 
> if we have not yet confirmed the fix, can anyone able to reproduce this bug
> please test with one of those images and check that the bug is fixed? Thanks.    

Downloading now.

I think we'll wait for Bojan's confirmation to close this.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

(In reply to comment #41)
> I think we'll wait for Bojan's confirmation to close this.

Works! Ship it boys :-)

PS. I installed next to my x86_64 and noticed a few things:

1. I used custom FS layout. Anaconda was unable to recognise my existing swap partition as swap, so I created another one, which was then added to the kernel line under rd_LVM_LV, together with the new root partition. I'm guessing because there was an existing hibernation image on that partition (that of x86_64), so it was careful not to break it. Hopefully on purpose.

2. I was expecting that my existing grub.conf, which had references to my existing x86_64 F-13, would be preserved. Not so. I simply got one entry - that of the new i686 install done by 13.0505. Not sure about that one.

This was in grub.conf after installation:

title Fedora (2.6.33.3-79.fc13.i686.PAE)
	root (hd0,0)
	kernel /vmlinuz-2.6.33.3-79.fc13.i686.PAE ro root=/dev/mapper/vg00-f13.0505 rd_LVM_LV=vg00/f13.0505 rd_LVM_LV=vg00/f13.0505.swap rd_NO_LUKS rd_NO_MD rd_NO_DM LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYTABLE=us rhgb quiet
	initrd /initramfs-2.6.33.3-79.fc13.i686.PAE.img

anaconda-13.40-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.