Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 602597 - Review Request: perl-Package-Stash - Routines for manipulating stashes
Summary: Review Request: perl-Package-Stash - Routines for manipulating stashes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Weyl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-10 09:30 UTC by Paul Howarth
Modified: 2010-06-30 14:24 UTC (History)
3 users (show)

Fixed In Version: perl-Package-Stash-0.03-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-06-14 17:19:27 UTC
Type: ---
Embargoed:
cweyl: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Paul Howarth 2010-06-10 09:30:59 UTC 
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Package-Stash/branches/fedora/perl-Package-Stash.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Package-Stash/perl-Package-Stash-0.03-1.fc14.src.rpm
Description:

Manipulating stashes (Perl's symbol tables) is occasionally necessary, but
incredibly messy, and easy to get wrong. This module hides all of that behind
a simple API.

This package is needed for Class::MOP 1.03.
Comment 1 Chris Weyl 2010-06-12 02:16:47 UTC 
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2246047
Comment 2 Chris Weyl 2010-06-12 02:24:54 UTC 
Thanks for packaging this :)

The package looks good; the following are suggestions, not blockers.

DESTDIR seems to be a safer choice than PERL_INSTALL_ROOT given the recent fun
around it.  Please consider using %{?perl_default_filter}; it won't harm 
anything and it will make sure unwanted deps don't creep in down the road.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2246047

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Latest version (0.03) is being packaged.

Source tarballs match upstream (sha1sum):
a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz
a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz.srpm

Final provides / requires are sane:

====> rpmlint perl-Package-Stash.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

======> perl-Package-Stash-0.03-1.fc14.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(Package::Stash) = 0.03
perl-Package-Stash = 0.03-1.fc14
====> requires
perl(:MODULE_COMPAT_5.10.1)  
perl(Carp)  
perl(Scalar::Util)  
perl(strict)  
perl(warnings)  
====> obsoletes
====> conflicts

======> perl-Package-Stash-0.03-1.fc14.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(ExtUtils::MakeMaker)  
perl(Pod::Coverage::TrustPod)  
perl(Scalar::Util)  
perl(Test::Exception)  
perl(Test::More)  
perl(Test::Pod)  
perl(Test::Pod::Coverage)  
====> obsoletes
====> conflicts

APPROVED
Comment 3 Paul Howarth 2010-06-12 10:10:44 UTC 
New Package CVS Request
=======================
Package Name: perl-Package-Stash
Short Description: Routines for manipulating stashes
Owners: pghmcfc
Branches: EL-4 EL-5 EL-6 F-12 F-13
InitialCC: perl-sig
Comment 4 Kevin Fenzi 2010-06-14 04:47:01 UTC 
CVS done (by process-cvs-requests.py).
Comment 5 Fedora Update System 2010-06-14 08:43:03 UTC 
perl-Package-Stash-0.03-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc13
Comment 6 Fedora Update System 2010-06-14 08:44:24 UTC 
perl-Package-Stash-0.03-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc12
Comment 7 Fedora Update System 2010-06-14 08:45:48 UTC 
perl-Package-Stash-0.03-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el5
Comment 8 Fedora Update System 2010-06-14 08:45:53 UTC 
perl-Package-Stash-0.03-1.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el4
Comment 9 Paul Howarth 2010-06-14 08:47:42 UTC 
Built successfully on all branches, including dist-rawhide and dist-f14-perltest tags for devel.
Comment 10 Fedora Update System 2010-06-14 17:19:23 UTC 
perl-Package-Stash-0.03-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2010-06-14 17:22:59 UTC 
perl-Package-Stash-0.03-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2010-06-30 14:21:06 UTC 
perl-Package-Stash-0.03-1.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 13 Fedora Update System 2010-06-30 14:24:46 UTC 
perl-Package-Stash-0.03-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.