Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 606205 (halberd) - Review Request: halberd - Tool to discover HTTP load balancers
Summary: Review Request: halberd - Tool to discover HTTP load balancers
Keywords:
Status: CLOSED NEXTRELEASE
Alias: halberd
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rafael Aquini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-SECLAB
TreeView+ depends on / blocked
 
Reported: 2010-06-21 05:54 UTC by Fabian Affolter
Modified: 2014-09-23 12:11 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-01 10:25:30 UTC
Type: ---
Embargoed:
aquini: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Fabian Affolter 2010-06-21 05:54:05 UTC 
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/halberd.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/halberd-0.2.3-2.fc14.src.rpm

Project URL: http://halberd.superadditive.com

Description:
Halberd discovers HTTP load balancers. It is useful for web application
security auditing and for load balancer configuration testing.

This is a review request for an orphaned package.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2260381

rpmlint output:
[fab@laptop011 SRPMS]$ rpmlint halberd-0.2.3-2.fc13.src.rpm 
halberd.src: W: spelling-error Summary(en_US) balancers -> balances, balance's, balance rs
halberd.src: W: spelling-error %description -l en_US balancers -> balances, balance's, balance rs
halberd.src: W: spelling-error %description -l en_US balancer -> balance, balances, balanced
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

[fab@laptop011 noarch]$ rpmlint halberd-0.2.3-2.fc13.noarch.rpm
halberd.noarch: W: spelling-error Summary(en_US) balancers -> balances, balance's, balance rs
halberd.noarch: W: spelling-error %description -l en_US balancers -> balances, balance's, balance rs
halberd.noarch: W: spelling-error %description -l en_US balancer -> balance, balances, balanced
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Comment 1 Rafael Aquini 2010-08-07 16:06:51 UTC 
Fabian,

I can review this package, if you still interested in take it off from the orphanage.

Regards
Comment 2 Rafael Aquini 2010-08-07 17:51:33 UTC 
Good:
* The package is named halberd which follows upstream project name
* Spec file naming follows package naming
* License in spec and sources is GPLv2+ which is open source
* Spec is legible and American English
* http://halberd.superadditive.com/dist/halberd-0.2.3.tar.gz
* Source matches upstream
* No locale files
* No shared libraries
* No bundled libraries
* Not relocatable
* No directories created unowned
* No duplicate files
* Default permissions are set
* Package is code
* No large documentation
* No %doc files are used at runtime
* No header files
* Not a GUI application
* Does not own files or directories from other packages
* All filenames are utf8
* rpmlint is clean:
[aquini@optiplex ~]$ rpmlint rpmbuild/SPECS/halberd.spec rpmbuild/SRPMS/halberd-0.2.3-2.fc13.src.rpm rpmbuild/RPMS/noarch/halberd-0.2.3-2.fc13.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

* Builds in mock 
* Builsd in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2387255 

Needswork:
* Ask upstream a patch to fix the following deprecation warning, when halberd is executed:
[aquini@optiplex ~]$ halberd http://aquini.fedorapeople.org/
/usr/lib/python2.6/site-packages/Halberd/clues/Clue.py:33: DeprecationWarning: the sha module is deprecated; use the hashlib module instead
  from sha import new as hashfn
halberd 0.2.3 (18-Jul-2007)

INFO looking up host aquini.fedorapeople.org... 


Regards
Comment 3 Fabian Affolter 2010-08-14 09:42:44 UTC 
* Sat Aug 14 2010 Fabian Affolter <fabian> - 0.2.3-3
- Added patch to replace deprecated sha module

Here are the updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/halberd.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/halberd-0.2.3-3.fc13.src.rpm
Comment 4 Rafael Aquini 2010-08-14 22:29:20 UTC 
Fabian,

Your work in halberd is pretty fine, and I'm approving this package. However, I'd like ask you to consider the following suggestions before you commit halberd in git:

i. There is another deprecation warning, when you shoot halberd against an https URL. Sorry for this late report... I've just noticed it today. Please, ask upstream for another patch to fix that also:
   /usr/lib/python2.6/site-packages/Halberd/clientlib.py:330: DeprecationWarning: socket.ssl() is deprecated.  Use ssl.wrap_socket() instead.


ii. Consider include a comment to the patches in SPEC file, to inform the upstream's bugtracking number for them.


APPROVED
Comment 5 Fabian Affolter 2010-08-15 09:20:59 UTC 
Thanks for the review.

(In reply to comment #4)
> i. There is another deprecation warning, when you shoot halberd against an
> https URL. Sorry for this late report... I've just noticed it today. Please,
> ask upstream for another patch to fix that also:
>    /usr/lib/python2.6/site-packages/Halberd/clientlib.py:330:
> DeprecationWarning: socket.ssl() is deprecated.  Use ssl.wrap_socket() instead.

Upstream applied my patch and released 0.2.4 some hours ago.  I think that it would not be a problem to fix this issue upstream.

> ii. Consider include a comment to the patches in SPEC file, to inform the
> upstream's bugtracking number for them.

There is no upstream tracker.
Comment 6 Fabian Affolter 2010-08-15 09:53:29 UTC 
Update CVS Request
=======================

Owners: fab
Branches: F-12 F-13 F-13
Comment 7 Fabian Affolter 2010-08-15 09:54:06 UTC 
Branches: F-12 F-13 F-14
Comment 8 Kevin Fenzi 2010-08-16 00:15:10 UTC 
There already was a f12 branch. Added f13/f14. 

Note that you will probibly need to file a ticket with rel-eng to unblock it.
Comment 9 Fabian Affolter 2014-09-23 09:23:59 UTC 
Package Change Request
======================
Package Name: halberd
New Branches: el6 epel7
Owners: fab 
InitialCC:
Comment 10 Gwyn Ciesla 2014-09-23 12:11:51 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.