Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 613529 - spice doesn't build on PPC
Summary: spice doesn't build on PPC
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: spice
Version: 19
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Christophe Fergeau
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 811030 (view as bug list)
Depends On:
Blocks: 855301
TreeView+ depends on / blocked
 
Reported: 2010-07-12 07:28 UTC by Gerd Hoffmann
Modified: 2015-02-17 13:17 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-17 13:17:49 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to configure.ac (469 bytes, patch)
2012-09-07 13:00 UTC, Peter Robinson
no flags Details | Diff
Patch for spec (1.88 KB, patch)
2012-09-07 13:01 UTC, Peter Robinson
no flags Details | Diff

Description Gerd Hoffmann 2010-07-12 07:28:57 UTC
spice has a number of portability issues which prevent it from working on !x86 architectures:

 * x86 inline assembler.
 * little endian assumtions all over the place.

Additionally for the spice server:

 * assumes some 64bit arithmetic ops are atomic.

Comment 1 Gerd Hoffmann 2010-07-13 13:06:24 UTC
Assign to spice now that the package is created and exists as bugzilla component.

Comment 2 Bug Zapper 2010-07-30 12:31:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle.
Changing version to '14'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Peter Robinson 2011-06-11 13:48:14 UTC
Updating to rawhide as still a problem there. I wonder if something like orc could replace the asm for platform independence

Comment 4 Christophe Fergeau 2011-06-13 08:35:20 UTC
I made the x86 inline assembly in the spice module optional a while ago. But the other issues that Gert raised still remain (little-endian assumptions and atomic 64 bit ops assumptions).

Comment 5 Peter Robinson 2012-09-07 12:59:20 UTC
> the other issues that Gert raised still remain (little-endian assumptions
> and atomic 64 bit ops assumptions).

Neither of these are an issue for ARMv6+ as it supports atomics and little-endian.

Comment 6 Peter Robinson 2012-09-07 13:00:49 UTC
Created attachment 610711 [details]
Patch to configure.ac

The following patch enables it to build on ARM platforms that support atomics. Test build on on ARMv7.

Comment 7 Peter Robinson 2012-09-07 13:01:51 UTC
Created attachment 610712 [details]
Patch for spec

This patch adds support for building on supported ARM platforms and has a few minor cleanups too

Comment 8 Peter Robinson 2012-09-07 13:05:15 UTC
The above two patches applied I tried the build on armv7hl and tested the resulting binary on an ARMv7 device running Fedora 18. Using firefox connecting to a RHEV-M instance I could launch consoles in spice-xpi and login so basic support works!

http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=1123736

I'm not 100% sure the ARM directive is efficient as it could be. Platforms < ARMv6 don't support atomics.

Comment 9 DaGeek 2012-09-11 11:58:41 UTC
can this also be tested/built on Fedora17 ?
So that it can become available in the update repos before Fedora18 GA ?

Comment 10 Christophe Fergeau 2012-09-11 14:34:46 UTC
Patch is upstream http://cgit.freedesktop.org/spice/spice/commit/?id=07426f3c4ff05540263d8f27f92b3a5676e27f96 now

Comment 11 Hans de Goede 2012-09-28 09:14:07 UTC
(In reply to comment #7)
> Created attachment 610712 [details]
> Patch for spec
> 
> This patch adds support for building on supported ARM platforms and has a
> few minor cleanups too

I'm in the process of updating the Fedora spice packages to 0.12.0, which have the necessary
configure changes. I've added armv6l armv7l armv7hl to the arch whitelist for this version.

Comment 12 Peter Robinson 2012-09-30 07:18:51 UTC
This is now built for ARM on F-18. I need to tweak the ARM side so we can build on ARMv6 and hence possibly run it on Raspberry Pi and other ARMv6 class devices. 

Not sure if you want to keep this open so PPC can deal with their issues (if it will ever work there).

Comment 13 Hans de Goede 2012-09-30 09:18:56 UTC
(In reply to comment #12)
> Not sure if you want to keep this open so PPC can deal with their issues (if
> it will ever work there).

Yes the plan is to keep this open until all use of ExclusiveArch is gone.

Comment 14 Fedora Admin XMLRPC Client 2012-10-15 06:12:23 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 15 Cole Robinson 2012-10-21 19:08:03 UTC
*** Bug 811030 has been marked as a duplicate of this bug. ***

Comment 16 Fedora End Of Life 2013-04-03 18:36:28 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 17 Cole Robinson 2013-06-19 13:51:53 UTC
Realistically, are the rest of these issues fixable any time soon? KVM on PPC is getting a decent amount of attention now, as is Fedora PPC. We are going to have to switch virt-manager away from noarch just to handle the spice dep where it isn't available.

Comment 18 Christophe Fergeau 2013-06-19 15:32:03 UTC
There were some ppc patches on the list a while back, but they were never merged :( And this would need to be tested thoroughly...

Comment 19 Cole Robinson 2013-06-19 15:33:34 UTC
Whoops, I was wrong about the virt-manager noarch thing, since spice-gtk builds on all archs now.

Comment 20 Fedora Admin XMLRPC Client 2014-03-17 09:26:04 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 21 Fedora End Of Life 2015-01-09 16:16:33 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 22 Fedora End Of Life 2015-02-17 13:17:49 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.