Spec URL: http://people.redhat.com/~kwright/dogtag-pki-theme/dogtag-pki-theme.spec
SRPM URL: http://people.redhat.com/~kwright/dogtag-pki-theme/dogtag-pki-theme-9.0.0-1.fc13.src.rpm

1) Package failed to build as its missing BR: java
2) some packages owns /usr/share/pki and some not. But i think its already owned by pki-setup now.
3) Add following in %install
chmod 755 %{buildroot}%{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl

and remove from %files of dogtag-pki-tps-theme
%attr(00755,root,root) %{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl

This will make sure, duplicate files warning will not come in build.log

(In reply to comment #2)
> 1) Package failed to build as its missing BR: java
> 2) some packages owns /usr/share/pki and some not. But i think its already
> owned by pki-setup now.
> 3) Add following in %install
> chmod 755 %{buildroot}%{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl
> 
> and remove from %files of dogtag-pki-tps-theme
> %attr(00755,root,root) %{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl
> 
> This will make sure, duplicate files warning will not come in build.log

Updated SPEC and SRPM specified below address comments 1) and 3):

Spec URL:
http://mharmsen.fedorapeople.org/dogtag-pki-theme.spec

SRPM URL:
http://mharmsen.fedorapeople.org/dogtag-pki-theme-9.0.0-2.fc12.src.rpm

In reference to comment 2), Dogtag consists of numerous subsystems which can be installed independently of each other.  As a consequence of this flexibility, several components may need to have ownership of the '/usr/share/pki' directory, as they may be the only component on a given system.  Where possible, we have tried to isolate this to the lowest common dependency (e. g. - 'pki-setup' is required by all six top-level Dogtag subsystems).  However, in the case of "theme" packages such as "dogtag-pki-theme", no package requires this at build time, and "theme" packages may be installed without requiring other Dogtag packages such as "pki-setup" (actually, packages such as 'pki-ca' require "pki-ca-theme" which is something provided by "theme" packages such as "dogtag-pki-ca-theme").

(In reply to comment #3)
> (In reply to comment #2)
> > 1) Package failed to build as its missing BR: java
> > 2) some packages owns /usr/share/pki and some not. But i think its already
> > owned by pki-setup now.
> > 3) Add following in %install
> > chmod 755 %{buildroot}%{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl
> > 
> > and remove from %files of dogtag-pki-tps-theme
> > %attr(00755,root,root) %{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl
> > 
> > This will make sure, duplicate files warning will not come in build.log
> 
> Updated SPEC and SRPM specified below address comments 1) and 3):
> 
> Spec URL:
> http://mharmsen.fedorapeople.org/dogtag-pki-theme.spec
> 
> SRPM URL:
> http://mharmsen.fedorapeople.org/dogtag-pki-theme-9.0.0-2.fc12.src.rpm
> 
> In reference to comment 2), Dogtag consists of numerous subsystems which can be
> installed independently of each other.  As a consequence of this flexibility,
> several components may need to have ownership of the '/usr/share/pki'
> directory, as they may be the only component on a given system.  Where
> possible, we have tried to isolate this to the lowest common dependency (e. g.
> - 'pki-setup' is required by all six top-level Dogtag subsystems).  However, in
> the case of "theme" packages such as "dogtag-pki-theme", no package requires
> this at build time, and "theme" packages may be installed without requiring
> other Dogtag packages such as "pki-setup" (actually, packages such as 'pki-ca'
> require "pki-ca-theme" which is something provided by "theme" packages such as
> "dogtag-pki-ca-theme").

In that case, I think other subpackages  dogtag-pki-tks-theme, dogtag-pki-ocsp-theme, dogtag-pki-kra-theme, dogtag-pki-ca-theme should also own '/usr/share/pki'

Good to add comment somewhere in spec about directory ownership.

(In reply to comment #4) 
> In that case, I think other subpackages  dogtag-pki-tks-theme,
> dogtag-pki-ocsp-theme, dogtag-pki-kra-theme, dogtag-pki-ca-theme should also
> own '/usr/share/pki'
> 

These four packages all require "dogtag-pki-common-theme", and so for these four packages we simply provide ownership of "/usr/share/pki" to "dogtag-pki-common-theme". 

> Good to add comment somewhere in spec about directory ownership.

Added comment in newly attached spec file:

Spec URL:
http://mharmsen.fedorapeople.org/dogtag-pki-theme.spec

SRPM URL:
http://mharmsen.fedorapeople.org/dogtag-pki-theme-9.0.0-3.fc12.src.rpm


Additionally, on-going development required me to add the following (all referenced in the latest changelog):

    * Augmented overview description.
    * Isolated and corrected EPEL information
    * fixed two additional bugs (source tarball was recreated)

P. S. - Although the source tarball was altered, the original tarball was simply disposed of because we do not yet have an official package.  Once an "official" package exists, all of the source tarballs will only be modified via external stand-alone "patch" files or recreated with a different version name once they become "official".

Thanks for the nice update. I am still on vacation for next few days. But I will not make this package to wait.
APPROVED.

New Package CVS Request
=======================
Package Name: dogtag-pki-theme
Short Description: Certificate System - Dogtag PKI Theme Components
Owners: kwright
Branches: F-13, F-14, EL-5
InitialCC: ausil

Git done (by process-git-requests).

Can this review be closed now?

(In reply to comment #9)
> Can this review be closed now?

Yes

closing