Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 678910 (activitymanager) - Review Request: kde-plasma-activitymanager - KDE plasma activity manager applet
Summary: Review Request: kde-plasma-activitymanager - KDE plasma activity manager applet
Keywords:
Status: CLOSED ERRATA
Alias: activitymanager
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-02-20 18:17 UTC by Magnus Tuominen
Modified: 2011-06-02 18:54 UTC (History)
5 users (show)

Fixed In Version: kde-plasma-activitymanager-0.5-2.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-24 18:12:45 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)

Description Magnus Tuominen 2011-02-20 18:17:02 UTC 
Spec URL: http://magnu5.fedorapeople.org/review/activitymanager/SPECS/activitymanager.spec
SRPM URL: http://magnu5.fedorapeople.org/review/activitymanager/SRPMS/activitymanager-0.5-1.fc14.src.rpm
Description: Lightweight plasmoid to manage your activities effectively.
Can start, stop, switch between, clone, edit and remove activities.

rpmlint -iv activitymanager.spec 
activitymanager.spec: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

rpmlint -iv activitymanager-0.5-1.fc14.src.rpm 
activitymanager.src: I: checking
activitymanager.src: W: spelling-error %description -l en_US plasmoid -> plasmid, plasmodium, plasmolytic
The value of this tag appears to be misspelled. Please double-check.

activitymanager.src: I: checking-url http://kde-apps.org/content/show.php?content=136278 (timeout 10 seconds)
activitymanager.src: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Comment 1 nucleo 2011-02-20 23:12:02 UTC 
kde-plasma- prefix used by convention for all plasma applets
So kde-plasma-activitymanager will be more more correct name.

No need to run desktop-file-validate for files in %{_datadir}/kde4/services/

%{buildroot} and $RPM_BUILD_ROOT should not be mixed in one spec.

Why you added explicit Requires: kdebase-workspace ?
Comment 2 Magnus Tuominen 2011-02-21 05:14:51 UTC 
Thanks for the comments, fixed build and spec:

BR changed to kdeplasma-addons-devel and Requires removed.

http://magnu5.fedorapeople.org/review/kde-plasma-activitymanager/SPECS/kde-plasma-activitymanager.spec

http://magnu5.fedorapeople.org/review/kde-plasma-activitymanager/SRPMS/kde-plasma-activitymanager-0.5-2.fc14.src.rpm

rpmlint -iv kde-plasma-activitymanager.spec 
kde-plasma-activitymanager.spec: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

rpmlint -iv kde-plasma-activitymanager-0.5-2.fc14.src.rpm 
kde-plasma-activitymanager.src: I: checking
kde-plasma-activitymanager.src: W: spelling-error %description -l en_US plasmoid -> plasmid, plasmodium, plasmolytic
The value of this tag appears to be misspelled. Please double-check.

kde-plasma-activitymanager.src: I: checking-url http://kde-apps.org/content/show.php?content=136278 (timeout 10 seconds)
kde-plasma-activitymanager.src: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Comment 3 Rex Dieter 2011-05-20 15:45:50 UTC 
naming: ok

sources: ok
$ md5sum *.bz2
7592bf60fafcb465fe75cd987a037ffc  136278-activitymanager-0.5.tar.bz2

builds/installs: ok

licensing: ok , though looking through the sources looks like GPLv2+

scriptlets: n/a

Otherwise fairly small and simple, looks good.


APPROVED.
Comment 4 Magnus Tuominen 2011-05-21 11:08:12 UTC 
New Package SCM Request
=======================
Package Name: kde-plasma-activitymanager
Short Description: KDE plasma activity manager applet
Owners: magnu5
Branches: f14 f15 devel
InitialCC:
Comment 5 Jason Tibbitts 2011-05-23 17:41:17 UTC 
Git done (by process-git-requests).
Comment 6 Fedora Update System 2011-05-24 18:14:47 UTC 
kde-plasma-activitymanager-0.5-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/kde-plasma-activitymanager-0.5-2.fc14
Comment 7 Fedora Update System 2011-05-24 18:15:45 UTC 
kde-plasma-activitymanager-0.5-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/kde-plasma-activitymanager-0.5-2.fc15
Comment 8 Fedora Update System 2011-05-30 22:32:22 UTC 
kde-plasma-activitymanager-0.5-2.fc15 has been pushed to the Fedora 15 stable repository.
Comment 9 Fedora Update System 2011-06-02 10:58:38 UTC 
kde-plasma-activitymanager-0.5-2.fc14 has been pushed to the Fedora 14 stable repository.
Comment 10 Fedora Update System 2011-06-02 18:54:50 UTC 
kde-plasma-activitymanager-0.5-2.fc14 has been pushed to the Fedora 14 stable repository.
Note You need to log in before you can comment on or make changes to this bug.