This combination looks out of place:

BuildRequires:  kdelibs >= 4 ...
BuildRequires:  qt3, kdelibs-devel

You want kde *4*, but also qt 3?

if it's really a kde4 app, all you really need is:

BuildRequires: kdelibs4-devel

updated
Spec URL: http://hpejakle.fedorapeople.org/packages/kflickr.spec
SRPM URL:
http://hpejakle.fedorapeople.org/packages/kflickr-20100817-2.fc14.src.rpm

Not a full review (and I'm not taking this for now, but)...

rpmlint complains with:
kflickr.x86_64: E: explicit-lib-dependency kdebase-runtime-libs

The rpm build system will pick up library dependencies correctly and therefore the explicit lib dependency should be removed.  

Otherwise, most everything else seems good.

it will not pickup this dependency automatically therefore it is explicit. I have already tried it before submitting this review request.

I built the package in koji (scratch build, see link below) earlier today with the explicit dependency removed.  I can confirm that although kdebase-runtime-libs are not picked up, other kde libs are and furthermore, on a machine I have removed kdebase-runtime-libs (with yum remove kdebase-runtime-libs), installed the rpm from the scratch build, and successfully run kflickr (including registering a new account, selecting a photo, and uploading that photo to flickr).  Unless I'm missing something, kflickr does not require kdebase-runtime-libs.  

http://koji.fedoraproject.org/koji/taskinfo?taskID=2950562

(In reply to comment #5)
> I built the package in koji (scratch build, see link below) earlier today with
> the explicit dependency removed.  I can confirm that although
> kdebase-runtime-libs are not picked up, other kde libs are and furthermore, on
> a machine I have removed kdebase-runtime-libs (with yum remove
> kdebase-runtime-libs), installed the rpm from the scratch build, and
> successfully run kflickr (including registering a new account, selecting a
> photo, and uploading that photo to flickr).  Unless I'm missing something,
> kflickr does not require kdebase-runtime-libs.  
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2950562

Wait, I see, after further testing (kdebase-runtime-libs is re-installed on the machine), the thumbnail works correctly (I assumed in the previous case that the image I had choosen was too large to by default create a thumbnail).  If this is true, it is very strange that such a dependency isn't properly picked up.

What's needed for the thumbnailing is probably a plugin, not a hard, directly linked dependency.

I can review.

Sorry for the delay.

1.  SHOULD: take a look at a template for advice, like,
http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices
and take advantage of some %_kde4_* macros we have.

2.  MUST: use
Requires: kdebase-runtime%{?_kde4_version: >= %{_kde4_version}}
(instead of -libs)

the stuff at the end just adds some extra versioning information, to ensure the built rpm is run against at least the kde version used to build it.

3.  MUST: fix icon scriptlets, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

4.  SHOULD: drop the convoluted locale handling, and just use something like
%find_lang %{name} --with-kde

Naming OK

License ok

sources ok
a242994345de077c2a4bd07968cc217a  kflickr-20100817.tar.bz2

1,2,3,4 - fixed

Spec URL: http://hpejakle.fedorapeople.org/packages/kflickr.spec
SRPM URL:
http://hpejakle.fedorapeople.org/packages/kflickr-20100817-3.fc15.src.rpm

Looks good, thanks!   APPROVED.

New Package CVS Request
=======================
Package Name: kflickr
Short Description: Standalone Flickr Uploader
Owners: hpejakle
Branches: F-14 F-15 F-16
InitialCC:

Unretired devel and f14, please take ownership, then submit a change request
for f15 and f16 branches.  There are also el5 and el6 branches orphaned, if
you want them.

Package Change Request
======================
Package Name: kflickr
New Branches: F-15 F-16
Owners: hpejakle
InitialCC:

Git done (by process-git-requests).

Err... ping Jan, I don't see this ever got imported.  Was there a problem or something I can help with?

nevermind, it was imported and built, but only for rawhide/f17.  so, we can close this.

I'd love a f16 build though... :)