Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 724991 - Review Request: smokegen - Smoke Generator
Summary: Review Request: smokegen - Smoke Generator
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-07-22 14:20 UTC by Than Ngo
Modified: 2011-07-27 15:22 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-27 15:22:08 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Than Ngo 2011-07-22 14:20:05 UTC 
Spec URL: http://than.fedorapeople.org/rawhide/smokegen.spec
SRPM URL:
http://rdieter.fedorapeople.org/rawhide/smokegen-4.6.95-1.fc15.src.rpm
Description: Smoke Generator

Split packaging for smokegen.
Comment 1 Than Ngo 2011-07-22 14:20:50 UTC 
Spec URL: http://than.fedorapeople.org/rawhide/smokegen.spec
SRPM URL:
http://than.fedorapeople.org/rawhide/smokegen-4.6.95-1.fc15.src.rpm
Description: Smoke Generator

Split packaging for smokegen.
Comment 2 Jaroslav Reznik 2011-07-22 15:22:48 UTC 
Name: ok, matches upstream
Summary: ok
Group: ok, but not needed anymore
License: not ok, LGPLv2 and GPLv2+ (according to discussion with Rex - legal wants us to list all licenses included in tarball)
Url: not ok, redirects to Techbase and no article can be found there
Source: ok (md5sum dd8dc0f9fb8e2fe5294075855be524a4)
Obsoletes/Provides: ok?, smokegen was part of kdebindings (can all smoke* related packages provide kdebindigs?)
Description: could be, I'd like to provide more information there, not a blocker
Ldconfig: ok
Docs: ok, just ping upstream for proper COPYING

Shouldn't we have smokegen-devel? The same way as original kdebindings had it?

Group, BuildRoot, clean section, defattrs not needed anymore

rpmlint
rpmlint smokegen-4.6.95-1.fc15.src.rpm 
smokegen.src: W: invalid-url URL: http://developer.kde.org/language-bindings/ HTTP Error 404: Not Found

> fix pls

smokegen.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.95/src/smokegen-4.6.95.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

> ok, we will have stable soon
Comment 3 Than Ngo 2011-07-26 15:49:12 UTC 
new smokegen-4.7.0-1.fc15.src.rpm is uploaded on  http://than.fedorapeople.org/rawhide/

it should fix above issues.

>Group, BuildRoot, clean section, defattrs not needed anymore
we want to keep it in case we want to build for old release.
Comment 4 Jaroslav Reznik 2011-07-27 10:46:42 UTC 
Thanks Than.

rpmlint smokegen-4.7.0-1.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Seems clean, just fix formatting a little bit, not a blocker for review.

APPROVED
Comment 5 Than Ngo 2011-07-27 12:46:24 UTC 
Thanks!

New Package SCM Request
=======================
Package Name: smokegen
Short Description: Smoke Generator
Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix
Branches: f15 f16
Comment 6 Gwyn Ciesla 2011-07-27 13:37:52 UTC 
Git done (by process-git-requests).
Comment 7 Than Ngo 2011-07-27 15:22:08 UTC 
imported and built http://koji.fedoraproject.org/koji/taskinfo?taskID=3233996
Note You need to log in before you can comment on or make changes to this bug.