Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 725483 - keyutils-1.5.1-1.fc16 fails to build on s390
Summary: keyutils-1.5.1-1.fc16 fails to build on s390
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: keyutils
Version: rawhide
Hardware: s390
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David Howells
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker
TreeView+ depends on / blocked
 
Reported: 2011-07-25 15:30 UTC by Dan Horák
Modified: 2011-08-22 11:49 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-22 11:49:09 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
proposed fix (869 bytes, application/octet-stream)
2011-07-25 15:30 UTC, Dan Horák 		no flags Details
View All

Description Dan Horák 2011-07-25 15:30:21 UTC 
Created attachment 515099 [details]
proposed fix

keyutils-1.5.1-1.fc16 fails to build on s390 (32bit) because of a combination -Werror and size_t being defined as unsigned long, please see build.log at
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=432645
Comment 1 David Howells 2011-07-25 15:50:16 UTC 
request-key.c: In function 'execute_program':
request-key.c:583:4: error: format '%zd' expects argument of type 'signed size_t', but argument 2 has type 'int' [-Werror=format]
request-key.c: In function 'pipe_to_program':
request-key.c:841:2: error: format '%zd' expects argument of type 'signed size_t', but argument 2 has type 'int' [-Werror=format]
c

That's the result of a pointer subtraction.  I wonder if it behaves differently on S390 to other arches as the pointer size (31 bits) is not the same as the size of long/size_t (32 bits).
Comment 2 David Howells 2011-07-25 15:52:25 UTC 
I should probably be using the 't' modifier rather than the 'z' modifier to "%d" in the printf arguments for this.
Comment 3 Dan Horák 2011-07-25 16:08:33 UTC 
Ha, the 't' modifier seems to do the trick.
Comment 4 David Howells 2011-07-26 10:00:36 UTC 
I've checked in my suggested change.
Comment 5 David Howells 2011-08-15 14:26:45 UTC 
Did that fix it for you?
Comment 6 Dan Horák 2011-08-15 14:35:13 UTC 
yes, keyutils-1.5.2-1.fc16 builds fine on Fedora/s390x (http://s390.koji.fedoraproject.org/koji/buildinfo?buildID=73846)
Note You need to log in before you can comment on or make changes to this bug.