Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 730331 - Review Request:telepathy-kde-send-file - A File manager plugin to launch a file transfer job with a specified contact
Summary: Review Request:telepathy-kde-send-file - A File manager plugin to launch a fi...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: telepathy-qt4
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-08-12 13:59 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-18 17:42:31 UTC
Type: ---
Embargoed:
rnovacek: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2011-08-12 13:59:24 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-send-file.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-send-file-0.1.0-1.fc14.src.rpm
Description: A File manager plugin to launch a file transfer job with a specified contact
Comment 1 Radek Novacek 2011-09-13 07:58:59 UTC 
Name: ok
License: wrong, spec says GPLv2+, source is LGPLv2+
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/telepathy-kde-send-file_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/telepathy-kde-send-file_%{version}.tar.bz2
BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: not needed
Desktop file validations: not needed
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint:
telepathy-kde-send-file.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)
telepathy-kde-send-file.x86_64: W: no-manual-page-for-binary telepathy-kde-send-file
telepathy-kde-send-file.x86_64: E: invalid-desktopfile /usr/share/applications/kde4/telepathy-kde-send-file.desktop (will be fatal in the future): value "all/allfiles;" for key "MimeType" in group "Desktop Entry" contains value "all/allfiles" which is an invalid MIME type: "all" is an unregistered media type
telepathy-kde-send-file.x86_64: E: invalid-desktopfile /usr/share/applications/kde4/telepathy-kde-send-file.desktop required key "Name" in group "Desktop Entry" is not present
telepathy-kde-send-file.x86_64: E: invalid-desktopfile /usr/share/applications/kde4/telepathy-kde-send-file.desktop key "MimeType" is present in group "Desktop Entry", but the type is "Service" while this key is only valid for type "Application"
Comment 2 Rex Dieter 2011-09-15 14:13:58 UTC 
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-send-file.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-send-file-0.1.0-2.fc15.src.rpm

%changelog
* Thu Sep 15 2011 Rex Dieter <rdieter> 0.1.0-2
- fix Source0 URL
- fix tabs/spaces
- License: LGPLv2+
Comment 3 Radek Novacek 2011-09-16 06:21:51 UTC 
Thanks for fixing the issues, setting fedora-review+.
Comment 4 Rex Dieter 2011-09-16 14:37:27 UTC 
New Package SCM Request
=======================
Package Name: telepathy-kde-send-file
Short Description: A File manager plugin to launch a file transfer job with a specified contact
Owners: jreznik rdieter
Branches: f15 f16
Comment 5 Gwyn Ciesla 2011-09-17 02:01:16 UTC 
Git done (by process-git-requests).
Comment 6 Rex Dieter 2011-09-18 17:42:31 UTC 
imported.
Note You need to log in before you can comment on or make changes to this bug.