Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 735146 (kstars) - Review Request: kstars - Desktop Planetarium
Summary: Review Request: kstars - Desktop Planetarium
Keywords:
Status: CLOSED RAWHIDE
Alias: kstars
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: libkdeedu
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-09-01 15:32 UTC by Rex Dieter
Modified: 2011-09-25 18:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-25 18:58:35 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2011-09-01 15:32:18 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeedu/kstars.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeedu/kstars-4.7.0-10.fc15.src.rpm
Description: Desktop Planetarium
Comment 1 nucleo 2011-09-19 15:46:13 UTC 
Should xplanet be installed with kstars or it needed only at build time?
This bug depends on libkdeedu but looks like kstars not needs it?
Comment 2 nucleo 2011-09-19 15:48:58 UTC 
There are many desktop-file-validate warnings http://pastebin.com/raw.php?i=SF2yQR56
Is it safe to ignore all of them?
Comment 3 Rex Dieter 2011-09-19 15:58:51 UTC 
imo, let's try to limit ourselves to review blockers (another nice-to-haves can certainly be addressed post-review).

that said,
re: xplanet  , as I understand it, it's an optional feature that's only enabled if xplanet is present during build.  so, we could add a runtime dep too, if you insist, but I don't think it's needed for normal operation.

re: desktop-validate warnings.  those look mostly harmless to me
Comment 4 nucleo 2011-09-20 20:32:13 UTC 
Most of code is GPLv2+ but kstars/htmesh/* have LICENSE with dual licenses: modified-BSD, and GPLv2+.
Comment 5 nucleo 2011-09-20 20:45:49 UTC 
Kstars statically linked with htmesh so resulting License tag will be GPLv2+?
Comment 6 nucleo 2011-09-21 16:34:55 UTC 
rpmlint output:
$ rpmlint kstars-4.7.1-1.fc17.i686.rpm kstars-debuginfo-4.7.1-1.fc17.i686.rpm kstars-4.7.1-1.fc17.x86_64.rpm kstars-debuginfo-4.7.1-1.fc17.x86_64.rpm kstars-4.7.1-1.fc17.src.rpm 
kstars.i686: W: obsolete-not-provided kdeedu-kstars-libs
kstars.i686: E: script-without-shebang /usr/share/applications/kde4/kstars.desktop
kstars.i686: W: no-manual-page-for-binary kstars
kstars.x86_64: W: obsolete-not-provided kdeedu-kstars-libs
kstars.x86_64: E: script-without-shebang /usr/share/applications/kde4/kstars.desktop
kstars.x86_64: W: no-manual-page-for-binary kstars
5 packages and 0 specfiles checked; 2 errors, 4 warnings.

kstars.desktop is not script so this error can be ignored, no manual page available in sources.

Builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=3360699 - OK

Name: kstars - OK
Summary: Desktop Planetarium - OK
License: GPLv2+ - OK, license file in %doc
URL: https://projects.kde.org/projects/kde/kdeedu/kstars is OK but http://edu.kde.org/kstars/ will be more informative.
Source: md5sum: fe243613d628e28371ea4986f2312d70  kstars-4.7.1.tar.bz2 -OK
Build dependencies listed in BuildRequires - OK
Macros used consistently: OK
Icon cache: OK
Desktop file validations: (harmless warnings) - OK
Package own all directories that it creates: %{_kde4_appsdir}/kstars/ - OK
Comment 7 nucleo 2011-09-21 16:37:12 UTC 
So package is good and  APPROVED,

and nice to have this URL http://edu.kde.org/kstars/
Comment 8 nucleo 2011-09-21 16:41:06 UTC 
and also nice to have Description from http://edu.kde.org/kstars/
Comment 9 Rex Dieter 2011-09-21 18:03:41 UTC 
New Package SCM Request
=======================
Package Name: kstars
Short Description: Desktop Planetarium
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16
Comment 10 Gwyn Ciesla 2011-09-24 15:45:47 UTC 
Git done (by process-git-requests).
Comment 11 Rex Dieter 2011-09-25 18:58:35 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.