Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 735152 (step) - Review Request: step - Interactive Physics Simulator
Summary: Review Request: step - Interactive Physics Simulator
Keywords:
Status: CLOSED RAWHIDE
Alias: step
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: libkdeedu
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-09-01 15:38 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-25 19:08:13 UTC
Type: ---
Embargoed:
rnovacek: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2011-09-01 15:38:02 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeedu/step.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeedu/step-4.7.0-10.fc15.src.rpm
Description: Interactive Physics Simulator
Comment 1 Clément DAVID 2011-09-18 14:01:14 UTC 
For me some points to be solved before a more formal review:
 * typo on "Release: 10%{?dist}" for a first try :)
 * is it standard to use desktop-file-validate on %check ? (I use it on %build)

koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3358761

Problems:

+ desktop-file-validate /builddir/build/BUILDROOT/step-4.7.0-10.fc16.i386/usr/share/applications/kde4/step.desktop
/builddir/build/BUILDROOT/step-4.7.0-10.fc16.i386/usr/share/applications/kde4/step.desktop: error: (will be fatal in the future): value "Physics" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education;Science

warning: File listed twice: /usr/share/doc/HTML/en/step
Comment 2 Rex Dieter 2011-09-18 18:07:50 UTC 
I personally prefer using desktop-file-* in either %install or %check.

Anyway, as that is still (currently) non-fatal, let's not block the review on it (though I will poke upstream to get it fixed properly).
Comment 3 Rex Dieter 2011-09-22 11:53:36 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeedu/step.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdeedu/step-4.7.1-2.fc15.src.rpm

%changelog
* Wed Sep 21 2011 Rex Dieter <rdieter> 4.7.1-2
- License: GPLv2+

* Sat Sep 17 2011 Rex Dieter <rdieter> 4.7.1-1
- 4.7.1
Comment 4 Radek Novacek 2011-09-23 07:29:57 UTC 
Clément, are you going to do formal review?
Comment 5 Clément DAVID 2011-09-23 12:59:48 UTC 
(In reply to comment #4)
> Clément, are you going to do formal review?

Feel free to take, I'm off for 3 days.
Comment 6 Radek Novacek 2011-09-23 13:49:48 UTC 
Name: ok
License: ok
Source: ok
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: NA
Desktop file validations: ok
Locales: ok
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint: no need to fix
step.x86_64: E: script-without-shebang /usr/share/applications/kde4/step.desktop
step.x86_64: W: no-manual-page-for-binary step

No issues found, setting fedora-review+.
Comment 7 Rex Dieter 2011-09-23 15:23:09 UTC 
New Package SCM Request
=======================
Package Name: step
Short Description: Interactive Physics Simulator
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16
Comment 8 Gwyn Ciesla 2011-09-24 15:49:27 UTC 
Git done (by process-git-requests).
Comment 9 Rex Dieter 2011-09-25 19:08:13 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.