Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 740458 - Review Request: drupal7-auto_nodetitle - A small and efficient module that allows hiding of the content title
Summary: Review Request: drupal7-auto_nodetitle - A small and efficient module that al...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: InsightReviews
TreeView+ depends on / blocked
 
Reported: 2011-09-22 06:21 UTC by Peter Borsa
Modified: 2011-10-27 19:10 UTC (History)
3 users (show)

Fixed In Version: drupal7-auto_nodetitle-1.0-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-04 19:01:40 UTC
Type: ---
Embargoed:
gwync: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Peter Borsa 2011-09-22 06:21:56 UTC
Spec URL: http://asrob.fedorapeople.org/SOURCES/drupal7-auto_nodetitle.spec
SRPM URL: http://asrob.fedorapeople.org/SOURCES/drupal7-auto_nodetitle-1.0-1.fc15.src.rpm
Description: This is a small and efficient module
that allows hiding of the content title field in the form.
To prevent empty content title fields one can configure it
to generate the title by a given pattern.
When the token module is installed
it's possible to use various node data for the
auto generated title - e.g. use the text of a CCK field (since 5.x).
Advanced users can also provide some PHP code,
that is used for automatically generating an appropriate title.


rpmlint output:

$ rpmlint drupal7-auto_nodetitle.spec ../SRPMS/drupal7-auto_nodetitle-1.0-1.fc15.src.rpm ../RPMS/noarch/drupal7-auto_nodetitle-1.0-1.fc15.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

koji output:

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=3369776
Watching tasks (this may be safely interrupted)...
3369776 build (dist-f15, drupal7-auto_nodetitle-1.0-1.fc15.src.rpm): open (x86-16.phx2.fedoraproject.org)
  3369777 buildArch (drupal7-auto_nodetitle-1.0-1.fc15.src.rpm, noarch): free
  3369777 buildArch (drupal7-auto_nodetitle-1.0-1.fc15.src.rpm, noarch): free -> open (x86-18.phx2.fedoraproject.org)
  3369777 buildArch (drupal7-auto_nodetitle-1.0-1.fc15.src.rpm, noarch): open (x86-18.phx2.fedoraproject.org) -> closed
  0 free  1 open  1 done  0 failed
3369776 build (dist-f15, drupal7-auto_nodetitle-1.0-1.fc15.src.rpm): open (x86-16.phx2.fedoraproject.org) -> closed
  0 free  0 open  2 done  0 failed

3369776 build (dist-f15, drupal7-auto_nodetitle-1.0-1.fc15.src.rpm) completed successfully

Comment 1 Gwyn Ciesla 2011-10-04 17:22:54 UTC
Good:

- rpmlint checks return:

<null>

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Awaiting mock rebuild to double-check BRs, otherwise good.

Comment 2 Gwyn Ciesla 2011-10-04 17:24:47 UTC
BRs are good, APPROVED.

Comment 3 Peter Borsa 2011-10-04 17:33:15 UTC
New Package SCM Request
=======================
Package Name: drupal7-auto_nodetitle
Short Description: A small and efficient module that allows hiding of the content title
Owners: asrob jsmith pfrields
Branches: f15 f16 el5 el6
InitialCC:

Comment 4 Gwyn Ciesla 2011-10-04 17:39:17 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2011-10-04 18:28:46 UTC
drupal7-auto_nodetitle-1.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/drupal7-auto_nodetitle-1.0-1.fc15

Comment 6 Fedora Update System 2011-10-04 18:37:13 UTC
drupal7-auto_nodetitle-1.0-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/drupal7-auto_nodetitle-1.0-1.fc16

Comment 7 Fedora Update System 2011-10-04 18:44:28 UTC
drupal7-auto_nodetitle-1.0-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/drupal7-auto_nodetitle-1.0-1.el5

Comment 8 Fedora Update System 2011-10-04 18:54:30 UTC
drupal7-auto_nodetitle-1.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal7-auto_nodetitle-1.0-1.el6

Comment 9 Fedora Update System 2011-10-13 23:53:21 UTC
drupal7-auto_nodetitle-1.0-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 10 Fedora Update System 2011-10-16 00:57:03 UTC
drupal7-auto_nodetitle-1.0-1.fc16 has been pushed to the Fedora 16 stable repository.

Comment 11 Fedora Update System 2011-10-27 19:07:04 UTC
drupal7-auto_nodetitle-1.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 12 Fedora Update System 2011-10-27 19:10:37 UTC
drupal7-auto_nodetitle-1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.