Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 740562 - Review Request: telepathy-kde-presence-applet - Plasma applet for managing your Telepathy account presence
Summary: Review Request: telepathy-kde-presence-applet - Plasma applet for managing yo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Radek Novacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 730328 (view as bug list)
Depends On: telepathy-qt4 740561
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-09-22 13:20 UTC by Rex Dieter
Modified: 2016-12-01 00:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-26 14:37:15 UTC
Type: ---
Embargoed:
rnovacek: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2011-09-22 13:20:39 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet-0.1.0-1.fc14.src.rpm
Description: Plasma applet for managing your Telepathy account presence
Comment 1 Radek Novacek 2011-09-23 07:45:25 UTC 
Name: ok
License: ok
Source: wrong, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: NA
Desktop file validations: NA
Locales: NA
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint: please fix
./telepathy-kde-presence-applet.spec:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)
Comment 2 Rex Dieter 2011-09-23 15:24:24 UTC 
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet-0.1.0-2.fc15.src.rpm


%changelog
* Fri Sep 23 2011 Rex Dieter <rdieter> 0.1.0-2
- fix Source0 URL
- fix spaces/tabs
Comment 3 Kevin Kofler 2011-09-25 21:54:54 UTC 
*** Bug 730328 has been marked as a duplicate of this bug. ***
Comment 4 Radek Novacek 2011-09-26 06:42:01 UTC 
Thanks for fixing the issues, setting fedora-review+.
Comment 5 Rex Dieter 2011-09-26 13:03:41 UTC 
New Package SCM Request
=======================
Package Name: telepathy-kde-presence-applet
Short Description: Plasma applet for managing your Telepathy account presence
Owners: jreznik rdieter
Branches: f15 f16
Comment 6 Gwyn Ciesla 2011-09-26 14:18:01 UTC 
Git done (by process-git-requests).
Comment 7 Rex Dieter 2011-09-26 14:37:15 UTC 
imported
Comment 8 Kevin Kofler 2011-09-26 23:34:11 UTC 
This requires a script engine which isn't in Fedora yet:
plasma4(scriptengine-declarativeapplet)
as found by my automatic dependency extractor.

The whole applet is written in QML, it won't work at all without a script engine for QML.
Comment 9 Kevin Kofler 2011-09-26 23:44:42 UTC 
What 4.7 has lists these properties instead:
X-EngineName=declarativeappletscript
X-Plasma-API=declarativeappletscript
X-KDE-PluginInfo-Name=qmlscript

Now I do think the depextractor does the wrong thing there (it prefers the X-KDE-PluginInfo-Name, but it should be using the X-Plasma-API here; that said, I think it's also broken for those properties to say different things), but still, neither of those match "declarativeapplet" which this is asking for.
Comment 10 Kevin Kofler 2011-09-27 00:54:16 UTC 
So it turns out that I got confused because the dependency was incorrectly hand-typed into IRC. The dependency as listed by http://koji.fedoraproject.org/koji/rpminfo?rpmID=2716469 is on plasma4(scriptengine-declarativeappletscript), which is correct. The problem is that the autoprov script gets confused because the .desktop file for the script engine has a name != the API for some stupid reason.

I need to fix the autoprov script to ignore the name and only pick the API for script engines.
Comment 11 Kevin Kofler 2011-09-27 01:23:29 UTC 
This chain build should fix the autoprov: http://koji.fedoraproject.org/koji/taskinfo?taskID=3380164
Comment 12 Kevin Kofler 2011-09-27 01:25:31 UTC 
FYI, this is the relevant kde-settings commit:
https://fedorahosted.org/kde-settings/changeset/294
Note You need to log in before you can comment on or make changes to this bug.