Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 757239 (kactivities) - Review Request: kactivities - API for using and interacting with Activities
Summary: Review Request: kactivities - API for using and interacting with Activities
Keywords:
Status: CLOSED RAWHIDE
Alias: kactivities
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kevin Kofler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-11-25 23:19 UTC by Rex Dieter
Modified: 2011-11-29 14:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-29 14:47:31 UTC
Type: ---
Embargoed:
kevin: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2011-11-25 23:19:30 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kactivities/kactivities.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kactivities/kactivities-4.7.80-1.fc16.src.rpm
Description: API for using and interacting with Activities

Package rename libkactivities -> kactivities mostly.
Comment 1 Kevin Kofler 2011-11-25 23:23:22 UTC 
I'm taking this review.

This has been reviewed and approved very recently in bug #749055, the only thing which has changed is the name (due to upstream).

The Obsoletes look correct, but shouldn't we add matching Provides? (rpmlint will complain otherwise, and I think it can't hurt.)
Comment 2 Kevin Kofler 2011-11-25 23:28:10 UTC 
Obsoletes: libkactivities < 6.1-100
Provides:  libkactivities = 6.1-100

[snip]

%package devel
Summary: Developer files for %{name}
Obsoletes: libkactivities-devel < 6.1-100
Provides:  libkactivities-devel = 6.1-100

This is correct, the last libkactivities package was 6.1-2%{?dist} and had no Epoch, going to 100 allows for bugfix builds if needed.

Otherwise, the package hasn't changed since it got approved and I can't see anything wrong with it.

APPROVED
Comment 3 Rex Dieter 2011-11-25 23:36:59 UTC 
New Package SCM Request
=======================
Package Name: kactivities
Short Description: API for using and interacting with Activities
Owners: than jreznik kkolfer ltinkl rdieter rnovacek
Branches: f16
InitialCC:
Comment 4 Kevin Kofler 2011-11-25 23:41:28 UTC 
New Package SCM Request
=======================
Package Name: kactivities
Short Description: API for using and interacting with Activities
Owners: than jreznik kkofler ltinkl rdieter rnovacek
Branches: f16
InitialCC:

It helps if my name is spelled correctly. ;-)
Comment 5 Gwyn Ciesla 2011-11-27 22:08:28 UTC 
Git done (by process-git-requests).
Comment 6 Rex Dieter 2011-11-29 14:47:31 UTC 
imported, built.  thanks!
Note You need to log in before you can comment on or make changes to this bug.