Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 757368 - Review Request: telepathy-kde-integration-module - KDE integration for telepathy
Summary: Review Request: telepathy-kde-integration-module - KDE integration for telep...
Keywords:
Status: CLOSED DUPLICATE of bug 784954
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-11-26 17:47 UTC by Rex Dieter
Modified: 2012-02-08 16:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-08 16:29:31 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+

Attachments (Terms of Use)

Description Rex Dieter 2011-11-26 17:47:29 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module-0.2.0-1.fc16.src.rpm
Description: 
This module sits in KDED and takes care of various bits of system
integration like setting user to auto-away or handling connection errors.
Comment 1 nucleo 2011-11-26 18:06:11 UTC 
desktop files installed only in %{_kde4_datadir}/kde4/services/ so no need to add "BuildRequires: desktop-file-utils"
Comment 2 nucleo 2011-11-26 19:05:40 UTC 
"BuildRequires: gettext" needed.
Comment 3 nucleo 2011-12-21 18:50:55 UTC 
Name: ok
Summary: ok (but remove space at end of line)
Source0: ok
md5sum telepathy-kde-integration-module-0.2.0.tar.bz2
c9bdb73c049499c0f72c4ee5fa4fb8fe  telepathy-kde-integration-module-0.2.0.tar.bz2

Build in mock failed if "BuildRequires: gettext" missing.
License: should be LGPLv2+ (GPLv2+ now)

So please fix BuildRequires and License, then package can be approved.
Comment 4 Rex Dieter 2011-12-21 19:59:02 UTC 
Spec : http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module.spec
SRPM: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module-0.2.0-1.fc16.src.rpm

%changelog
* Wed Dec 21 2011 Rex Dieter <rdieter> 0.2.0-2
- BR: -desktop-file-utils, +gettext
- License: LGPLv2+
Comment 5 nucleo 2011-12-21 20:29:28 UTC 
I didn't noticed before that %find_lang should be moved to %install
Comment 6 Rex Dieter 2011-12-21 20:34:10 UTC 
oops, right

Spec :
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module.spec
SRPM:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-integration-module-0.2.0-3.fc16.src.rpm


%changelog
* Wed Dec 21 2011 Rex Dieter <rdieter> 0.2.0-3
- move %%find_lang to %%install
Comment 7 nucleo 2011-12-21 20:56:24 UTC 
rpmlint output:
$ rpmlint telepathy-kde-integration-module-0.2.0-3.fc16.i686.rpm telepathy-kde-integration-module-debuginfo-0.2.0-3.fc16.i686.rpm telepathy-kde-integration-module-0.2.0-3.fc16.src.rpm 
telepathy-kde-integration-module-debuginfo.i686: E: description-line-too-long C This package provides debug information for package telepathy-kde-integration-module.
3 packages and 0 specfiles checked; 1 errors, 0 warnings.

We can't do anything with description for debuginfo so package APPROVED.
Comment 8 nucleo 2011-12-26 20:08:38 UTC 
Looks like they going to rename everything
http://mail.kde.org/pipermail/kde-telepathy/2011-December/004681.html
Comment 9 nucleo 2012-02-08 16:29:31 UTC 

*** This bug has been marked as a duplicate of bug 784954 ***
Note You need to log in before you can comment on or make changes to this bug.