Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 757866 (kde-printer-applet) - Review Request: kde-printer-applet - KDE printer applet
Summary: Review Request: kde-printer-applet - KDE printer applet
Keywords:
Status: CLOSED RAWHIDE
Alias: kde-printer-applet
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kde-4.8
TreeView+ depends on / blocked
 
Reported: 2011-11-28 20:48 UTC by Rex Dieter
Modified: 2012-01-15 01:38 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-15 01:38:54 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2011-11-28 20:48:33 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/printer-applet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeutils/printer-applet-4.7.80-1.fc16.src.rpm
Description:
Printer Applet is a system tray utility that shows current print jobs,
shows printer warnings and errors.


NOTES:
This is being split out in kde-4.7.80 from previously monolithic kdeutils
package.

Starting off here with upstream's 'printer-applet' name, but we probably want to use something less generic, perhaps kde-printer-applet.
Comment 1 Rex Dieter 2011-12-08 18:13:14 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/kde-printer-applet.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdeutils/kde-printer-applet-4.7.90-1.fc16.src.rpm

update to 4.7.90, renamed to kde-printer-applet
Comment 2 Mattia Verga 2011-12-31 10:50:44 UTC 
I think the .desktop file should be renamed to respect the new package name for consistency (from 'printer-applet.desktop' to 'kde-printer-applet.desktop').

Also, the .spec file is missing the desktop-file-validate step.
Comment 3 Kevin Kofler 2011-12-31 16:42:13 UTC 
I don't think renaming the .desktop file makes sense.
Comment 4 Rex Dieter 2011-12-31 17:23:26 UTC 
I'll advocate renaming stuff away from being generic, but I'd also argue it's not something that should be considered a review blocker.
Comment 5 Rex Dieter 2011-12-31 17:23:50 UTC 
make that "being generic... *upstream*"
Comment 6 Kevin Kofler 2011-12-31 18:18:12 UTC 
Agreed, renaming things upstream would make a lot of sense, it's renaming the .desktop file downstream which I don't think is helpful.
Comment 7 Jaroslav Reznik 2012-01-13 17:51:00 UTC 
+1 to not renaming downstream

Name: ok (make sense to use less generic, upstream it?)
Summary: ok
Version: ok

License: ok
Url: ok
BRs: ok
Reqs: ok
Conflicts/Obsoletes/Provides: ok
Description: ok
Macros used consistently: ok
Docs: ok

Missing desktop-file-validate.

rpmlint kde-printer-applet-4.7.97-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Comment 8 Jaroslav Reznik 2012-01-13 18:02:41 UTC 
Sources: ok (md5sum b66e859e551a10e09712217b1d160a95)

For desktop file validation - skip this step, it's autorun desktop file, not shown in Kickstart. I didn't realize it, sorry.

APPROVED
Comment 9 Rex Dieter 2012-01-13 18:05:04 UTC 
New Package SCM Request
=======================
Package Name: kde-printer-applet
Short Description: KDE Printer applet
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16
InitialCC:
Comment 10 Gwyn Ciesla 2012-01-13 18:35:32 UTC 
Git done (by process-git-requests).
Comment 11 Rex Dieter 2012-01-15 01:38:54 UTC 
imported.
Note You need to log in before you can comment on or make changes to this bug.