Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 784944 - Review Request: ktp-accounts-kcm - KDE Configuration Module for Telepathy Instant Messaging Accounts
Summary: Review Request: ktp-accounts-kcm - KDE Configuration Module for Telepathy Ins...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 784945
Blocks: kde-reviews kde-telepathy-0.3
TreeView+ depends on / blocked
 
Reported: 2012-01-26 18:37 UTC by Rex Dieter
Modified: 2012-02-10 22:09 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-10 22:09:58 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2012-01-26 18:37:18 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm-0.3.0-1.fc16.src.rpm
Description:  KDE Configuration Module for Telepathy Instant Messaging Accounts


renaming telepathy-kde-0.1 stuff.
Comment 1 nucleo 2012-02-07 03:19:22 UTC 
name: ok
summary: ok
license: ok
handling locale files: ok
Obsoletes/Provides: ok

BuildRequires: telepathy-qt4-deve not needed because ktp-common-internals-devel requires it.


"rm -f %{buildroot}%{_kde4_libdir}/libkcmtelepathyaccounts.so" is actually not removes anything. Maybe it should be "rm -f %{buildroot}%{_kde4_libdir}/
libktpaccountskcminternal.so" and remove %{_kde4_libdir}/libktpaccountskcminternal.so?

ldd shows that libs installed in kde4 requires only versioned libktpaccountskcminternal.so.4.

This will fix rpmlint warning:
ktp-accounts-kcm.i686: W: devel-file-in-non-devel-package /usr/lib/libktpaccountskcminternal.so

More detailed description can be added from README.
There are many protocol dependencies:
Requires: telepathy-butterfly
Requires: telepathy-gabble
Requires: telepathy-haze
Requires: telepathy-idle
Requires: telepathy-rakia
Requires: telepathy-salut
Requires: telepathy-sunshine

So maybe it makes sense to place every protocol in subpackage with corresponding dependency?
Comment 2 Rex Dieter 2012-02-07 14:08:39 UTC 
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/ktp-accounts-kcm-0.3.0-1.fc16.src.rpm

%changelog
* Tue Feb 07 2012 Rex Dieter <rdieter> 0.3.0-2
- improve %%description
- drop BR: telepathy-qt4-devel
- omit libktpaccountskcminternal.so


Re: So maybe it makes sense to place every protocol in subpackage with
corresponding dependency?

perhaps, but
* currently its simplified to "just work", and follows how gnome/empathy does things
* If we decide to do otherwise, that's a design decision I'd rather make as a team later, and (imo) shouldn't be considered a review blocker here and now.
Comment 3 nucleo 2012-02-07 14:29:57 UTC 
APPROVED
Comment 4 Rex Dieter 2012-02-09 18:44:08 UTC 
New Package SCM Request
=======================
Package Name: ktp-common-internals
Short Description: Common internals for KDE Telepathy
Owners: jreznik rdieter
Branches: f16
Comment 5 Rex Dieter 2012-02-09 18:45:21 UTC 
copy-n-paste fail, let's try again,

New Package SCM Request
=======================
Package Name: ktp-accounts-kcm
Short Description: KDE Configuration Module for Telepathy Instant Messaging Accounts
Owners: jreznik rdieter
Branches: f16
Comment 6 Gwyn Ciesla 2012-02-09 18:54:53 UTC 
Git done (by process-git-requests).

Please take ownership of review BZs.  Thanks!

Added f17.
Comment 7 Kevin Kofler 2012-02-09 22:20:49 UTC 
You can't unassign yourself from an already approved review.
Comment 8 Rex Dieter 2012-02-10 22:09:58 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.