Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 787454 - Review Request: drupal7-theme-ninesixty - 960 Grid System (960.gs) theme for Drupal 7
Summary: Review Request: drupal7-theme-ninesixty - 960 Grid System (960.gs) theme for ...
Keywords:
Status: CLOSED DUPLICATE of bug 743411
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul W. Frields
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: InsightReviews
TreeView+ depends on / blocked
 
Reported: 2012-02-05 09:06 UTC by Peter Borsa
Modified: 2012-02-21 10:53 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-21 10:53:00 UTC
Type: ---
Embargoed:
stickster: fedora-review+


Attachments (Terms of Use)

Description Peter Borsa 2012-02-05 09:06:50 UTC
Spec URL: http://asrob.fedorapeople.org/SOURCES/drupal7-theme-ninesixty.spec
SRPM URL: http://asrob.fedorapeople.org/SOURCES/drupal7-theme-ninesixty-1.0-1.fc16.src.rpm
Description: This theme is based on the 960 Grid System by Nathan Smith.
NineSixty is a base theme with all the files provided by the 960 Grid System.
From the sketch sheets to all the styles from the framework are included. There
are a few modifications so it better fits into Drupal. All the details are
inside the README.txt file.

rpmlint output:

$ rpmlint drupal7-theme-ninesixty.spec ../SRPMS/drupal7-theme-ninesixty-1.0-1.fc16.src.rpm ../RPMS/noarch/drupal7-theme-ninesixty-1.0-1.fc16.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.


koji output:

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=3763580
Watching tasks (this may be safely interrupted)...
3763580 build (f16, drupal7-theme-ninesixty-1.0-1.fc16.src.rpm): open (x86-03.phx2.fedoraproject.org)
  3763581 buildArch (drupal7-theme-ninesixty-1.0-1.fc16.src.rpm, noarch): open (x86-18.phx2.fedoraproject.org)
  3763581 buildArch (drupal7-theme-ninesixty-1.0-1.fc16.src.rpm, noarch): open (x86-18.phx2.fedoraproject.org) -> closed
  0 free  1 open  1 done  0 failed
3763580 build (f16, drupal7-theme-ninesixty-1.0-1.fc16.src.rpm): open (x86-03.phx2.fedoraproject.org) -> closed
  0 free  0 open  2 done  0 failed

3763580 build (f16, drupal7-theme-ninesixty-1.0-1.fc16.src.rpm) completed successfully

Comment 1 Paul W. Frields 2012-02-17 00:16:28 UTC
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.

[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.

[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.

[ O K ] MUST: The package must meet the Packaging Guidelines.

[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.

[ O K ] MUST: The License field in the package spec file must match the actual
license. 

[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.

[ O K ] MUST: The spec file must be written in American English. 

[ O K ] MUST: The spec file for the package MUST be legible. 

[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

$ md5sum rpmbuild/SOURCES/drupal7-theme-ninesixty-1.0/ninesixty-7.x-1.0.tar.gz ; curl -s -o - http://ftp.drupal.org/files/projects/ninesixty-7.x-1.0.tar.gz | md5sum -
360b3412b4055c2e0df3cbdac71f0e74  rpmbuild/SOURCES/drupal7-theme-ninesixty-1.0/ninesixty-7.x-1.0.tar.gz
360b3412b4055c2e0df3cbdac71f0e74  -

[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture. 

[ O K ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. 

[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

[ O K ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

[ O K ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. 

[ O K ] MUST: Packages must NOT bundle copies of system libraries.

[ O K ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. 

[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory. 

[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)

[ FIX ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line. 

** One of the templates has a bad permission 755.  I'd just add a line like this in %prep to fix errant permissions in the extras/ folder:
   find extras -type f | xargs chmod 644   

[ O K ] MUST: Each package must consistently use macros. 

[ O K ] MUST: The package must contain code, or permissable content. 

[ N/A ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). 

[ O K ] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present. 

[ N/A ] MUST: Header files must be in a -devel package. 

[ N/A ] MUST: Static libraries must be in a -static package. 

[ O K ] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. 

[ O K ] MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 

[ O K ] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.

[ O K ] MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section. If you feel that your packaged
GUI application does not need a .desktop file, you must put a comment in the
spec file with your explanation. 

[ O K ] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. 

[ O K ] MUST: All filenames in rpm packages must be valid UTF-8.


** APPROVED, provided the one fix above is included.

Comment 2 Peter Borsa 2012-02-19 21:38:33 UTC
New Package SCM Request
=======================
Package Name: drupal7-theme-ninesixty
Short Description: 960 Grid System (960.gs) theme for Drupal 7
Owners: asrob pfrields
Branches: f15 f16 f17 el5 el6
InitialCC:

Comment 3 Gwyn Ciesla 2012-02-20 02:03:31 UTC
Already exists.

Comment 4 Peter Borsa 2012-02-21 10:53:00 UTC

*** This bug has been marked as a duplicate of bug 743411 ***


Note You need to log in before you can comment on or make changes to this bug.