Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 803317 - Review Request: trac-themeengine-plugin - Simple API and GUI for packaging and configuring Trac themes
Summary: Review Request: trac-themeengine-plugin - Simple API and GUI for packaging an...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-14 12:45 UTC by Andrea Veri
Modified: 2013-05-21 01:46 UTC (History)
3 users (show)

Fixed In Version: trac-themeengine-plugin-2.0.1-20120314svn11382.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-21 01:46:00 UTC
Type: ---
Embargoed:
kevin: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Andrea Veri 2012-03-14 12:45:33 UTC 
Spec URL: http://averi.fedorapeople.org/RPMs/trac-themeengine-plugin/trac-themeengine-plugin.spec
SRPM URL: http://averi.fedorapeople.org/RPMs/trac-themeengine-plugin/trac-themeengine-plugin-2.0.1-20120314svn11382.fc16.src.rpm
Description: A trac plugin that adds a simple API and GUI for packaging and configuring Trac themes.
Comment 1 Kevin Fenzi 2012-03-14 20:22:45 UTC 
I'll review this. Look for a full review in a bit.
Comment 2 Kevin Fenzi 2012-03-14 20:37:54 UTC 
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
see below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin

Issues: 

1. Might be good to ping upstream to include a copy of their license. Right now it's just the 
setup.py statement. 

2. rpmlint says: 

trac-themeengine-plugin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule-min.js
trac-themeengine-plugin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule-min.js
trac-themeengine-plugin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule.js
trac-themeengine-plugin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule.js
trac-themeengine-plugin.src: W: invalid-url Source0: trac-themeengine-plugin-2.0.1.svn11382.tar.gz
2 packages and 0 specfiles checked; 4 errors, 1 warnings.

All those could be ignored. 

I see no blockers here, so this package is APPROVED. 

Happy to co-maintain.
Comment 3 Andrea Veri 2012-03-15 11:20:28 UTC 
New Package SCM Request
=======================
Package Name: trac-themeengine-plugin
Short Description: Simple API and GUI for packaging and configuring Trac themes
Owners: averi kevin
Branches: f16 f17 el6
InitialCC: averi kevin
Comment 4 Gwyn Ciesla 2012-03-15 12:40:25 UTC 
Git done (by process-git-requests).
Comment 5 Fedora Update System 2012-03-15 13:37:23 UTC 
trac-themeengine-plugin-2.0.1-20120314svn11382.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/trac-themeengine-plugin-2.0.1-20120314svn11382.el6
Comment 6 Fedora Update System 2012-03-15 19:53:16 UTC 
trac-themeengine-plugin-2.0.1-20120314svn11382.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 7 Kevin Fenzi 2013-02-03 02:52:05 UTC 
Shall we push this to stable now?
Comment 8 Fedora Update System 2013-05-21 01:46:00 UTC 
trac-themeengine-plugin-2.0.1-20120314svn11382.el6 has been pushed to the Fedora EPEL 6 stable repository.
Note You need to log in before you can comment on or make changes to this bug.