Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 826016 (nepomuk-core) - Review Request: nepomuk-core - Nepomuk Core utilities and libraries
Summary: Review Request: nepomuk-core - Nepomuk Core utilities and libraries
Keywords:
Status: CLOSED RAWHIDE
Alias: nepomuk-core
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2012-05-29 11:15 UTC by Jaroslav Reznik
Modified: 2012-06-09 00:11 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-09 00:11:36 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jaroslav Reznik 2012-05-29 11:15:05 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core-4.8.80.tar.xz
Description: Nepomuk Core utilities and libraries
Fedora Account System Username: jreznik
Comment 1 Rex Dieter 2012-05-29 15:12:52 UTC 
will take a look after kde-sig meeting...
Comment 2 Rex Dieter 2012-05-29 17:05:13 UTC 
naming: ok

sources: ok
$ md5sum *.xz
db4aa40110903973b8a37bea6b13a974  nepomuk-core-4.8.80.tar.xz

1. License: NOT ok
looks like some sources have the standard kde blurb, so we'll likely need to use:

# KDE e.V. may determine that future GPL versions are accepted
License: GPLv2 or GPLv3

here

2.  fix
Requires: kdelibs%{?_isa} >= %{version}
to be:
Requires: kdelibs4%{?_isa} >= %{_kde4_version}
instead.


3.  for the shlibs, probably ought to make a -libs subpkg, with scriptlets (currently missing);
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig


4. add desktop-file-validate

%check
desktop-file-validate %{buildroot}%{_kde4_datadir}/applications/kde4/nepomukbackup.desktop


Fix those, and we should be good.
Comment 3 Rex Dieter 2012-05-29 17:06:16 UTC 
Sorry, for point 1, make that s/GPL/LGPL/
Comment 4 Jaroslav Reznik 2012-05-30 10:36:27 UTC 
(In reply to comment #2)
> naming: ok
> 
> sources: ok
> $ md5sum *.xz
> db4aa40110903973b8a37bea6b13a974  nepomuk-core-4.8.80.tar.xz
> 
> 1. License: NOT ok
> looks like some sources have the standard kde blurb, so we'll likely need to
> use:
> 
> # KDE e.V. may determine that future GPL versions are accepted
> License: GPLv2 or GPLv3

Ok.

> here
> 
> 
> 3.  for the shlibs, probably ought to make a -libs subpkg, with scriptlets
> (currently missing);
> %post libs -p /sbin/ldconfig
> %postun libs -p /sbin/ldconfig

I wasn't sure we want for a small package libs subpackage, but ok. Oh, I forgot ldconfig...

> 
> 4. add desktop-file-validate
> 
> %check
> desktop-file-validate
> %{buildroot}%{_kde4_datadir}/applications/kde4/nepomukbackup.desktop

Ok.

> 
> Fix those, and we should be good.

Thanks.
Comment 5 Jaroslav Reznik 2012-05-30 11:03:25 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core-4.8.80-2.fc16.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=4113948

License and requires fixed, -libs split, desktop-file validation added.
Comment 6 Rex Dieter 2012-05-30 12:31:10 UTC 
Thanks,  Approved.
Comment 7 Jaroslav Reznik 2012-05-30 14:50:51 UTC 
New Package SCM Request
=======================
Package Name: nepomuk-core
Short Description: Nepomuk Core utilities and libraries
Owners: jreznik kkofler rdieter than ltinkl rnovacek
Branches: f17
InitialCC:
Comment 8 Gwyn Ciesla 2012-05-30 17:34:04 UTC 
Git done (by process-git-requests).
Comment 9 Rex Dieter 2012-06-09 00:11:36 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.