Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 826979 (pairs) - Review Request: pairs - Memory and logic stimulation game for preschool children
Summary: Review Request: pairs - Memory and logic stimulation game for preschool children
Keywords:
Status: CLOSED RAWHIDE
Alias: pairs
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lukáš Tinkl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2012-05-31 11:11 UTC by Jaroslav Reznik
Modified: 2015-07-13 17:37 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-19 17:34:54 UTC
Type: ---
Embargoed:
ltinkl: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jaroslav Reznik 2012-05-31 11:11:03 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/pairs/pairs.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/pairs/pairs-4.8.80-1.fc16.src.rpm
Description: Pairs is a collection of games aimed to help the development
of preschool children. With these games the child can improve
memory, logic, hearing and even reading skills. Each game can
have different themes so the child is stimulated with
different and new challenges.

Fedora Account System Username: jreznik

http://koji.fedoraproject.org/koji/taskinfo?taskID=4116544

rpmlint pairs-4.8.80-1.fc16.x86_64.rpm 
pairs.x86_64: W: spelling-error Summary(en_US) pre -> per, ore, pee
pairs.x86_64: W: no-manual-page-for-binary pairs
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Comment 1 Lukáš Tinkl 2012-06-04 13:56:37 UTC 
[ltinkl@goblin pairs]$ rpmlint pairs.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

OK

[ltinkl@goblin pairs]$ rpmlint pairs-4.8.80-1.fc16.src.rpm
pairs.src: W: spelling-error Summary(en_US) pre -> per, ore, pee
pairs.src: W: file-size-mismatch pairs-4.8.80.tar.xz = 2165156, ftp://ftp.kde.org/pub/kde/unstable/4.8.80/src/pairs-4.8.80.tar.xz = 2241628
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Please fix the spelling error (pre-school) and respin the tarball
Comment 2 Lukáš Tinkl 2012-06-04 14:00:18 UTC 
Possible legal issue: the package ships redhat and fedora logos!
Comment 3 Lukáš Tinkl 2012-06-04 14:05:00 UTC 
MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. 

The package should have translations (PO files) included but it doesn't (upstream issue), then it should also package them using the above macro.
Comment 4 Kevin Kofler 2012-06-04 14:08:15 UTC 
This package is part of KDE SC, the translations are in kde-l10n.

And "pre-school" is not misspelled: http://en.wiktionary.org/wiki/pre-school (though "preschool" might be the better spelling, not sure).
Comment 5 Lukáš Tinkl 2012-06-04 14:15:37 UTC 
Yup, ignore the transaltion prob, that's void and also probably the spelling issue; what remains are the logos :)
Comment 6 Jaroslav Reznik 2012-06-04 14:28:03 UTC 
For logos, I think the solution for now is to rip the whole theme from source package, I've already contacted upstream.

Preschool fixed to match description.
Comment 7 Jaroslav Reznik 2012-06-13 15:19:26 UTC 
Spec URL: http://rezza.hofyland.cz/fedora/packages/pairs/pairs.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/pairs/pairs-4.8.90-1.fc16.src.rpm

* Wed Jun 13 2012 Jaroslav Reznik <jreznik> 4.8.90-1
- 4.8.90
- Fedora and the other non-free logo removed
Comment 8 Lukáš Tinkl 2012-06-18 08:52:26 UTC 
Remaining problem solved, good to go
Comment 9 Jaroslav Reznik 2012-06-18 13:49:00 UTC 
New Package SCM Request
=======================
Package Name: pairs
Short Description: Memory and logic stimulation game for preschool children
Owners: jreznik than ltinkl rdieter kkofler rnovacek
Branches: f17
InitialCC:
Comment 10 Gwyn Ciesla 2012-06-18 14:15:55 UTC 
Git done (by process-git-requests).
Comment 11 Rex Dieter 2012-06-19 17:34:54 UTC 
imported
Note You need to log in before you can comment on or make changes to this bug.