Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 841483 - Review Request: kde-plasma-mail-checker - Plasmoid checking for new messages
Summary: Review Request: kde-plasma-mail-checker - Plasmoid checking for new messages
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2012-07-19 06:35 UTC by Fl@sh
Modified: 2014-11-28 13:21 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-28 13:21:19 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Fl@sh 2012-07-19 06:35:57 UTC 
Spec URL: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec

SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/8621/4248621/kde-plasma-mail-checker-1.7.30-1.fc17.src.rpm

Description: 
Plasmoid should periodic check for new messages in configured accounts.
Supported protocols: POP3/POP3S/IMAP4/IMAP4S + IMAP4_IDLE.
Passwords for accounts stored in encrypted container.
Plasmoid use KDE-notification for events about new mail.
Support Akonadi (mimeType : "message/rfc822") resources monitoring
(getting new mail).

Fedora Account System Username: f1ash

Addition:
First package;
need sponsor;
succesful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4248621
Comment 1 Vasiliy Glazov 2012-07-19 07:06:55 UTC 
Hi, Fl@sh.

1. Remove BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

2. Remove %defattr(-,root,root) in %files section.

3. Use %_kde4_appsdir instead of %{_datadir}/kde4/apps
   Also remove string %dir %{_datadir}/kde4/apps/plasma/plasmoids/%{name}
and remove "/*" at the end of previous string.

4. Remove %clean section.

5. Remove dot from the end os Summary.

6. Should add some documentation and license file
Comment 2 Fl@sh 2012-07-19 15:15:52 UTC 
New:
Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/4790/4264790/kde-plasma-mail-checker-1.7.31-1.fc17.src.rpm

In Comment #1.3 : for Fedora koji not corrected (i`m make two attempt);
Comment 3 Gregor Tätzner 2012-07-19 19:44:06 UTC 
the source url is not accessible.
Comment 4 Fl@sh 2012-07-19 20:49:35 UTC 
Tarball uploaded to git. Check it.
Comment 5 Fl@sh 2012-07-20 17:56:58 UTC 
New successfull build:
Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/3051/4283051/kde-plasma-mail-checker-1.7.34-1.fc17.src.rpm
Comment 6 Gregor Tätzner 2012-07-21 18:15:25 UTC 
looks quite good, but you should use %_kde4_appsdir in %files
Comment 7 Fl@sh 2012-07-21 18:57:13 UTC 
I have tried the %{_kde4_appsdir} in %files, but koji does not build the package.
 
Example: http://kojipkgs.fedoraproject.org//work/tasks/4401/4304401/build.log
Comment 8 Rex Dieter 2012-07-23 05:40:13 UTC 
fyi, The %{_kde4_*} macros are defined in /etc/rpm/macros.kde4 owned by kde-settings pkg, so add:

BuildRequires: kde-settings

And, no need to require PyQt4 or python (PyKDE4 already pulls in both PyQt4 and python implicitly)

I'd venture you don't need
BuildRequires: qt-devel
either, as far as I can tell the Makefile simply installs files, and doesn't actually build anything (or if I'm missing something, please do document why this is needed).
Comment 9 Fl@sh 2012-07-23 11:47:21 UTC 
Thanks!
I`m do the comment in spec about qt-devel build require.

New :
Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/2757/4322757/kde-plasma-mail-checker-1.7.35-1.fc17.src.rpm
Comment 10 Kevin Kofler 2012-07-23 17:15:17 UTC 
Please use:
BuildRequires: qt4-devel
instead of:
BuildRequires: qt-devel

The virtual Provides works independently of what version of Qt is the default. (Qt 5 is coming soon.)
Comment 11 Kevin Kofler 2012-07-23 17:17:41 UTC 
> fyi, The %{_kde4_*} macros are defined in /etc/rpm/macros.kde4 owned by
> kde-settings pkg

It's actually owned by kde-filesystem…

> so add:
> BuildRequires: kde-settings

… so this should be:
BuildRequires: kde-filesystem
Comment 12 Fl@sh 2012-07-23 19:02:59 UTC 
Ok, ok... (Well, torture is it to "cook the plasma" *smile*).

New :
Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/4234/4324234/kde-plasma-mail-checker-1.7.35-2.fc17.src.rpm
Comment 13 Peter Lemenkov 2012-08-05 09:13:10 UTC 
Unblocking FE-NEEDSPONSOR - I've just sponsored Fl@sh.
Comment 14 Fl@sh 2012-08-14 08:40:34 UTC 
Someone wants to complete the review?
Comment 15 Aleksandra Fedorova 2012-10-01 16:00:46 UTC 
Since Fl@sh is already sponsored, I am taking this review.
Comment 16 Fl@sh 2012-10-02 21:24:10 UTC 
New successfull build:
Spec: https://raw.github.com/F1ash/plasmaMailChecker/10b7be10db07900861717727cd3a3459bef0caed/kde-plasma-mail-checker.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/2718/4552718/kde-plasma-mail-checker-1.7.41-1.fc17.src.rpm
Comment 17 Fl@sh 2012-11-01 17:40:03 UTC 
New successfull build:
Spec: https://raw.github.com/F1ash/plasmaMailChecker/18f665a433d68a4796ac84846cdc426dbbc698ba/kde-plasma-mail-checker.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/7263/4647263/kde-plasma-mail-checker-1.8.47-1.fc18.src.rpm
Comment 18 Minh Ngo 2012-11-04 18:08:07 UTC 
use desktop-file-validate (from desktop-file-utils package) for validating desktop files
Comment 19 Rex Dieter 2012-11-04 19:24:15 UTC 
that is not applicable in this case
Comment 20 Fl@sh 2012-11-04 19:33:23 UTC 
Minh Ngo
fyi, http://lists.fedoraproject.org/pipermail/kde/2012-August/011826.html
(but this not displayed in instructions).
Comment 21 Fl@sh 2013-02-08 08:43:26 UTC 
Changed git-repo name: https://github.com/F1ash/kde-plasma-mail-checker

SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec

NB: Working on a new version.
Comment 22 Fl@sh 2013-02-18 10:33:54 UTC 
New version, fresh build:
http://kojipkgs.fedoraproject.org//work/tasks/2494/5022494/kde-plasma-mail-checker-1.11.52-1.fc18.src.rpm
Comment 23 Fl@sh 2013-04-02 18:48:21 UTC 
New version, fresh build:
http://kojipkgs.fedoraproject.org//work/tasks/9589/5199589/kde-plasma-mail-checker-1.12.55-1.fc18.src.rpm

SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec
Comment 24 Micah Roth 2013-04-17 15:39:07 UTC 
SRPM link non functional.
Comment 25 Rex Dieter 2013-04-17 15:56:14 UTC 
Aleksandra,
please set the fedora-review flag to ? , if you intend to continue formally reviewing this, thanks.
Comment 26 Fl@sh 2013-04-19 19:42:18 UTC 
Repeat build:
http://kojipkgs.fedoraproject.org//work/tasks/7981/5277981/kde-plasma-mail-checker-1.12.55-1.fc18.src.rpm
Comment 27 Fl@sh 2013-05-31 08:59:20 UTC 
New build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5444444

SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec
SRPM: http://kojipkgs.fedoraproject.org//work/tasks/4445/5444445/kde-plasma-mail-checker-1.15.60-1.fc18.src.rpm
Comment 28 Fl@sh 2013-07-02 19:00:27 UTC 
New build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5566546

SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/6547/5566547/kde-plasma-mail-checker-1.15.62-1.fc19.src.rpm
Comment 29 Kevin Kofler 2013-08-13 14:29:03 UTC 
The Summary should be "Plasmoid checking for new messages", the %description should be "Plasmoid periodically checking for new messages in configured accounts.".
Comment 30 Fl@sh 2013-08-13 15:46:50 UTC 
Thanks)
Comment 31 Fl@sh 2013-08-14 09:10:12 UTC 
SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/1.15.63/kde-plasma-mail-checker.spec

SRPM: http://f1ash.fedorapeople.org/kde-plasma-mail-checker/kde-plasma-mail-checker-1.15.63-2.fc19.src.rpm
Comment 32 Rex Dieter 2013-11-12 22:23:48 UTC 
resetting reviewer, lack of feedback.
Note You need to log in before you can comment on or make changes to this bug.