Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 842296 - Review Request: kde-plasma-akonadi-calendars - Akonadi calendars plasmoid
Summary: Review Request: kde-plasma-akonadi-calendars - Akonadi calendars plasmoid
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Lukáš Tinkl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2012-07-23 12:08 UTC by Jan Grulich
Modified: 2015-07-13 17:36 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-13 02:24:01 UTC
Type: ---
Embargoed:
ltinkl: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jan Grulich 2012-07-23 12:08:33 UTC 
Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec
SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm

Description: 
Hi, this is my first package and i would appreciate review.

Akonadi-calendars is plasmoid for displaying your events from selected Akonadi resources. 

Fedora Account System Username:jgrulich

Succesful build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4322576
http://koji.fedoraproject.org/koji/taskinfo?taskID=4322839
Comment 1 Lukáš Tinkl 2012-07-23 12:43:39 UTC 
- BuildRoot and Group tags are redundant
- Source should point to the canonical source on the internet
- the preferred tarball format is tar.bz2 or even tar.xz
Comment 2 Jan Grulich 2012-07-23 13:12:04 UTC 
New

Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec
SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm
Comment 3 Rex Dieter 2012-07-23 14:48:07 UTC 
I've sponsored Jan into packager group, largely due to other mentoring tasks by Lukáš and other fellow kde-sig'ers.
Comment 4 Lukáš Tinkl 2012-07-24 12:57:05 UTC 
[ltinkl@goblin 842296]$ rpmlint kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm
kde-plasma-akonadi-calendars.src: W: spelling-error Summary(en_US) plasmoid -> plasma
kde-plasma-akonadi-calendars.src: W: spelling-error %description -l en_US plasmoid -> plasma
kde-plasma-akonadi-calendars.src: W: invalid-url Source0: http://kde-look.org/CONTENT/content-files/150034-10534-akonadi-calendars.tar.bz2 HTTP Error 404: Not Found
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

- please provide a working Source URL
Comment 5 Lukáš Tinkl 2012-07-24 12:58:37 UTC 
- the correct URL seems to be: http://kde-look.org/CONTENT/content-files/150034-150034-akonadi-calendars.tar.bz2

- no newline at the end of specfile
Comment 6 Jan Grulich 2012-07-24 13:13:02 UTC 
New:
Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec
SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm

- link and also tarball name fixed
- others are not problems
Comment 7 Lukáš Tinkl 2012-07-24 13:19:55 UTC 
License tag from .spec file (GPLv2+) doesn't match the actual source code license (GPLv3+)
Comment 8 Jan Grulich 2012-07-24 13:27:44 UTC 
New:
Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec
SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm

- fix licence tag
Comment 9 Jan Grulich 2012-07-24 13:34:20 UTC 
New:
Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec
SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm

- add missing newline at the end of specfile
Comment 10 Lukáš Tinkl 2012-07-24 13:38:54 UTC 
Package builds ok, meets all the MUST criteria, license correct too.

RPMlint:

[ltinkl@goblin 842296]$ rpmlint kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm 
kde-plasma-akonadi-calendars.src: W: spelling-error Summary(en_US) plasmoid -> plasma
kde-plasma-akonadi-calendars.src: W: spelling-error %description -l en_US plasmoid -> plasma
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


Builds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4322576
http://koji.fedoraproject.org/koji/taskinfo?taskID=4322839
Comment 11 Jan Grulich 2012-07-25 12:27:44 UTC 
New Package SCM Request
=======================
Package Name: kde-plasma-akonadi-calendars
Short Description: Calendars plasmoid for Akonadi resources
Owners: jgrulich
Branches: f17
InitialCC: jgrulich ltinkl
Comment 12 Gwyn Ciesla 2012-07-25 12:59:25 UTC 
Git done (by process-git-requests).
Comment 13 Fedora Update System 2012-07-25 14:20:28 UTC 
kde-plasma-akonadi-calendars-0.1.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/kde-plasma-akonadi-calendars-0.1.1-1.fc17
Comment 14 Fedora Update System 2012-07-26 04:00:52 UTC 
kde-plasma-akonadi-calendars-0.1.1-1.fc17 has been pushed to the Fedora 17 testing repository.
Comment 15 Fedora Update System 2012-08-13 02:24:01 UTC 
kde-plasma-akonadi-calendars-0.1.1-1.fc17 has been pushed to the Fedora 17 stable repository.
Note You need to log in before you can comment on or make changes to this bug.