Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 843238 - libharu package has not built for multiple Fedora releases
Summary: libharu package has not built for multiple Fedora releases
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libharu
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alex Orlandi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F16FTBFS
TreeView+ depends on / blocked
 
Reported: 2012-07-25 22:10 UTC by Bill Nottingham
Modified: 2014-03-17 03:31 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-31 20:40:57 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
fix direct accesses to libpng's private png_info struct (12.63 KB, patch)
2012-07-28 17:14 UTC, Tom Lane 		no flags Details | Diff
View All

Description Bill Nottingham 2012-07-25 22:10:01 UTC 
This package has not been built since Fedora 15, having failed multiple mass
rebuild cycles.

As part of the normal process for retiring packages that have not
successfully built, this package is scheduled to be removed from Fedora on
or around the Fedora 18 branch date (August 7th).

Please fix this as soon as possible.
Comment 1 Tom Lane 2012-07-28 17:13:22 UTC 
The FTBFS problem is due to libpng no longer allowing direct access to struct png_info.  If there is any interest in reviving this package, I attach a patch to fix that.  I note though that the version we're packaging is obsolete upstream (cf bug #654755), and that the build is full of warnings like
warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O)
So it needs more attention than just applying this patch.
Comment 2 Tom Lane 2012-07-28 17:14:05 UTC 
Created attachment 600935 [details]
fix direct accesses to libpng's private png_info struct
Comment 3 Tom "spot" Callaway 2012-07-31 20:40:57 UTC 
I fixed this in basically the same way, except I conditionalized it so that the old code would be present and work for older libpngs.

Fixed in 2.2.1-1.fc18.
Comment 4 Tom Lane 2012-08-01 05:43:16 UTC 
FWIW, I doubt that conditionalization is necessary --- we have not shipped libpng 1.0 in a very long time.  But anyway, thanks for fixing.
Comment 5 Tom "spot" Callaway 2012-08-01 13:41:40 UTC 
It's clearly unnecessary for Fedora, but in several previous package fixes, the upstream wouldn't take the patch unless it was conditionalized.
Note You need to log in before you can comment on or make changes to this bug.