Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 844766 - scl not built with $RPM_OPT_FLAGS, $RPM_LD_FLAGS
Summary: scl not built with $RPM_OPT_FLAGS, $RPM_LD_FLAGS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: scl-utils
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jindrich Novy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DebugInfo
TreeView+ depends on / blocked
 
Reported: 2012-07-31 17:32 UTC by Ville Skyttä
Modified: 2013-07-02 23:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-02 05:00:25 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Fix dependencies in Makefile (930 bytes, patch)
2012-07-31 17:32 UTC, Ville Skyttä 		no flags Details | Diff
View All

Description Ville Skyttä 2012-07-31 17:32:56 UTC 
Created attachment 601553 [details]
Fix dependencies in Makefile

scl in 20120731-1 is not built with $RPM_OPT_FLAGS:

http://kojipkgs.fedoraproject.org/packages/scl-utils/20120731/1.fc18/data/logs/x86_64/build.log

Well, actually it is, but then "make install" builds it again without them due to broken deps in Makefile. Fix attached.


Another suggested fix that takes care of using $RPM_LD_FLAGS and parallel build:

--- a/scl-utils.spec
+++ b/scl-utils.spec
@@ -26,4 +26,3 @@ Essential RPM build macros for alternative packaging.
 %build
-export CFLAGS="$RPM_OPT_FLAGS"
-make
+make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_LD_FLAGS"
Comment 1 Jindrich Novy 2012-08-02 04:59:49 UTC 
Applied & fixed in rawhide. Thanks!
Note You need to log in before you can comment on or make changes to this bug.