Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 850365 - Introduce new systemd-rpm macros in wesnoth spec file
Summary: Introduce new systemd-rpm macros in wesnoth spec file
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: wesnoth
Version: 18
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 850016
TreeView+ depends on / blocked
 
Reported: 2012-08-21 14:16 UTC by Lukáš Nykrýn
Modified: 2013-08-12 18:33 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-12 18:33:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Lukáš Nykrýn 2012-08-21 14:16:53 UTC
Fedora 18 changes the way how to work with services in spec files. It introduces new macros - %systemd_post, %systemd_preun and %systemd_postun; which replace scriptlets from Fedora 17 and older (see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd, https://bugzilla.redhat.com/show_bug.cgi?id=850016).

Comment 1 Steve Tyler 2013-08-03 17:48:27 UTC
Bug 991376 is for a complete rewrite of the wesnoth.spec file.
Could you take a look at it?

Bug 991376 - RFE: convert wesnoth.spec file to use scons

Comment 2 Václav Pavlín 2013-08-06 08:25:11 UTC
Hi, I see systemd macros are not used in the new spec file - do you need any help with it?

Comment 3 Steve Tyler 2013-08-06 10:39:47 UTC
Thanks, Václav. That's what I needed to know. CCing Will Woods.

Will: There are new systemd macros for spec files.[1] There are slight differences between what they do and what the wesnoth.spec file does.[2]
Could you take a look? (Comment 0 has links to more info.)

Václav: The wesnoth.spec file has some lines for SysV compatibility.
What do you advise for those?

[1] # RPM macros for packages installing systemd unit files
http://cgit.freedesktop.org/systemd/systemd/tree/src/core/macros.systemd.in

[2] wesnoth.spec: Attachment 781670 [details]

Comment 4 Václav Pavlín 2013-08-08 07:10:01 UTC
I think it should be safe now to drop those lines.


Note You need to log in before you can comment on or make changes to this bug.