Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 858085 - Review Request: mingw-qt5-qtxmlpatterns - Qt5 for Windows - QtXmlPatterns component
Summary: Review Request: mingw-qt5-qtxmlpatterns - Qt5 for Windows - QtXmlPatterns com...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 858058
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-17 22:53 UTC by Erik van Pienbroek
Modified: 2015-04-12 18:10 UTC (History)
3 users (show)

Fixed In Version: mingw-qt5-qtwebsockets-5.4.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-31 21:48:47 UTC
Type: Bug
Embargoed:
kalevlember: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Erik van Pienbroek 2012-09-17 22:53:44 UTC 
Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
SRPM URL: http://ftd4linux.nl/contrib/mingw-qt5-qtxmlpatterns-5.0.0-0.1.beta1.fc17.src.rpm
Fedora Account System Username: epienbro
Description: 
This package contains the Qt software toolkit for developing
cross-platform applications.

This is the Windows version of Qt, for use in conjunction with the
Fedora Windows cross-compiler.
Comment 1 Erik van Pienbroek 2012-11-13 01:16:15 UTC 
Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qtxmlpatterns-5.0.0-0.2.beta1.git20121112.69b7a0bb.fc19.src.rpm

* Mon Nov 12 2012 Erik van Pienbroek <epienbro> - 5.0.0-0.2.beta1.git20121112.69b7a0bb
- Update to 20121112 snapshot (rev 69b7a0bb)
- Rebuild against latest mingw-qt5-qtbase
- Dropped pkg-config rename hack as it's unneeded now
Comment 2 Erik van Pienbroek 2013-02-09 12:51:56 UTC 
Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.0.1/1.fc19/src/mingw-qt5-qtxmlpatterns-5.0.1-1.fc19.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=123

* Sat Feb 09 2013 Erik van Pienbroek <epienbro> - 5.0.1-1
- Update to 5.0.1

* Fri Jan 11 2013 Erik van Pienbroek <epienbro> - 5.0.0-1
- Update to Qt 5.0.0 Final
Comment 3 Erik van Pienbroek 2013-05-11 17:29:21 UTC 
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.0.2/1.fc20/src/mingw-qt5-qtxmlpatterns-5.0.2-1.fc20.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=145

* Fri May 10 2013 Erik van Pienbroek <epienbro> - 5.0.2-1
- Update to 5.0.2
Comment 4 Erik van Pienbroek 2013-07-31 21:45:36 UTC 
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.1.0/1.fc20/src/mingw-qt5-qtxmlpatterns-5.1.0-1.fc20.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=156

* Sun Jul 14 2013 Erik van Pienbroek <epienbro> - 5.1.0-1
- Update to 5.1.0
Comment 5 Erik van Pienbroek 2013-12-12 21:48:49 UTC 
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.2.0/0.1.rc1.fc21/src/mingw-qt5-qtxmlpatterns-5.2.0-0.1.rc1.fc21.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=181

* Fri Nov 29 2013 Erik van Pienbroek <epienbro> - 5.2.0-0.1.rc1
- Update to 5.2.0 RC1
Comment 6 Erik van Pienbroek 2014-01-10 19:48:51 UTC 
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.2.0/1.fc21/src/mingw-qt5-qtxmlpatterns-5.2.0-1.fc21.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=185

* Sun Jan 05 2014 Erik van Pienbroek <epienbro> - 5.2.0-1
- Update to 5.2.0
- Dropped manual rename of import libraries
- Added license files
Comment 7 Erik van Pienbroek 2014-05-28 20:22:28 UTC 
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.3.0/1.fc21/src/mingw-qt5-qtxmlpatterns-5.3.0-1.fc21.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=214

* Sun May 25 2014 Erik van Pienbroek <epienbro> - 5.3.0-1
- Update to 5.3.0
Comment 8 Erik van Pienbroek 2015-03-25 07:36:53 UTC 
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.4.1/1.fc23/src/mingw-qt5-qtxmlpatterns-5.4.1-1.fc23.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=259

* Tue Mar 24 2015 Erik van Pienbroek <epienbro> - 5.4.1-1
- Update to 5.4.1
Comment 9 Kalev Lember 2015-03-25 23:02:31 UTC 
Fedora review mingw-qt5-qtxmlpatterns-5.4.1-1.fc23.src.rpm 2015-03-25

$ rpmlint mingw-qt5-qtxmlpatterns-5.4.1-1.fc22.src.rpm \
          mingw32-qt5-qtxmlpatterns-5.4.1-1.fc22.noarch.rpm \
          mingw64-qt5-qtxmlpatterns-5.4.1-1.fc22.noarch.rpm \
          mingw32-qt5-qtxmlpatterns-debuginfo-5.4.1-1.fc22.noarch.rpm \
          mingw64-qt5-qtxmlpatterns-debuginfo-5.4.1-1.fc22.noarch.rpm
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{qt_module}
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{qt_module}
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{snapshot_rev}
mingw32-qt5-qtxmlpatterns-debuginfo.noarch: E: debuginfo-without-sources
mingw64-qt5-qtxmlpatterns-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 2 errors, 4 warnings.

+ OK
! needs attention

+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license for the mingw package is the same as the one for the
  corresponding native Fedora package
! The license text is included in %license

  Can you use %license instead of %doc for the license files, please?

+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
  ec2970e9e9c38f88be74f18101937c28  qtxmlpatterns-opensource-src-5.4.1.tar.xz
  ec2970e9e9c38f88be74f18101937c28  Download/qtxmlpatterns-opensource-src-5.4.1.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
n/a Development files should be in -devel
    Not applicable to MinGW packages.
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8

Looks good to me, just a minor problem with the %license vs %doc macros -- the guidelines were recently updated to require the %license macro for license files. Please fix this before importing.

APPROVED
Comment 10 Erik van Pienbroek 2015-03-26 07:53:02 UTC 
Thanks for the review!

New Package SCM Request
=======================
Package Name: mingw-qt5-qtxmlpatterns
Short Description: Qt5 for Windows - QtXmlPatterns component
Upstream URL: http://www.qt.io/
Owners: epienbro
Branches: f20 f21 f22 epel7
InitialCC:
Comment 11 Gwyn Ciesla 2015-03-26 14:30:31 UTC 
Git done (by process-git-requests).
Comment 12 Fedora Update System 2015-03-26 17:30:26 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.fc22,mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc22,mingw-qt5-qtxmlpatterns-5.4.1-1.fc22
Comment 13 Fedora Update System 2015-03-26 17:32:49 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21
Comment 14 Fedora Update System 2015-03-26 17:33:15 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.fc20,mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc20,mingw-qt5-qtxmlpatterns-5.4.1-1.fc20
Comment 15 Fedora Update System 2015-03-26 17:33:46 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7
Comment 16 Fedora Update System 2015-03-28 18:38:05 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
Comment 17 Fedora Update System 2015-03-31 21:48:47 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.fc22, mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been pushed to the Fedora 22 stable repository.
Comment 18 Fedora Update System 2015-04-06 08:32:56 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.fc21, mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been pushed to the Fedora 21 stable repository.
Comment 19 Fedora Update System 2015-04-06 08:35:10 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.fc20, mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been pushed to the Fedora 20 stable repository.
Comment 20 Fedora Update System 2015-04-12 18:10:59 UTC 
mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
Note You need to log in before you can comment on or make changes to this bug.